From e89242212f72efc71aee9ab2ea108ea27c457c64 Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Mon, 16 Sep 2019 09:55:58 -0700 Subject: [PATCH 1/3] Automatically port IO.Enumeration.FileSystemName remark --- xml/System.IO.Enumeration/FileSystemName.xml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/xml/System.IO.Enumeration/FileSystemName.xml b/xml/System.IO.Enumeration/FileSystemName.xml index 017fabd180e..d5e73865329 100644 --- a/xml/System.IO.Enumeration/FileSystemName.xml +++ b/xml/System.IO.Enumeration/FileSystemName.xml @@ -1,3 +1,4 @@ + @@ -87,7 +88,17 @@ Verifies if the given Win32 expression matches the given name. Supports the following wildcards: '*', '?', '<', '>', '"'. The backslash character '\' escapes. if the given expression matches the given name; otherwise, . - To be added. + + used in `FileSystemWatcher`, which is based off of `RtlIsNameInExpression`, which defines the rules for matching DOS wildcards (`'*'`, `'?'`, `'<'`, `'>'`, '"'). + +Like `PatternMatcher`, matching will not line up with Win32 behavior unless you transform the expression using . + + ]]> + From 776166aface6693cd005292bb5e0558435541077 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Mon, 16 Sep 2019 10:29:01 -0700 Subject: [PATCH 2/3] Remove top line --- xml/System.IO.Enumeration/FileSystemName.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/xml/System.IO.Enumeration/FileSystemName.xml b/xml/System.IO.Enumeration/FileSystemName.xml index d5e73865329..810b42d8414 100644 --- a/xml/System.IO.Enumeration/FileSystemName.xml +++ b/xml/System.IO.Enumeration/FileSystemName.xml @@ -1,4 +1,3 @@ - From b94d7b1696722eecafb186a2ee7caf38fc2ad039 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Wed, 18 Sep 2019 13:58:48 -0700 Subject: [PATCH 3/3] suggestions by rpetrusha Co-Authored-By: Ron Petrusha --- xml/System.IO.Enumeration/FileSystemName.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.IO.Enumeration/FileSystemName.xml b/xml/System.IO.Enumeration/FileSystemName.xml index 810b42d8414..21d381c2848 100644 --- a/xml/System.IO.Enumeration/FileSystemName.xml +++ b/xml/System.IO.Enumeration/FileSystemName.xml @@ -92,9 +92,9 @@ ## Remarks -This is based off of used in `FileSystemWatcher`, which is based off of `RtlIsNameInExpression`, which defines the rules for matching DOS wildcards (`'*'`, `'?'`, `'<'`, `'>'`, '"'). +The syntax of the `expression` parameter is based on the syntax used by , which is based on [RtlIsNameInExpression](/windows/win32/devnotes/rtlisnameinexpression), which defines the rules for matching DOS wildcards (`'*'`, `'?'`, `'<'`, `'>'`, `'"'`). -Like `PatternMatcher`, matching will not line up with Win32 behavior unless you transform the expression using . +Matching will not correspond to Win32 behavior unless you transform the expression using . ]]>