From 84690f936a54f87dcc0e1a566c7e62d8816a7637 Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Mon, 16 Sep 2019 11:49:13 -0700 Subject: [PATCH 1/2] Automatically port Reflection.PortableExecutable.PdbChecksumDebugDirectoryData --- .../PdbChecksumDebugDirectoryData.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Reflection.PortableExecutable/PdbChecksumDebugDirectoryData.xml b/xml/System.Reflection.PortableExecutable/PdbChecksumDebugDirectoryData.xml index 8dc4b123130..409bc180aca 100644 --- a/xml/System.Reflection.PortableExecutable/PdbChecksumDebugDirectoryData.xml +++ b/xml/System.Reflection.PortableExecutable/PdbChecksumDebugDirectoryData.xml @@ -41,7 +41,7 @@ System.String - To be added. + Checksum algorithm name. To be added. To be added. @@ -63,7 +63,7 @@ System.Collections.Immutable.ImmutableArray<System.Byte> - To be added. + GUID (Globally Unique Identifier) of the associated PDB. To be added. To be added. From f3f48daeb6f5f92125286edd260682a9fd26f14b Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Thu, 26 Sep 2019 11:07:08 -0700 Subject: [PATCH 2/2] addressed comments --- .../PdbChecksumDebugDirectoryData.xml | 30 ++++++++++++++----- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/xml/System.Reflection.PortableExecutable/PdbChecksumDebugDirectoryData.xml b/xml/System.Reflection.PortableExecutable/PdbChecksumDebugDirectoryData.xml index 409bc180aca..2aef0985533 100644 --- a/xml/System.Reflection.PortableExecutable/PdbChecksumDebugDirectoryData.xml +++ b/xml/System.Reflection.PortableExecutable/PdbChecksumDebugDirectoryData.xml @@ -20,8 +20,16 @@ - To be added. - To be added. + Represents a PDB Checksum debug directory entry. + + + @@ -41,9 +49,17 @@ System.String - Checksum algorithm name. - To be added. - To be added. + The name of the crypto hash algorithm used to calculate the checksum. + A string representing the name of the crypto hash algorithm used to calculate the checksum. + + + @@ -63,8 +79,8 @@ System.Collections.Immutable.ImmutableArray<System.Byte> - GUID (Globally Unique Identifier) of the associated PDB. - To be added. + The checksum of the PDB content. + An immutable array of bytes representing the checksum of the PDB content. To be added.