From c2eb824c5215256aaa402ce090d3a865c7bd7ba3 Mon Sep 17 00:00:00 2001
From: carlossanlop <calope@microsoft.com>
Date: Mon, 16 Sep 2019 11:46:46 -0700
Subject: [PATCH 1/3] Automatically port
 Reflection.PortableExecutable.DllCharacteristics

---
 .../DllCharacteristics.xml                    | 24 +++++++++----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/xml/System.Reflection.PortableExecutable/DllCharacteristics.xml b/xml/System.Reflection.PortableExecutable/DllCharacteristics.xml
index 998cbf16638..5b0ff5ed536 100644
--- a/xml/System.Reflection.PortableExecutable/DllCharacteristics.xml
+++ b/xml/System.Reflection.PortableExecutable/DllCharacteristics.xml
@@ -49,7 +49,7 @@
       </ReturnValue>
       <MemberValue>4096</MemberValue>
       <Docs>
-        <summary>To be added.</summary>
+        <summary>The image must run inside an AppContainer.</summary>
       </Docs>
     </Member>
     <Member MemberName="DynamicBase">
@@ -74,7 +74,7 @@
       </ReturnValue>
       <MemberValue>64</MemberValue>
       <Docs>
-        <summary>To be added.</summary>
+        <summary>DLL can move.</summary>
       </Docs>
     </Member>
     <Member MemberName="HighEntropyVirtualAddressSpace">
@@ -98,7 +98,7 @@
       </ReturnValue>
       <MemberValue>32</MemberValue>
       <Docs>
-        <summary>To be added.</summary>
+        <summary>The image can handle a high entropy 64-bit virtual address space.</summary>
       </Docs>
     </Member>
     <Member MemberName="NoBind">
@@ -123,7 +123,7 @@
       </ReturnValue>
       <MemberValue>2048</MemberValue>
       <Docs>
-        <summary>To be added.</summary>
+        <summary>Do not bind this image.</summary>
       </Docs>
     </Member>
     <Member MemberName="NoIsolation">
@@ -148,7 +148,7 @@
       </ReturnValue>
       <MemberValue>512</MemberValue>
       <Docs>
-        <summary>To be added.</summary>
+        <summary>The image understands isolation and doesn't want it.</summary>
       </Docs>
     </Member>
     <Member MemberName="NoSeh">
@@ -173,7 +173,7 @@
       </ReturnValue>
       <MemberValue>1024</MemberValue>
       <Docs>
-        <summary>To be added.</summary>
+        <summary>The image does not use SEH. No SE handler may reside in this image.</summary>
       </Docs>
     </Member>
     <Member MemberName="NxCompatible">
@@ -198,7 +198,7 @@
       </ReturnValue>
       <MemberValue>256</MemberValue>
       <Docs>
-        <summary>To be added.</summary>
+        <summary>The image is NX compatible.</summary>
       </Docs>
     </Member>
     <Member MemberName="ProcessInit">
@@ -223,7 +223,7 @@
       </ReturnValue>
       <MemberValue>1</MemberValue>
       <Docs>
-        <summary>To be added.</summary>
+        <summary>Reserved.</summary>
       </Docs>
     </Member>
     <Member MemberName="ProcessTerm">
@@ -248,7 +248,7 @@
       </ReturnValue>
       <MemberValue>2</MemberValue>
       <Docs>
-        <summary>To be added.</summary>
+        <summary>Reserved.</summary>
       </Docs>
     </Member>
     <Member MemberName="TerminalServerAware">
@@ -298,7 +298,7 @@
       </ReturnValue>
       <MemberValue>4</MemberValue>
       <Docs>
-        <summary>To be added.</summary>
+        <summary>Reserved.</summary>
       </Docs>
     </Member>
     <Member MemberName="ThreadTerm">
@@ -323,7 +323,7 @@
       </ReturnValue>
       <MemberValue>8</MemberValue>
       <Docs>
-        <summary>To be added.</summary>
+        <summary>Reserved.</summary>
       </Docs>
     </Member>
     <Member MemberName="WdmDriver">
@@ -348,7 +348,7 @@
       </ReturnValue>
       <MemberValue>8192</MemberValue>
       <Docs>
-        <summary>To be added.</summary>
+        <summary>Driver uses WDM model.</summary>
       </Docs>
     </Member>
   </Members>

From 65998e75f8890bd6ba76b48b8422efa8924eff23 Mon Sep 17 00:00:00 2001
From: carlossanlop <calope@microsoft.com>
Date: Thu, 26 Sep 2019 09:55:15 -0700
Subject: [PATCH 2/3] suggestions by rpetrusha and type summary

---
 .../DllCharacteristics.xml                                | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/xml/System.Reflection.PortableExecutable/DllCharacteristics.xml b/xml/System.Reflection.PortableExecutable/DllCharacteristics.xml
index 5b0ff5ed536..7313aadce51 100644
--- a/xml/System.Reflection.PortableExecutable/DllCharacteristics.xml
+++ b/xml/System.Reflection.PortableExecutable/DllCharacteristics.xml
@@ -23,7 +23,7 @@
     </Attribute>
   </Attributes>
   <Docs>
-    <summary>To be added.</summary>
+    <summary>Describes the characteristics of a dynamic link library.</summary>
     <remarks>To be added.</remarks>
   </Docs>
   <Members>
@@ -74,7 +74,7 @@
       </ReturnValue>
       <MemberValue>64</MemberValue>
       <Docs>
-        <summary>DLL can move.</summary>
+        <summary>The DLL can move.</summary>
       </Docs>
     </Member>
     <Member MemberName="HighEntropyVirtualAddressSpace">
@@ -273,7 +273,7 @@
       </ReturnValue>
       <MemberValue>32768</MemberValue>
       <Docs>
-        <summary>To be added.</summary>
+        <summary>The image is Terminal Server aware.</summary>
       </Docs>
     </Member>
     <Member MemberName="ThreadInit">
@@ -348,7 +348,7 @@
       </ReturnValue>
       <MemberValue>8192</MemberValue>
       <Docs>
-        <summary>Driver uses WDM model.</summary>
+        <summary>The driver uses the WDM model.</summary>
       </Docs>
     </Member>
   </Members>

From e4ed5077f14b9bfd43be512c8fa3a8d0b5fbb93c Mon Sep 17 00:00:00 2001
From: Ron Petrusha <ronpet@microsoft.com>
Date: Fri, 11 Oct 2019 10:18:17 -0700
Subject: [PATCH 3/3] Update DllCharacteristics.xml

---
 xml/System.Reflection.PortableExecutable/DllCharacteristics.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xml/System.Reflection.PortableExecutable/DllCharacteristics.xml b/xml/System.Reflection.PortableExecutable/DllCharacteristics.xml
index 7313aadce51..c317c5ef1f0 100644
--- a/xml/System.Reflection.PortableExecutable/DllCharacteristics.xml
+++ b/xml/System.Reflection.PortableExecutable/DllCharacteristics.xml
@@ -74,7 +74,7 @@
       </ReturnValue>
       <MemberValue>64</MemberValue>
       <Docs>
-        <summary>The DLL can move.</summary>
+        <summary>The DLL can be relocated.</summary>
       </Docs>
     </Member>
     <Member MemberName="HighEntropyVirtualAddressSpace">