Skip to content

Update ns-Microsoft.VisualC.StlClr.Generic.xml #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Update ns-Microsoft.VisualC.StlClr.Generic.xml #3290

merged 4 commits into from
Oct 8, 2019

Conversation

ReQ6W7rFnaBxyfb
Copy link
Contributor

Added missing word to the end of the first sentence.

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

@rpetrusha rpetrusha added the migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN label Oct 3, 2019
@rpetrusha rpetrusha added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Oct 3, 2019
@rpetrusha rpetrusha added this to the October 2019 milestone Oct 3, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ReQ6W7rFnaBxyfb, for contributing to the dotnet/dotnet-api-docs repo and restoring the missing text. I've suggested a change to fully restore the lost text.

@@ -1,6 +1,6 @@
<Namespace Name="Microsoft.VisualC.StlClr.Generic">
<Docs>
<summary>Contains the classes, interfaces, and iterators that are used to implement the generic interface to the . By using this generic interface, other .NET languages, such as C# and Visual Basic, can call code that is written using STL/CLR.</summary>
<summary>Contains the classes, interfaces, and iterators that are used to implement the generic interface to the STL/CLR. By using this generic interface, other .NET languages, such as C# and Visual Basic, can call code that is written using STL/CLR.</summary>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<summary>Contains the classes, interfaces, and iterators that are used to implement the generic interface to the STL/CLR. By using this generic interface, other .NET languages, such as C# and Visual Basic, can call code that is written using STL/CLR.</summary>
<summary>Contains the classes, interfaces, and iterators that are used to implement the generic interface to the STL/CLR Library. By using this generic interface, other .NET languages, such as C# and Visual Basic, can call code that is written using STL/CLR.</summary>

Here is a previous version of the description (from https://docs.microsoft.com/en-us/previous-versions/gg145040(v%3dvs.110):

image

Copy link
Contributor

@mairaw mairaw Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've addressed your feedback @rpetrusha on behalf of @ReQ6W7rFnaBxyfb and also restored the link that once existed as well:
https://msdn.microsoft.com/en-us/library/microsoft.visualc.stlclr.generic(v=vs.100)?toc=xxx

@mairaw mairaw added the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Oct 8, 2019
@mairaw mairaw closed this Oct 8, 2019
@mairaw mairaw reopened this Oct 8, 2019
@rpetrusha rpetrusha merged commit 5cba43f into dotnet:master Oct 8, 2019
@mairaw mairaw removed the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Nov 14, 2019
@ReQ6W7rFnaBxyfb ReQ6W7rFnaBxyfb deleted the patch-1 branch December 4, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants