Skip to content

L133895: Fixing CDATA formatting #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2019
Merged

L133895: Fixing CDATA formatting #3397

merged 1 commit into from
Oct 23, 2019

Conversation

v-maudel
Copy link
Contributor

Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Description: the Markdown CDATA content is incorrectly formatted in source files, moreover it is breaking the target publishing builds since the content inside those tags are being processed as XML tag instead of Markdown content.

Also there is another file that I can't edit that needs the same fix: https://github.com/dotnet/dotnet-api-docs/blob/master/xml/System/String.xml

@mairaw these Issues are related to the previou PR I created here: #3366

Regards

Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Description: the Markdown CDATA content is incorrectly formatted in source files, moreover it is breaking the target publishing builds since the content inside those tags are being processed as XML tag instead of Markdown content.
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdykstra tdykstra merged commit 88360e3 into dotnet:master Oct 23, 2019
@tdykstra
Copy link
Contributor

@v-maudel Is there an issue for the file that was too big to edit in the browser?

@v-maudel
Copy link
Contributor Author

v-maudel commented Oct 23, 2019

Hi @tdykstra , yes, actually the "edit" icon is not available,
image

I can download and modify it in my computer but don't have permissions for upload files in the repo.

@tdykstra
Copy link
Contributor

Sorry, I meant is there a repo issue to track the need to update it? If not I'll create one.

@v-maudel
Copy link
Contributor Author

Oh, my apologies then :)
No, there isn't any issue created, we only create PRs and we were encouraged to not create Issues in Repos in our common worklfow.

@mairaw
Copy link
Contributor

mairaw commented Oct 23, 2019

@v-maudel can you do this not using the GitHub UI? The edit button not being available for large files is a GitHub limitation.

@v-maudel
Copy link
Contributor Author

Hi @mairaw , I'm not sure about it, we only work in the Github page. Although, I know some teams, like localization one, use the Github Desktop app for check files. Maybe I can try this way but I need to do a research on that app first.

@mairaw
Copy link
Contributor

mairaw commented Oct 23, 2019

I'll take care of that fix for you then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants