From 9d21b4e6380eb56d01bf87236008e7ba190fed93 Mon Sep 17 00:00:00 2001
From: Shay Rojansky <roji@roji.org>
Date: Sat, 26 Oct 2019 10:34:30 +0200
Subject: [PATCH 1/2] Fill in some missing docs for SqlClient

---
 xml/System.Data.SqlClient/SqlDataReader.xml | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/xml/System.Data.SqlClient/SqlDataReader.xml b/xml/System.Data.SqlClient/SqlDataReader.xml
index 6bfb025786b..04b520f2fef 100644
--- a/xml/System.Data.SqlClient/SqlDataReader.xml
+++ b/xml/System.Data.SqlClient/SqlDataReader.xml
@@ -246,9 +246,18 @@
         <Parameter Name="disposing" Type="System.Boolean" Index="0" FrameworkAlternate="netcore-2.0;netcore-2.1;netcore-2.2;netcore-3.0" />
       </Parameters>
       <Docs>
-        <param name="disposing">To be added.</param>
-        <summary>To be added.</summary>
-        <remarks>To be added.</remarks>
+        <param name="disposing">
+          <see langword="true" /> to release managed and unmanaged resources; <see langword="false" /> to release only unmanaged resources.</param>
+        </param>
+        <summary>Releases the managed resources used by the <see cref="T:System.Data.SqlClient.SqlDataReader" /> and optionally releases the unmanaged resources.</summary>
+        <remarks>
+          <format type="text/markdown"><![CDATA[
+
+## Remarks
+ This method calls <xref:System.Data.SqlClient.SqlDataReader.Close%2A>.
+
+]]></format>
+        </remarks>
       </Docs>
     </Member>
     <Member MemberName="FieldCount">
@@ -656,8 +665,8 @@
       </ReturnValue>
       <Parameters />
       <Docs>
-        <summary>To be added.</summary>
-        <returns>To be added.</returns>
+        <summary>Gets the column schema (<see cref="T:System.Data.Common.DbColumn" /> collection).</summary>
+        <returns>The column schema (<see cref="T:System.Data.Common.DbColumn" /> collection).</returns>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>

From f40fe4cd3e2e1910c18b276a93f9f99278b40789 Mon Sep 17 00:00:00 2001
From: Maira Wenzel <mairaw@microsoft.com>
Date: Mon, 28 Oct 2019 00:16:42 -0700
Subject: [PATCH 2/2] Fix build error

---
 xml/System.Data.SqlClient/SqlDataReader.xml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xml/System.Data.SqlClient/SqlDataReader.xml b/xml/System.Data.SqlClient/SqlDataReader.xml
index 04b520f2fef..ce2007c0ffa 100644
--- a/xml/System.Data.SqlClient/SqlDataReader.xml
+++ b/xml/System.Data.SqlClient/SqlDataReader.xml
@@ -248,7 +248,6 @@
       <Docs>
         <param name="disposing">
           <see langword="true" /> to release managed and unmanaged resources; <see langword="false" /> to release only unmanaged resources.</param>
-        </param>
         <summary>Releases the managed resources used by the <see cref="T:System.Data.SqlClient.SqlDataReader" /> and optionally releases the unmanaged resources.</summary>
         <remarks>
           <format type="text/markdown"><![CDATA[