Update ObjectSecurity.xml #3444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you call the method SetAccessRuleProtection with both parameters on true, you may create a non-canonical DACL. I just made the most important changes. if you want to provide more details and e.g. code to "repair" the ACE order, I think this should go to a separate topic. I have a colleague who provided sample code.
|
Thanks for your PR @HerbertMauerer. @bartonjs can you take a look? |
mairaw
added
the
✨ 1st-time dotnet-api-docs contributor!
|
@carlossanlop Can you help get this reviewed? |
carlossanlop
reviewed
Mar 2, 2020
carlossanlop
reviewed
Mar 2, 2020
There was a problem hiding this comment.
Thanks for your contribution, @HerbertMauerer . I provided a suggestion for you to consider.
|
The change is OK, I would want to add a reference link to: https://docs.microsoft.com/en-us/windows/win32/secauthz/order-of-aces-in-a-dacl |
HerbertMauerer
commented
Mar 24, 2020
There was a problem hiding this comment.
I want to suggest an additional sentence at the end of the new section:
Please review documentation on the ACE order of an ACL.
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
bartonjs
reviewed
Mar 24, 2020
bartonjs
approved these changes
Mar 25, 2020
|
The CI had errors - the script failed to execute. Closing and reopening so the CI runs again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you call the method SetAccessRuleProtection with both parameters on true, you may create a non-canonical DACL.
I just made the most important changes. if you want to provide more details and e.g. code to "repair" the ACE order, I think this should go to a separate topic.
I have a colleague who provided sample code.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)