From 105a19faf6faebdf9c70038b3d24ecb559681ebf Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Tue, 3 Dec 2019 13:52:19 -0800 Subject: [PATCH 1/2] Document System.IO.StringReader --- xml/System.IO/StringReader.xml | 51 +++++++++++++++++++++++----------- 1 file changed, 35 insertions(+), 16 deletions(-) diff --git a/xml/System.IO/StringReader.xml b/xml/System.IO/StringReader.xml index 9f03769bde9..852a3dcb901 100644 --- a/xml/System.IO/StringReader.xml +++ b/xml/System.IO/StringReader.xml @@ -461,10 +461,11 @@ This implementation of `Close` calls the - To be added. - To be added. - To be added. + When this method returns, contains the characters read from the current source. If the total number of characters read is zero, the span remains unmodified. + Reads all the characters from the input string starting on the current position and advances the current position to the end of the input string. + The total number of characters read into the buffer. To be added. + The current string reader instance is closed. @@ -577,10 +578,10 @@ This implementation of `Close` calls the - To be added. - To be added. - To be added. - To be added. + When this method returns, contains the characters read from the current source. + The token to monitor for cancellation requests. The default value is . + Asynchronously reads all the characters from the input string starting on the current position and advances the current position to the end of the input string. + A task representing the asynchronous read operation. The value of the parameter contains the total number of characters read into the buffer. To be added. @@ -686,10 +687,19 @@ This implementation of `Close` calls the - To be added. - To be added. - To be added. - To be added. + When this method returns, contains the characters read from the current source. If the total number of characters read is zero, the span remains unmodified. + Reads all the characters from the input string starting at the current position and advances the current position to the end of the input string. + The total number of characters read into the buffer. + + internally calls directly. + + ]]> + + The current string reader instance is closed. @@ -720,11 +730,20 @@ This implementation of `Close` calls the - To be added. - To be added. - To be added. - To be added. - To be added. + When this method returns, contains the characters read from the current source. If the total number of characters read is zero, the span remains unmodified. + The token to monitor for cancellation requests. The default value is . + Asynchronously reads all the characters from the input string starting at the current position and advances the current position to the end of the input string. + A task representing the asynchronous read operation. The value of the parameter contains the total number of characters read into the buffer. + + + calls asynchronously, which in turn calls directly. + + ]]> + From 0efb6aa9fcd32dda23ec0e449d751c49d614d6e4 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Tue, 3 Dec 2019 15:29:07 -0800 Subject: [PATCH 2/2] suggestions by gewarren Co-Authored-By: Genevieve Warren --- xml/System.IO/StringReader.xml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xml/System.IO/StringReader.xml b/xml/System.IO/StringReader.xml index 852a3dcb901..569944bf196 100644 --- a/xml/System.IO/StringReader.xml +++ b/xml/System.IO/StringReader.xml @@ -462,7 +462,7 @@ This implementation of `Close` calls the When this method returns, contains the characters read from the current source. If the total number of characters read is zero, the span remains unmodified. - Reads all the characters from the input string starting on the current position and advances the current position to the end of the input string. + Reads all the characters from the input string, starting at the current position, and advances the current position to the end of the input string. The total number of characters read into the buffer. To be added. The current string reader instance is closed. @@ -580,8 +580,8 @@ This implementation of `Close` calls the When this method returns, contains the characters read from the current source. The token to monitor for cancellation requests. The default value is . - Asynchronously reads all the characters from the input string starting on the current position and advances the current position to the end of the input string. - A task representing the asynchronous read operation. The value of the parameter contains the total number of characters read into the buffer. + Asynchronously reads all the characters from the input string, starting at the current position, and advances the current position to the end of the input string. + A task that represents the asynchronous read operation. The value of the parameter contains the total number of characters read into the buffer. To be added. @@ -695,7 +695,7 @@ This implementation of `Close` calls the internally calls directly. + internally calls directly. ]]> @@ -740,7 +740,7 @@ This implementation of `Close` calls the calls asynchronously, which in turn calls directly. + calls asynchronously, which in turn calls directly. ]]>