From 10f14ed410fe48f811e566c232b7f8cf474517d4 Mon Sep 17 00:00:00 2001 From: Ahson Khan Date: Fri, 27 Dec 2019 21:57:29 -0800 Subject: [PATCH 1/4] Fix remarks for JsonElement TryGetDouble and TryGetSingle Add missing `"` and change `it returns false` to `it returns ` --- xml/System.Text.Json/JsonElement.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Text.Json/JsonElement.xml b/xml/System.Text.Json/JsonElement.xml index a630a3dfb9d..b040916a7b5 100644 --- a/xml/System.Text.Json/JsonElement.xml +++ b/xml/System.Text.Json/JsonElement.xml @@ -1159,7 +1159,7 @@ This method does not parse the contents of a JSON string value. This method does not parse the contents of a JSON string value. -On .NET Core, this method does not return `false` for values larger than or smaller than . Instead, it returns and assigns or to `value`. ]]> @@ -1515,7 +1515,7 @@ This method does not parse the contents of a JSON string value. This method does not parse the contents of a JSON string value. -On .NET Core, this method does not return `false` for values larger than or smaller than ). Instead, it returns `false` and assigns or to the `value` argument. +On .NET Core, this method does not return `false` for values larger than or smaller than ). Instead, it returns and assigns or to the `value` argument. ]]> From fd789ca85b67ac42b769be7dfca12b0686ef44c9 Mon Sep 17 00:00:00 2001 From: Ahson Khan Date: Mon, 30 Dec 2019 17:26:15 -0800 Subject: [PATCH 2/4] Update xml/System.Text.Json/JsonElement.xml Co-Authored-By: Genevieve Warren --- xml/System.Text.Json/JsonElement.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Text.Json/JsonElement.xml b/xml/System.Text.Json/JsonElement.xml index b040916a7b5..fd6f919cf53 100644 --- a/xml/System.Text.Json/JsonElement.xml +++ b/xml/System.Text.Json/JsonElement.xml @@ -1159,7 +1159,7 @@ This method does not parse the contents of a JSON string value. This method does not parse the contents of a JSON string value. -On .NET Core, this method does not return `false` for values larger than or smaller than . Instead, it returns and assigns or to `value`. +On .NET Core, this method does not return `false` for values larger than or smaller than . Instead, it returns and assigns or to `value`. ]]> From ce6213b40328f5a20950b27055e4c4019a2a4c49 Mon Sep 17 00:00:00 2001 From: Ahson Khan Date: Mon, 30 Dec 2019 17:26:25 -0800 Subject: [PATCH 3/4] Update xml/System.Text.Json/JsonElement.xml Co-Authored-By: Genevieve Warren --- xml/System.Text.Json/JsonElement.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Text.Json/JsonElement.xml b/xml/System.Text.Json/JsonElement.xml index fd6f919cf53..79af3e45522 100644 --- a/xml/System.Text.Json/JsonElement.xml +++ b/xml/System.Text.Json/JsonElement.xml @@ -1515,7 +1515,7 @@ This method does not parse the contents of a JSON string value. This method does not parse the contents of a JSON string value. -On .NET Core, this method does not return `false` for values larger than or smaller than ). Instead, it returns and assigns or to the `value` argument. +On .NET Core, this method does not return `false` for values larger than or smaller than ). Instead, it returns and assigns or to the `value` argument. ]]> From 6bc63202e1729b3ad1f4fa013173dee1e618ea77 Mon Sep 17 00:00:00 2001 From: Ahson Khan Date: Tue, 31 Dec 2019 13:20:46 -0800 Subject: [PATCH 4/4] Apply suggestions from code review Co-Authored-By: Genevieve Warren --- xml/System.Text.Json/JsonElement.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Text.Json/JsonElement.xml b/xml/System.Text.Json/JsonElement.xml index 79af3e45522..7b2b9eff100 100644 --- a/xml/System.Text.Json/JsonElement.xml +++ b/xml/System.Text.Json/JsonElement.xml @@ -1159,7 +1159,7 @@ This method does not parse the contents of a JSON string value. This method does not parse the contents of a JSON string value. -On .NET Core, this method does not return `false` for values larger than or smaller than . Instead, it returns and assigns or to `value`. +On .NET Core, this method does not return `false` for values larger than or smaller than . Instead, it returns `true` and assigns or to `value`. ]]> @@ -1515,7 +1515,7 @@ This method does not parse the contents of a JSON string value. This method does not parse the contents of a JSON string value. -On .NET Core, this method does not return `false` for values larger than or smaller than ). Instead, it returns and assigns or to the `value` argument. +On .NET Core, this method does not return `false` for values larger than or smaller than ). Instead, it returns `true` and assigns or to the `value` argument. ]]>