-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Enable Try.NET with the new syntax #3769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hmmmm. I tried on the review site here and the focus mode isn't working. I don't know if that's a resource issue or not. |
@BillWagner I tried it as well see the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mairaw and @BillWagner I get the same focus issue.
Selecting "run" on the first example results in the UI popping up, but the code does not fill in and you get an endless "busy" green button. I can paste in the code manually after that step, but you don't get an option to run, the run button just has the rotating circle.
Selecting "run" on the second example on the page copies the code over, but we still get the "busy" green button and it is locked up.
I can't remember if it was doing that before I added the second commit. Let me do a different change on a separate API to test. |
So the new example built and it makes no difference. The first interactive sample uses the old syntax and runs fine. The other one uses the new syntax and the issue happens again. |
@rloutlaw here are my findings with my latest tests:
|
Changing the interactive type made the sample load and run. However, we still need to clear the snippets comments from the resulting code. |
Works now, hooray! I ran it on Chrome and Edge. |
You scared for a second @wadepickett 😄 There's no C++ code running, It's just missing so it displays C# code as a fallback. |
@mairaw , yes, sorry, no C++ code running of course! |
I think the behavior you're seeing @wadepickett is by design. When you select C++, if there are no C++ samples available, it will show an example from a fallback language. In this case, C#. |
Checking if bad ID will be caught by build now |
Snippet comments stripping was deployed to production. Testing. |
Status update:
|
Status update:
This should be good to merge once we confirm that my latest change works for the system.object page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this LGTM @mairaw
I'll now.
/cc @tdykstra Here are try.net examples using the new syntax. It might help on your project. |
@WilliamAntonRohm FYI - this is a new syntax being shipped for Try .NET
With this, you don't need to modify the samples anymore and we can use whole classes
Internal Review Example