From 3662702db187e9c390c4f909bcc8a4f90d50e2ad Mon Sep 17 00:00:00 2001 From: Tanya Solyanik Date: Mon, 10 Feb 2020 16:16:49 -0800 Subject: [PATCH 1/9] HidePrefix and PrefixOnly are still effective --- xml/System.Windows.Forms/TextFormatFlags.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Windows.Forms/TextFormatFlags.xml b/xml/System.Windows.Forms/TextFormatFlags.xml index 777e34b9a64..f99c1bade7c 100644 --- a/xml/System.Windows.Forms/TextFormatFlags.xml +++ b/xml/System.Windows.Forms/TextFormatFlags.xml @@ -183,7 +183,7 @@ 1048576 - A legacy value that has no effect. It ignored the ampersand (&) prefix character in the text, so that the letter that followed was not underlined, but other mnemonic-prefix characters were still processed. + It ignores the ampersand (&) prefix character in the text, so that the letter that follows will not be underlined, but other mnemonic-prefix characters are still processed. @@ -414,7 +414,7 @@ 2097152 - A legacy value that has no effect. It drew only an underline at the position of the character following the ampersand (&) prefix character, and did not draw any other characters in the string. + It draws only an underline at the position of the character following the ampersand (&) prefix character, and does not draw any other characters in the string. From b4dbd0280240bfe83faec296a010aa96584bc60c Mon Sep 17 00:00:00 2001 From: Tanya Solyanik Date: Mon, 10 Feb 2020 16:39:55 -0800 Subject: [PATCH 2/9] corrections for 'ModifyString` flag --- xml/System.Windows.Forms/TextFormatFlags.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xml/System.Windows.Forms/TextFormatFlags.xml b/xml/System.Windows.Forms/TextFormatFlags.xml index f99c1bade7c..eaa0a8968c9 100644 --- a/xml/System.Windows.Forms/TextFormatFlags.xml +++ b/xml/System.Windows.Forms/TextFormatFlags.xml @@ -99,7 +99,7 @@ 32768 - Removes the end of trimmed lines, and replaces them with an ellipsis. + Removes the end of trimmed lines, and replaces them with an ellipsis. The string is not modified unless the flag is specified. Compare with and . @@ -288,7 +288,7 @@ 65536 - Has no effect on the drawn text. + Has no effect on the drawn text. Modifies the specified string parameter to match the displayed text if ellipsis are shown. This value has no effect unless or is specified. @@ -393,7 +393,7 @@ 16384 - Removes the center of trimmed lines and replaces it with an ellipsis. + Removes the center of trimmed lines and replaces it with an ellipsis. The string is not modified unless the flag is specified. Compare with and . @@ -624,7 +624,7 @@ 262144 - Trims the line to the nearest word and an ellipsis is placed at the end of a trimmed line. + Trims the line to the nearest word and an ellipsis is placed at the end of a trimmed line. Compare with and . From a20e47c3041dcb12a352cb2cab16e42b08f82578 Mon Sep 17 00:00:00 2001 From: Tanya Solyanik Date: Mon, 10 Feb 2020 17:59:59 -0800 Subject: [PATCH 3/9] added a distinction between effects of these flags on DrawText and MeasureText --- xml/System.Windows.Forms/TextFormatFlags.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xml/System.Windows.Forms/TextFormatFlags.xml b/xml/System.Windows.Forms/TextFormatFlags.xml index eaa0a8968c9..890fe122dea 100644 --- a/xml/System.Windows.Forms/TextFormatFlags.xml +++ b/xml/System.Windows.Forms/TextFormatFlags.xml @@ -99,7 +99,7 @@ 32768 - Removes the end of trimmed lines, and replaces them with an ellipsis. The string is not modified unless the flag is specified. Compare with and . + Removes the end of trimmed lines, and replaces them with an ellipsis. When used to draw text by `TextRenderer`, the string is not modified unless the flag is specified. Compare with and . @@ -288,7 +288,7 @@ 65536 - Has no effect on the drawn text. Modifies the specified string parameter to match the displayed text if ellipsis are shown. This value has no effect unless or is specified. + Has no effect on the drawn text or text measurements. When used to draw text by `TextRenderer`, modifies the specified string parameter to match the displayed text if ellipsis are shown. This value has no effect unless or is specified. @@ -393,7 +393,7 @@ 16384 - Removes the center of trimmed lines and replaces it with an ellipsis. The string is not modified unless the flag is specified. Compare with and . + Removes the center of trimmed lines and replaces it with an ellipsis. When used to draw text by `TextRenderer`, the string is not modified unless the flag is specified. Compare with and . From a9c60e108dff11fd43ea5c8f83726ff081ebd08e Mon Sep 17 00:00:00 2001 From: Tanya Solyanik Date: Tue, 11 Feb 2020 17:48:28 -0800 Subject: [PATCH 4/9] Update xml/System.Windows.Forms/TextFormatFlags.xml Co-Authored-By: Maira Wenzel --- xml/System.Windows.Forms/TextFormatFlags.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Windows.Forms/TextFormatFlags.xml b/xml/System.Windows.Forms/TextFormatFlags.xml index 890fe122dea..29a615dce28 100644 --- a/xml/System.Windows.Forms/TextFormatFlags.xml +++ b/xml/System.Windows.Forms/TextFormatFlags.xml @@ -99,7 +99,7 @@ 32768 - Removes the end of trimmed lines, and replaces them with an ellipsis. When used to draw text by `TextRenderer`, the string is not modified unless the flag is specified. Compare with and . + Removes the end of trimmed lines, and replaces them with an ellipsis. When used to draw text by TextRenderer, the string is not modified unless the flag is specified. Compare with and . From 5e39a01135881bc4f8aa54fc16795a0417a82321 Mon Sep 17 00:00:00 2001 From: Tanya Solyanik Date: Tue, 11 Feb 2020 17:48:48 -0800 Subject: [PATCH 5/9] Update xml/System.Windows.Forms/TextFormatFlags.xml Co-Authored-By: Maira Wenzel --- xml/System.Windows.Forms/TextFormatFlags.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Windows.Forms/TextFormatFlags.xml b/xml/System.Windows.Forms/TextFormatFlags.xml index 29a615dce28..d1143704242 100644 --- a/xml/System.Windows.Forms/TextFormatFlags.xml +++ b/xml/System.Windows.Forms/TextFormatFlags.xml @@ -183,7 +183,7 @@ 1048576 - It ignores the ampersand (&) prefix character in the text, so that the letter that follows will not be underlined, but other mnemonic-prefix characters are still processed. + Ignores the ampersand (&) prefix character in the text, so that the letter that follows won't be underlined, but other mnemonic-prefix characters are still processed. From e930afd3cc2238a8413ac72160866cc095a7df42 Mon Sep 17 00:00:00 2001 From: Tanya Solyanik Date: Tue, 11 Feb 2020 17:49:04 -0800 Subject: [PATCH 6/9] Update xml/System.Windows.Forms/TextFormatFlags.xml Co-Authored-By: Maira Wenzel --- xml/System.Windows.Forms/TextFormatFlags.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Windows.Forms/TextFormatFlags.xml b/xml/System.Windows.Forms/TextFormatFlags.xml index d1143704242..9285b81b6b2 100644 --- a/xml/System.Windows.Forms/TextFormatFlags.xml +++ b/xml/System.Windows.Forms/TextFormatFlags.xml @@ -393,7 +393,7 @@ 16384 - Removes the center of trimmed lines and replaces it with an ellipsis. When used to draw text by `TextRenderer`, the string is not modified unless the flag is specified. Compare with and . + Removes the center of trimmed lines and replaces it with an ellipsis. When used to draw text by TextRenderer, the string is not modified unless the flag is specified. Compare with and . From dce0ffb2a3da3fa22708e1381955d5473b935934 Mon Sep 17 00:00:00 2001 From: Tanya Solyanik Date: Tue, 11 Feb 2020 17:49:41 -0800 Subject: [PATCH 7/9] Update xml/System.Windows.Forms/TextFormatFlags.xml Co-Authored-By: Maira Wenzel --- xml/System.Windows.Forms/TextFormatFlags.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Windows.Forms/TextFormatFlags.xml b/xml/System.Windows.Forms/TextFormatFlags.xml index 9285b81b6b2..8e05781d365 100644 --- a/xml/System.Windows.Forms/TextFormatFlags.xml +++ b/xml/System.Windows.Forms/TextFormatFlags.xml @@ -414,7 +414,7 @@ 2097152 - It draws only an underline at the position of the character following the ampersand (&) prefix character, and does not draw any other characters in the string. + Draws only an underline at the position of the character following the ampersand (&) prefix character and doesn't draw any other characters in the string. From 61b0b4568bf46af7fa74c4edcff4ab56f4f643eb Mon Sep 17 00:00:00 2001 From: Tanya Solyanik Date: Tue, 11 Feb 2020 17:49:50 -0800 Subject: [PATCH 8/9] Update xml/System.Windows.Forms/TextFormatFlags.xml Co-Authored-By: Maira Wenzel --- xml/System.Windows.Forms/TextFormatFlags.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Windows.Forms/TextFormatFlags.xml b/xml/System.Windows.Forms/TextFormatFlags.xml index 8e05781d365..07eabe7d6c6 100644 --- a/xml/System.Windows.Forms/TextFormatFlags.xml +++ b/xml/System.Windows.Forms/TextFormatFlags.xml @@ -288,7 +288,7 @@ 65536 - Has no effect on the drawn text or text measurements. When used to draw text by `TextRenderer`, modifies the specified string parameter to match the displayed text if ellipsis are shown. This value has no effect unless or is specified. + Has no effect on the drawn text or text measurements. When used to draw text by TextRenderer, modifies the specified string parameter to match the displayed text if ellipsis are shown. This value has no effect unless or is specified. From 3887f3526ecee93d331f01c69d6d1bc32d736796 Mon Sep 17 00:00:00 2001 From: Maira Wenzel Date: Fri, 14 Feb 2020 00:56:49 -0800 Subject: [PATCH 9/9] add missing space --- xml/System.Windows.Forms/TextFormatFlags.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Windows.Forms/TextFormatFlags.xml b/xml/System.Windows.Forms/TextFormatFlags.xml index 07eabe7d6c6..6113cd6bfeb 100644 --- a/xml/System.Windows.Forms/TextFormatFlags.xml +++ b/xml/System.Windows.Forms/TextFormatFlags.xml @@ -288,7 +288,7 @@ 65536 - Has no effect on the drawn text or text measurements. When used to draw text by TextRenderer, modifies the specified string parameter to match the displayed text if ellipsis are shown. This value has no effect unless or is specified. + Has no effect on the drawn text or text measurements. When used to draw text by TextRenderer, modifies the specified string parameter to match the displayed text if ellipsis are shown. This value has no effect unless or is specified.