From 4ee720aaeb3635a1be959d5df40e7d49b8a35cd3 Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Thu, 6 Feb 2020 16:24:10 -0800 Subject: [PATCH 1/3] Add runtime area owners for automatic PR review ownership --- .github/CODEOWNERS | 70 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 67 insertions(+), 3 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 08f1befdda3..7079e10c15a 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -2,6 +2,7 @@ # Each line is a file pattern followed by one or more owners. # More details are here: https://help.github.com/articles/about-codeowners/ +# A CODEOWNERS file uses a pattern that follows the same rules in gitignore files: https://git-scm.com/docs/gitignore#_pattern_format # The '*' pattern is for global owners. @@ -16,8 +17,71 @@ # In each subsection folders are order first by depth, then alphabetically. # This should make it easy to add new rules without breaking existing ones. +# Area owners of the dotnet/runtime repo: https://github.com/dotnet/runtime/blob/master/docs/area-owners.md + +/xml/Microsoft.CSharp**/** @cston @333fred /xml/Microsoft.SqlServer**/** @stevestein -/xml/Microsoft.VisualBasic**/** @KathleenDollard +/xml/Microsoft.VisualBasic**/** @cston @333fred +/xml/Microsoft.Win32**/** @maryamariyan @Anipik +/xml/System/Array.xml @bartonjs @joperezr +/xml/System/Memory*.xml @ahsonkhan +/xml/System/ReadOnlyMemory*.xml @ahsonkhan +/xml/System/ReadOnlySpan*.xml @ahsonkhan +/xml/System/Span*.xml @ahsonkhan +/xml/System/Uri.xml @dotnet/ncl +/xml/System.Buffers**/** @layomia @JeremyKuhne @ahsonkhan +/xml/System.CodeDom**/** @buyaa-n @krwq +/xml/System.Collections**/** @safern +/xml/System.ComponentModel**/** @maryamariyan @safern +/xml/System.ComponentModel.DataAnnotations**/** @lajones @ajcvickers +/xml/System.Configuration**/** @maryamariyan @safern +/xml/System/Console** @wtgodbe /xml/System.Data**/** @stevestein -/xml/System.Net**/** @karelz -/xml/System.Web**/** @scottaddie \ No newline at end of file +/xml/System.Diagnostics**/** @tommcdon @wtgodbe @krwq +/xml/System.Diagnostics.Tracing**/** @Anipik +/xml/System.Diagnostics/DiagnosticSource.xml @Anipik +/xml/System.Diagnostics/PerformanceCounter*.xml @Anipik +/xml/System.Diagnostics/EventLog*.xml @Anipik +/xml/System.Diagnostics/Process*.xml @wtgodbe @krwq +/xml/System.Diagnostics/TraceSource.xml @Anipik +/xml/System.DirectoryServices**/** @tquerec @josephisenhour +/xml/System.Drawing**/** @safern @maryamariyan +/xml/System.Dynamic**/** @cston @333fred +/xml/System.Globalization**/** @krwq @tarekgh +/xml/System.IO**/** @JeremyKuhne @carlossanlop +/xml/System.IO.Compression**/** @carlossanlop @ahsonkhan @ViktorHofer +/xml/System.IO.Pipelines**/** @davidfowl @halter73 @jkotalik @anurse +/xml/System.Linq**/** @maryamariyan +/xml/System.Linq/Parallel*.xml @tarekgh @kouvel +/xml/System.Linq.Expressions**/** @cston @333fred +/xml/System.Management**/** @Anipik +/xml/System.Net**/** @dotnet/ncl +/xml/System.Numerics**/** @tannergooding @ViktorHofer +/xml/System.Reflection**/** @steveharter @GrabYourPitchforks +/xml/System.Reflection.Emit**/** @steveharter @GrabYourPitchforks +/xml/System.Reflection.Metadata**/** @tmat @nguerrera +/xml/System.Resources**/** @krwq @tarekgh +/xml/System.Runtime.Caching**/** @StephenMolloy @HongGit +/xml/System.Runtime.CompilerServices**/** @Anipik +/xml/System.Runtime.InteropServices**/** @AaronRobinsonMSFT @jkoritzinsky +/xml/System.Runtime.InteropServices/RuntimeInformation.xml @bartonjs @joperezr +/xml/System.Runtime.Intrinsics**/** @tannergooding @CarolEidt @RussKeldorph +/xml/System.Runtime.Serialization.Formatters**/** @bartonjs @joperezr +/xml/System.Security**/** @bartonjs @GrabYourPitchforks +/xml/System.Security.Cryptography.Xml**/** @bartonjs +/xml/System.ServiceModel.Syndication**/** @StephenMolloy @HongGit @mconnew +/xml/System.ServiceProcess**/** @Anipik +/xml/System.Text**/** @tarekgh @GrabYourPitchforks +/xml/System.Text/Encoding*.xml @layomia @krwq @tarekgh +/xml/System.Text.Encodings.Web**/** @GrabYourPitchforks @layomia @tarekgh +/xml/System.Text.Json**/** @ahsonkhan @steveharter +/xml/System.Text.RegularExpressions**/** @ViktorHofer @maryamariyan +/xml/System.Threading**/** @kouvel +/xml/System.Threading.Channels**/** @tarekgh @stephentoub +/xml/System.Threading.Tasks**/** @tarekgh @stephentoub +/xml/System.Transactions**/** @dasetser @HongGit +/xml/System.Web**/** @scottaddie +/xml/System.Windows**/** @vatsan-madhavan +/xml/System.Windows.Forms**/** @RussKie +/xml/System.Xaml**/** @vatsan-madhavan +/xml/System.Xml**/** @buyaa-n @krwq From 468590290092cecf664646424568aefde42f775a Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Thu, 20 Feb 2020 15:55:56 -0800 Subject: [PATCH 2/3] Update to latest area ownership --- .github/CODEOWNERS | 78 ++++++++++++++++++++++++++-------------------- 1 file changed, 44 insertions(+), 34 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 7079e10c15a..b2e0ac2e89d 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -19,69 +19,79 @@ # Area owners of the dotnet/runtime repo: https://github.com/dotnet/runtime/blob/master/docs/area-owners.md -/xml/Microsoft.CSharp**/** @cston @333fred -/xml/Microsoft.SqlServer**/** @stevestein -/xml/Microsoft.VisualBasic**/** @cston @333fred -/xml/Microsoft.Win32**/** @maryamariyan @Anipik -/xml/System/Array.xml @bartonjs @joperezr -/xml/System/Memory*.xml @ahsonkhan -/xml/System/ReadOnlyMemory*.xml @ahsonkhan -/xml/System/ReadOnlySpan*.xml @ahsonkhan -/xml/System/Span*.xml @ahsonkhan -/xml/System/Uri.xml @dotnet/ncl -/xml/System.Buffers**/** @layomia @JeremyKuhne @ahsonkhan +/xml/System.Buffers**/** @layomia @JeremyKuhne /xml/System.CodeDom**/** @buyaa-n @krwq -/xml/System.Collections**/** @safern -/xml/System.ComponentModel**/** @maryamariyan @safern +/xml/System.Collections**/** @eiriktsarpalis @layomia +/xml/System.ComponentModel**/** @JeremyKuhne @safern +/xml/System.ComponentModel.Composition**/** @maryamariyan @ViktorHofer /xml/System.ComponentModel.DataAnnotations**/** @lajones @ajcvickers +/xml/System.Composition**/** @maryamariyan @ViktorHofer /xml/System.Configuration**/** @maryamariyan @safern -/xml/System/Console** @wtgodbe -/xml/System.Data**/** @stevestein -/xml/System.Diagnostics**/** @tommcdon @wtgodbe @krwq -/xml/System.Diagnostics.Tracing**/** @Anipik +/xml/System.Data**/** @ajcvickers @cheenamalhotra @david-engel +/xml/System.Data.SqlClient**/** @cheenamalhotra @david-engel @karinazhou @JRahnama +/xml/System.Diagnostics**/** @tommcdon @krwq /xml/System.Diagnostics/DiagnosticSource.xml @Anipik -/xml/System.Diagnostics/PerformanceCounter*.xml @Anipik /xml/System.Diagnostics/EventLog*.xml @Anipik -/xml/System.Diagnostics/Process*.xml @wtgodbe @krwq +/xml/System.Diagnostics/PerformanceCounter*.xml @Anipik +/xml/System.Diagnostics/Process*.xml @adsitnik @eiriktsarpalis /xml/System.Diagnostics/TraceSource.xml @Anipik +/xml/System.Diagnostics.Tracing**/** @Anipik /xml/System.DirectoryServices**/** @tquerec @josephisenhour -/xml/System.Drawing**/** @safern @maryamariyan +/xml/System.Drawing**/** @JeremyKuhne @maryamariyan /xml/System.Dynamic**/** @cston @333fred -/xml/System.Globalization**/** @krwq @tarekgh -/xml/System.IO**/** @JeremyKuhne @carlossanlop -/xml/System.IO.Compression**/** @carlossanlop @ahsonkhan @ViktorHofer +/xml/System.Globalization**/** @safern @krwq @tarekgh +/xml/System.IO.Compression**/** @carlossanlop @ericstj /xml/System.IO.Pipelines**/** @davidfowl @halter73 @jkotalik @anurse -/xml/System.Linq**/** @maryamariyan +/xml/System.IO**/** @JeremyKuhne @carlossanlop @jozkee +/xml/System.Linq**/** @eiriktsarpalis /xml/System.Linq/Parallel*.xml @tarekgh @kouvel /xml/System.Linq.Expressions**/** @cston @333fred /xml/System.Management**/** @Anipik /xml/System.Net**/** @dotnet/ncl -/xml/System.Numerics**/** @tannergooding @ViktorHofer +/xml/System.Numerics**/** @tannergooding @prgovind /xml/System.Reflection**/** @steveharter @GrabYourPitchforks /xml/System.Reflection.Emit**/** @steveharter @GrabYourPitchforks /xml/System.Reflection.Metadata**/** @tmat @nguerrera -/xml/System.Resources**/** @krwq @tarekgh +/xml/System.Resources**/** @buyaa-n @tarekgh @krwq +/xml/System.Runtime**/** @bartonjs @joperezr /xml/System.Runtime.Caching**/** @StephenMolloy @HongGit -/xml/System.Runtime.CompilerServices**/** @Anipik +/xml/System.Runtime.CompilerServices**/** @Anipik @steveharter /xml/System.Runtime.InteropServices**/** @AaronRobinsonMSFT @jkoritzinsky -/xml/System.Runtime.InteropServices/RuntimeInformation.xml @bartonjs @joperezr /xml/System.Runtime.Intrinsics**/** @tannergooding @CarolEidt @RussKeldorph -/xml/System.Runtime.Serialization.Formatters**/** @bartonjs @joperezr -/xml/System.Security**/** @bartonjs @GrabYourPitchforks -/xml/System.Security.Cryptography.Xml**/** @bartonjs +/xml/System.Security**/** @bartonjs @GrabYourPitchforks @krwq /xml/System.ServiceModel.Syndication**/** @StephenMolloy @HongGit @mconnew /xml/System.ServiceProcess**/** @Anipik /xml/System.Text**/** @tarekgh @GrabYourPitchforks /xml/System.Text/Encoding*.xml @layomia @krwq @tarekgh /xml/System.Text.Encodings.Web**/** @GrabYourPitchforks @layomia @tarekgh -/xml/System.Text.Json**/** @ahsonkhan @steveharter -/xml/System.Text.RegularExpressions**/** @ViktorHofer @maryamariyan +/xml/System.Text.Json**/** @layomia @steveharter @jozkee +/xml/System.Text.RegularExpressions**/** @prgovi @eerhardt /xml/System.Threading**/** @kouvel /xml/System.Threading.Channels**/** @tarekgh @stephentoub /xml/System.Threading.Tasks**/** @tarekgh @stephentoub /xml/System.Transactions**/** @dasetser @HongGit /xml/System.Web**/** @scottaddie -/xml/System.Windows**/** @vatsan-madhavan /xml/System.Windows.Forms**/** @RussKie +/xml/System.Windows**/** @vatsan-madhavan /xml/System.Xaml**/** @vatsan-madhavan /xml/System.Xml**/** @buyaa-n @krwq + +# System.Console +/xml/System/Console** @carlossanlop @eiriktsarpalis + +# System.Memory +/xml/System/Memory*.xml @GrabYourPitchforks @adsitnik +/xml/System/ReadOnlyMemory*.xml @GrabYourPitchforks @adsitnik +/xml/System/ReadOnlySpan*.xml @GrabYourPitchforks @adsitnik +/xml/System/Span*.xml @GrabYourPitchforks @adsitnik + +# System.Runtime +/xml/System/Array.xml @bartonjs @joperezr + +# System.Uri +/xml/System/Uri.xml @dotnet/ncl + +/xml/Microsoft.CSharp**/** @cston @333fred +/xml/Microsoft.SqlServer**/** @stevestein +/xml/Microsoft.VisualBasic**/** @cston @333fred +/xml/Microsoft.Win32**/** @maryamariyan @Anipik From 68015969f72a01eb8b2d13cd2a42f93a92999928 Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Fri, 21 Feb 2020 11:24:39 -0800 Subject: [PATCH 3/3] Fixed order for System.IO and System.Windows --- .github/CODEOWNERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index b2e0ac2e89d..7b815514417 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -40,9 +40,9 @@ /xml/System.Drawing**/** @JeremyKuhne @maryamariyan /xml/System.Dynamic**/** @cston @333fred /xml/System.Globalization**/** @safern @krwq @tarekgh +/xml/System.IO**/** @JeremyKuhne @carlossanlop @jozkee /xml/System.IO.Compression**/** @carlossanlop @ericstj /xml/System.IO.Pipelines**/** @davidfowl @halter73 @jkotalik @anurse -/xml/System.IO**/** @JeremyKuhne @carlossanlop @jozkee /xml/System.Linq**/** @eiriktsarpalis /xml/System.Linq/Parallel*.xml @tarekgh @kouvel /xml/System.Linq.Expressions**/** @cston @333fred @@ -71,8 +71,8 @@ /xml/System.Threading.Tasks**/** @tarekgh @stephentoub /xml/System.Transactions**/** @dasetser @HongGit /xml/System.Web**/** @scottaddie -/xml/System.Windows.Forms**/** @RussKie /xml/System.Windows**/** @vatsan-madhavan +/xml/System.Windows.Forms**/** @RussKie /xml/System.Xaml**/** @vatsan-madhavan /xml/System.Xml**/** @buyaa-n @krwq