Skip to content

Add F# to supported langs of ConditionalAttribute #4049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Add F# to supported langs of ConditionalAttribute #4049

merged 1 commit into from
Mar 30, 2020

Conversation

abelbraaksma
Copy link
Contributor

F# was not listed in the summary of languages that support the ConditionalAttribute. Just a small change, added F# there ;).

F# was not listed in the summary of languages that support the `ConditionalAttribute`. Just a small change, added `F#` there ;).
@dotnet-bot dotnet-bot added this to the April 2020 milestone Mar 29, 2020
@mairaw mairaw requested a review from cartermp March 30, 2020 18:24
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cartermp cartermp merged commit 1e63fe8 into dotnet:master Mar 30, 2020
@abelbraaksma
Copy link
Contributor Author

@cartermp, you're welcome, tiny change ;). And sorry to ask the obvious, but after merge, should I delete this branch?

@cartermp
Copy link
Contributor

Entirely up to you. I think GitHub just gives you the option for all PRs now, which is nice for one-off things like this that are done in the web editor.

@abelbraaksma
Copy link
Contributor Author

Got it, wasn't sure I'd delete anything that ought to be kept (in the general sense).

@abelbraaksma abelbraaksma deleted the patch-1 branch March 30, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants