Fixes to system.string #4058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mairaw merged 2 commits into dotnet:master from mairaw:retval

Apr 1, 2020

Contributor

mairaw commented Apr 1, 2020

Removes outdated/manually generated section: https://docs.microsoft.com/en-us/dotnet/api/system.string.-ctor?view=netframework-4.8#version-information
https://docs.microsoft.com/en-us/dotnet/api/system.string.intern?view=netframework-4.8#version-considerations was outdated re. versions
Trying to fix return value formatting issue for https://docs.microsoft.com/en-us/dotnet/api/system.string.system-icomparable-compareto?view=netstandard-1.6#returns

mairaw added 2 commits

March 31, 2020 19:14


          fix return value formatting

056e24f


          more fixes

a95c3fd

mairaw requested a review from a team as a code owner

April 1, 2020 02:22

dotnet-bot added this to the April 2020 milestone

BillWagner approved these changes

View reviewed changes

Member

BillWagner left a comment

Thanks for making these updates @mairaw

This looks great. You can when ready.

mairaw merged commit d137e80 into dotnet:master

mairaw deleted the retval branch

April 1, 2020 15:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet