Add missing docs for System.Collections.Immutable #4060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
new-content
carlossanlop
reviewed
Apr 1, 2020
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
carlossanlop
reviewed
Apr 1, 2020
xml/System.Collections.Immutable/ImmutableDictionary`2+Builder.xml
Outdated
Show resolved
Hide resolved
carlossanlop
reviewed
Apr 1, 2020
xml/System.Collections.Immutable/ImmutableDictionary`2+Builder.xml
Outdated
Show resolved
Hide resolved
carlossanlop
reviewed
Apr 1, 2020
xml/System.Collections.Immutable/ImmutableDictionary`2+Builder.xml
Outdated
Show resolved
Hide resolved
carlossanlop
suggested changes
Apr 1, 2020
There was a problem hiding this comment.
Thanks for the change, @eiriktsarpalis . Most of these remarks were imported from implemented interfaces, but they should be reviewed to determine if they also apply for the current API. Especially examples (don't keep them if they are not testing the current API).
The only message in remarks that should always stay is the one for Explicit Interface Implementations, so don't remove those:
This member is an explicit interface member implementation. It can be used only when the <xref:CurrentTypeDocId> instance is cast to an <xref:InterfaceDocId> interface.
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
….xml Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
….xml Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
….xml Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
BillWagner
added
the
changes-addressed
|
@carlossanlop It looks like all changes have been addressed. |
|
@carlossanlop this should be ready to go in. |
carlossanlop
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contributes to #3914