Skip to content

Migration fixes + minor fixes #4132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2020
Merged

Migration fixes + minor fixes #4132

merged 4 commits into from
Jun 19, 2020

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Apr 19, 2020

Noticed a few content dropout issues while making the other fixes

@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 19, 2020
@mairaw mairaw requested a review from a team April 23, 2020 00:52
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these. Just some spaces missing here and there.

@mairaw
Copy link
Contributor Author

mairaw commented Apr 29, 2020

Good catch @gewarren. I appreciate all the suggestions but feel free to add a comment for me to fix them all if that saves you time. I probably just used a bad regex to replace them 😢

@gewarren
Copy link
Contributor

Good catch @gewarren. I appreciate all the suggestions but feel free to add a comment for me to fix them all if that saves you time. I probably just used a bad regex to replace them 😢

I kept thinking "this must be the last instance", but then it was everywhere 😩 :D

@BillWagner BillWagner modified the milestones: April 2020, June 2020 Jun 1, 2020
mairaw and others added 2 commits June 3, 2020 01:03
@mairaw
Copy link
Contributor Author

mairaw commented Jun 3, 2020

Merge conflicts resolved. This should be good to merge.

@mairaw mairaw merged commit 7eefead into dotnet:master Jun 19, 2020
@mairaw mairaw deleted the mig-fixes branch June 19, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants