Skip to content

Merge master into live #4181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 2, 2020
Merged

Merge master into live #4181

merged 5 commits into from
May 2, 2020

Conversation

cxwtool
Copy link

@cxwtool cxwtool commented Apr 30, 2020

Please don't squash-merge this PR.

krwq and others added 5 commits April 29, 2020 12:33
* Update ObjectSecurity.xml

When you call the method SetAccessRuleProtection with both parameters on true, you may create a non-canonical DACL.
I just made the most important changes. if you want to provide more details and e.g. code to "repair" the ACE order, I think this should go to a separate topic.
I have a colleague who provided sample code.

* Update xml/System.Security.AccessControl/ObjectSecurity.xml

Co-Authored-By: Carlos Sanchez Lopez <[email protected]>

* Update xml/System.Security.AccessControl/ObjectSecurity.xml

Co-authored-by: Jeremy Barton <[email protected]>
Co-authored-by: Carlos Sanchez Lopez <[email protected]>
@dotnet-bot dotnet-bot added this to the May 2020 milestone Apr 30, 2020
@BillWagner BillWagner merged commit 6faa4d0 into live May 2, 2020
@BillWagner BillWagner deleted the publish-12405 branch May 2, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants