Skip to content

Fix SpecialFiles.ProgramFiles docs to match the actual implementation. #4187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Fix SpecialFiles.ProgramFiles docs to match the actual implementation. #4187

merged 2 commits into from
Jun 1, 2020

Conversation

Gnbrkm41
Copy link
Contributor

@Gnbrkm41 Gnbrkm41 commented May 1, 2020

Summary

ProgramFiles return x86 folder when it's run on a x86 process, regardless of the system architecture. This PR fixes the occurrences of "non-x86 system" to "non-x86 process".

Fixes dotnet/runtime#35705
cc @jkotas @sos-dll

* ProgramFiles return x86 folder when it's run on a x86 process, regardless of the system architecture
@dotnet-bot dotnet-bot added this to the May 2020 milestone May 1, 2020
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I'll :shipit:

@BillWagner BillWagner merged commit 81dadda into dotnet:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs about System.Environment.SpecialFolder.ProgramFiles might be wrong
5 participants