Skip to content

Fix comment about complexity ImmutableArray`1.ToBuilder method #4273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

joost-morsink
Copy link
Contributor

The operation is O(n) instead of O(1), because it copies all the elements to the builder.

Summary

Changed the O(1) remark in documentation.

Fixes #4262

The operation is O(n) instead of O(1), because it copies all the elements to the builder.
@dotnet-bot dotnet-bot added this to the May 2020 milestone May 22, 2020
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@gewarren gewarren merged commit 1bc5416 into dotnet:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImmutableArray<T>.ToBuilder method has incorrect remark
4 participants