Skip to content

.NET Interactive: Enable_try_dotnet_to_batch_10b #4343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2020
Merged

.NET Interactive: Enable_try_dotnet_to_batch_10b #4343

merged 3 commits into from
Jun 30, 2020
+107 −145

Conversation

v-mepa
Copy link
Contributor

@v-mepa v-mepa commented Jun 5, 2020

Enable_try_dotnet_to_batch_10b

https://docs.microsoft.com/en-us/dotnet/api/system.exception Batch 10 Can be enabled for first and third examples
https://docs.microsoft.com/en-us/dotnet/api/system.type Batch 10 Remaining examples will work with the new syntax
https://docs.microsoft.com/en-us/dotnet/api/system.object.gethashcode Batch 10 Except sample 4
https://docs.microsoft.com/en-us/dotnet/api/system.random.next Batch 10 Remaining examples will work with the new syntax
https://docs.microsoft.com/en-us/dotnet/api/system.enum Batch 10 Only for the full samples that have the using statements
https://docs.microsoft.com/en-us/dotnet/api/system.collections.generic.dictionary-2.-ctor Batch 10 Remaining examples will work with the new syntax
https://docs.microsoft.com/en-us/dotnet/api/system.string.-ctor Batch 10 Only examples tagged as Example 1, 2 and 3 can be added. Others use unsafe keyword.
https://docs.microsoft.com/en-us/dotnet/api/system.string.normalize Batch 10 Examples seem duplicate. Maybe move them to the MemberGroup area?
https://docs.microsoft.com/en-us/dotnet/api/system.collections.generic.list-1.lastindexof Batch 10 Duplicate samples for all overloads? Potentially move it to the MemberGroup
https://docs.microsoft.com/en-us/dotnet/api/system.collections.generic.queue-1.-ctor Batch 10 Duplicate samples for some overloads? Potentially move it to the MemberGroup
https://docs.microsoft.com/en-us/dotnet/api/system.string.isnormalized Batch 10 Examples seem duplicate. Maybe move them to the MemberGroup area?

@dotnet-bot dotnet-bot added this to the June 2020 milestone Jun 5, 2020
@v-mepa
Copy link
Contributor Author

v-mepa commented Jun 5, 2020

fyi @mairaw

@mairaw mairaw added the 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs label Jun 5, 2020
mairaw
mairaw reviewed Jun 5, 2020
View reviewed changes
mairaw
mairaw requested changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Just a few things to fix.

mairaw
mairaw reviewed Jun 18, 2020
View reviewed changes
xml/System/String.xml
[!code-cpp[string.length#1](~/samples/snippets/cpp/VS_Snippets_CLR/string.length/CPP/length.cpp#1)]
[!code-csharp-interactive[string.length#1](~/samples/snippets/csharp/VS_Snippets_CLR/string.length/CS/length.cs#1)]
[!code-vb[string.length#1](~/samples/snippets/visualbasic/VS_Snippets_CLR/string.length/VB/length.vb#1)]
:::code language="cpp" source="~/samples/snippets/cpp/VS_Snippets_CLR/string.length/CPP/length.cpp" id="Snippet1":::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird... this change made the C# and C++ samples disappear now 🤔
Maybe we should roll back the change for these 3 lines

@mairaw
Copy link
Contributor

mairaw commented Jun 18, 2020

Before you do that, let me try to rebuild this.... the other API was also impacted.

@mairaw mairaw closed this Jun 18, 2020
@mairaw mairaw reopened this Jun 18, 2020
@v-mepa
Copy link
Contributor Author

v-mepa commented Jun 18, 2020

Sure, let me know.

@mairaw mairaw closed this Jun 19, 2020
@mairaw mairaw reopened this Jun 19, 2020
@mairaw mairaw closed this Jun 29, 2020
@mairaw mairaw reopened this Jun 29, 2020
mairaw
mairaw approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug was fixed. Changes look good!

@mairaw mairaw merged commit 944505c into dotnet:master Jun 30, 2020
@v-mepa v-mepa deleted the add_try_dotnet_to_batch_10b branch June 30, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

Assignees
No one assigned
Labels
👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs
Projects
None yet
Milestone
June 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@v-mepa @mairaw @dotnet-bot