From d8c7a9bc5f192588b076c464dd0a888c49c42be2 Mon Sep 17 00:00:00 2001 From: DavidEshtehari Date: Sat, 13 Jun 2020 15:56:46 -0700 Subject: [PATCH 1/3] Unify ports & add a note --- .../VS_Snippets_Remoting/NclSslClientSync/CS/clientsync.cs | 2 +- .../VS_Snippets_Remoting/NclSslClientSync/VB/clientsync.vb | 2 +- xml/System.Net.Security/SslStream.xml | 5 ++++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/samples/snippets/csharp/VS_Snippets_Remoting/NclSslClientSync/CS/clientsync.cs b/samples/snippets/csharp/VS_Snippets_Remoting/NclSslClientSync/CS/clientsync.cs index 53bfdaa77c8..b32b6c48a95 100644 --- a/samples/snippets/csharp/VS_Snippets_Remoting/NclSslClientSync/CS/clientsync.cs +++ b/samples/snippets/csharp/VS_Snippets_Remoting/NclSslClientSync/CS/clientsync.cs @@ -40,7 +40,7 @@ public static void RunClient(string machineName, string serverName) // // Create a TCP/IP client socket. // machineName is the host running the server application. - TcpClient client = new TcpClient(machineName,443); + TcpClient client = new TcpClient(machineName,8080); Console.WriteLine("Client connected."); // Create an SSL stream that will close the client's stream. SslStream sslStream = new SslStream( diff --git a/samples/snippets/visualbasic/VS_Snippets_Remoting/NclSslClientSync/VB/clientsync.vb b/samples/snippets/visualbasic/VS_Snippets_Remoting/NclSslClientSync/VB/clientsync.vb index fe77aae953e..d157bc56155 100644 --- a/samples/snippets/visualbasic/VS_Snippets_Remoting/NclSslClientSync/VB/clientsync.vb +++ b/samples/snippets/visualbasic/VS_Snippets_Remoting/NclSslClientSync/VB/clientsync.vb @@ -36,7 +36,7 @@ Namespace Examples.System.Net ' ' Create a TCP/IP client socket. ' machineName is the host running the server application. - Dim client = New TcpClient(machineName, 443) + Dim client = New TcpClient(machineName, 8080) Console.WriteLine("Client connected.") ' Create an SSL stream that will close the client's stream. diff --git a/xml/System.Net.Security/SslStream.xml b/xml/System.Net.Security/SslStream.xml index dbd30efb0b3..efa4e585a55 100644 --- a/xml/System.Net.Security/SslStream.xml +++ b/xml/System.Net.Security/SslStream.xml @@ -41,7 +41,10 @@ Provides a stream used for client-server communication that uses the Secure Socket Layer (SSL) security protocol to authenticate the server and optionally the client. [!NOTE] +> Be sure you have the private key included in the certificate; cause the server needs it to decrypt the received message otherwise you will get a decryption error on the server-side. + ## Remarks SSL protocols help to provide confidentiality and integrity checking for messages transmitted using an . An SSL connection, such as that provided by , should be used when communicating sensitive information between a client and a server. Using an helps to prevent anyone from reading and tampering with information while it is in transit on the network. From fc1c7bd4b68fe1761da1c555f73366caeff4b6db Mon Sep 17 00:00:00 2001 From: DavidEshtehari Date: Sun, 26 Jul 2020 20:21:40 -0700 Subject: [PATCH 2/3] Address comments --- xml/System.Net.Security/SslStream.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Net.Security/SslStream.xml b/xml/System.Net.Security/SslStream.xml index efa4e585a55..5e64b229903 100644 --- a/xml/System.Net.Security/SslStream.xml +++ b/xml/System.Net.Security/SslStream.xml @@ -43,7 +43,7 @@ [!NOTE] -> Be sure you have the private key included in the certificate; cause the server needs it to decrypt the received message otherwise you will get a decryption error on the server-side. +> Be sure you have the private key included in the certificate; cause the server needs it to decrypt the received messages and complete handshake otherwise you will get a decryption error on the server-side. ## Remarks SSL protocols help to provide confidentiality and integrity checking for messages transmitted using an . An SSL connection, such as that provided by , should be used when communicating sensitive information between a client and a server. Using an helps to prevent anyone from reading and tampering with information while it is in transit on the network. From df7338fbaa9ba69be83662fad43e36426f890b61 Mon Sep 17 00:00:00 2001 From: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Date: Mon, 3 Aug 2020 13:02:32 -0700 Subject: [PATCH 3/3] Some grammar fixes --- xml/System.Net.Security/SslStream.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Net.Security/SslStream.xml b/xml/System.Net.Security/SslStream.xml index 5e64b229903..3808b9e7224 100644 --- a/xml/System.Net.Security/SslStream.xml +++ b/xml/System.Net.Security/SslStream.xml @@ -43,7 +43,7 @@ [!NOTE] -> Be sure you have the private key included in the certificate; cause the server needs it to decrypt the received messages and complete handshake otherwise you will get a decryption error on the server-side. +> Be sure to include the private key in the certificate, otherwise you'll get a decryption error on the server side. The server needs the private key to decrypt the received messages and complete the handshake. ## Remarks SSL protocols help to provide confidentiality and integrity checking for messages transmitted using an . An SSL connection, such as that provided by , should be used when communicating sensitive information between a client and a server. Using an helps to prevent anyone from reading and tampering with information while it is in transit on the network.