Skip to content

Commit 35346a8

Browse files
committed
Don't apply Server GC mode for .NET Monitor 6.x
1 parent 7c13f93 commit 35346a8

File tree

8 files changed

+2
-14
lines changed

8 files changed

+2
-14
lines changed

eng/dockerfile-templates/monitor/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ ENV \
7272
DefaultProcess__Filters__0__Key=ProcessId \
7373
DefaultProcess__Filters__0__Value=1 \
7474
# Remove Unix Domain Socket before starting diagnostic port server
75-
DiagnosticPort__DeleteEndpointOnStartup=true \{{ if monitorMajorMinor != "6.2":
75+
DiagnosticPort__DeleteEndpointOnStartup=true \{{ if dotnetMajor != "6":
7676
# Server GC mode
7777
DOTNET_gcServer=1 \}}
7878
# Logging: JSON format so that analytic platforms can get discrete entry information

src/monitor/6.3/alpine/amd64/Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ ENV \
4747
DefaultProcess__Filters__0__Value=1 \
4848
# Remove Unix Domain Socket before starting diagnostic port server
4949
DiagnosticPort__DeleteEndpointOnStartup=true \
50-
# Server GC mode
51-
DOTNET_gcServer=1 \
5250
# Logging: JSON format so that analytic platforms can get discrete entry information
5351
Logging__Console__FormatterName=json \
5452
# Logging: Use round-trip date/time format without timezone information (always logged in UTC)

src/monitor/6.3/alpine/arm64v8/Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ ENV \
4747
DefaultProcess__Filters__0__Value=1 \
4848
# Remove Unix Domain Socket before starting diagnostic port server
4949
DiagnosticPort__DeleteEndpointOnStartup=true \
50-
# Server GC mode
51-
DOTNET_gcServer=1 \
5250
# Logging: JSON format so that analytic platforms can get discrete entry information
5351
Logging__Console__FormatterName=json \
5452
# Logging: Use round-trip date/time format without timezone information (always logged in UTC)

src/monitor/6.3/cbl-mariner-distroless/amd64/Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ ENV \
4747
DefaultProcess__Filters__0__Value=1 \
4848
# Remove Unix Domain Socket before starting diagnostic port server
4949
DiagnosticPort__DeleteEndpointOnStartup=true \
50-
# Server GC mode
51-
DOTNET_gcServer=1 \
5250
# Logging: JSON format so that analytic platforms can get discrete entry information
5351
Logging__Console__FormatterName=json \
5452
# Logging: Use round-trip date/time format without timezone information (always logged in UTC)

src/monitor/6.3/cbl-mariner-distroless/arm64v8/Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ ENV \
4747
DefaultProcess__Filters__0__Value=1 \
4848
# Remove Unix Domain Socket before starting diagnostic port server
4949
DiagnosticPort__DeleteEndpointOnStartup=true \
50-
# Server GC mode
51-
DOTNET_gcServer=1 \
5250
# Logging: JSON format so that analytic platforms can get discrete entry information
5351
Logging__Console__FormatterName=json \
5452
# Logging: Use round-trip date/time format without timezone information (always logged in UTC)

src/monitor/6.3/cbl-mariner/amd64/Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ ENV \
4747
DefaultProcess__Filters__0__Value=1 \
4848
# Remove Unix Domain Socket before starting diagnostic port server
4949
DiagnosticPort__DeleteEndpointOnStartup=true \
50-
# Server GC mode
51-
DOTNET_gcServer=1 \
5250
# Logging: JSON format so that analytic platforms can get discrete entry information
5351
Logging__Console__FormatterName=json \
5452
# Logging: Use round-trip date/time format without timezone information (always logged in UTC)

src/monitor/6.3/cbl-mariner/arm64v8/Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ ENV \
4747
DefaultProcess__Filters__0__Value=1 \
4848
# Remove Unix Domain Socket before starting diagnostic port server
4949
DiagnosticPort__DeleteEndpointOnStartup=true \
50-
# Server GC mode
51-
DOTNET_gcServer=1 \
5250
# Logging: JSON format so that analytic platforms can get discrete entry information
5351
Logging__Console__FormatterName=json \
5452
# Logging: Use round-trip date/time format without timezone information (always logged in UTC)

tests/Microsoft.DotNet.Docker.Tests/MonitorImageTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ public void VerifyEnvironmentVariables(ProductImageData imageData)
156156
variables.Add(new EnvironmentVariableInfo("DefaultProcess__Filters__0__Value", "1"));
157157
// Existing (orphaned) diagnostic port should be delete before starting server
158158
variables.Add(new EnvironmentVariableInfo("DiagnosticPort__DeleteEndpointOnStartup", "true"));
159-
if (imageData.Version.ToString() != "6.2")
159+
if (imageData.Version.Major != 6)
160160
{
161161
// GC mode should be set to Server
162162
variables.Add(new EnvironmentVariableInfo("DOTNET_gcServer", "1"));

0 commit comments

Comments
 (0)