Skip to content

Commit 0a621a4

Browse files
committed
Fix DefaultDiagnosticPort_Supported_ListenModeOnNonWindows
1 parent c9a1288 commit 0a621a4

File tree

1 file changed

+49
-9
lines changed

1 file changed

+49
-9
lines changed

src/Tools/dotnet-monitor/CommonOptionsExtensions.cs

Lines changed: 49 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,11 @@ private static void MapRootOptions(RootOptions obj, string prefix, string separa
9999
MapGlobalCounterOptions(obj.GlobalCounter, FormattableString.Invariant($"{prefix}{nameof(obj.GlobalCounter)}"), separator, map);
100100
// InProcessFeaturesOptions
101101
// CorsConfigurationOptions
102+
MapDiagnosticPortOptions(obj.DiagnosticPort, FormattableString.Invariant($"{prefix}{nameof(obj.DiagnosticPort)}"), separator, map);
102103
// DiagnosticPortOptions
103104
// EgressOptions
104105
// MetricsOptions
105-
// StorageOptions
106+
MapStorageOptions(obj.Storage, FormattableString.Invariant($"{prefix}{nameof(obj.Storage)}"), separator, map);
106107
// ProcessFilterOptions
107108
// CollectionRuleDefaultsOptions
108109
// Templates
@@ -146,14 +147,6 @@ private static void MapMonitorApiKeyOptions(MonitorApiKeyOptions? obj, string va
146147
}
147148
}
148149

149-
private static void MapString(string? value, string valueName, IDictionary<string, string> map)
150-
{
151-
if (null != value)
152-
{
153-
map.Add(valueName, value);
154-
}
155-
}
156-
157150
private static void MapAzureAdOptions(AzureAdOptions? obj, string valueName, string separator, IDictionary<string, string> map)
158151
{
159152
if (null != obj)
@@ -210,6 +203,45 @@ private static void MapGlobalCounterOptions(GlobalCounterOptions? obj, string va
210203
}
211204
}
212205

206+
private static void MapDiagnosticPortOptions(DiagnosticPortOptions? obj, string valueName, string separator, IDictionary<string, string> map)
207+
{
208+
if (null != obj)
209+
{
210+
string prefix = FormattableString.Invariant($"{valueName}{separator}");
211+
MapDiagnosticPortConnectionMode(obj.ConnectionMode, FormattableString.Invariant($"{prefix}{nameof(obj.ConnectionMode)}"), map);
212+
MapString(obj.EndpointName, FormattableString.Invariant($"{prefix}{nameof(obj.EndpointName)}"), map);
213+
MapInt(obj.MaxConnections, FormattableString.Invariant($"{prefix}{nameof(obj.MaxConnections)}"), map);
214+
MapBool(obj.DeleteEndpointOnStartup, FormattableString.Invariant($"{prefix}{nameof(obj.DeleteEndpointOnStartup)}"), map);
215+
}
216+
}
217+
218+
private static void MapDiagnosticPortConnectionMode(DiagnosticPortConnectionMode? value, string valueName, IDictionary<string, string> map)
219+
{
220+
if (null != value)
221+
{
222+
map.Add(valueName, ConvertUtils.ToString(value, CultureInfo.InvariantCulture));
223+
}
224+
}
225+
226+
private static void MapStorageOptions(StorageOptions? obj, string valueName, string separator, IDictionary<string, string> map)
227+
{
228+
if (null != obj)
229+
{
230+
string prefix = FormattableString.Invariant($"{valueName}{separator}");
231+
MapString(obj.DefaultSharedPath, FormattableString.Invariant($"{prefix}{nameof(obj.DefaultSharedPath)}"), map);
232+
MapString(obj.DumpTempFolder, FormattableString.Invariant($"{prefix}{nameof(obj.DumpTempFolder)}"), map);
233+
MapString(obj.SharedLibraryPath, FormattableString.Invariant($"{prefix}{nameof(obj.SharedLibraryPath)}"), map);
234+
}
235+
}
236+
237+
private static void MapString(string? value, string valueName, IDictionary<string, string> map)
238+
{
239+
if (null != value)
240+
{
241+
map.Add(valueName, ConvertUtils.ToString(value, CultureInfo.InvariantCulture));
242+
}
243+
}
244+
213245
private static void MapFloat(float? value, string valueName, IDictionary<string, string> map)
214246
{
215247
if (null != value)
@@ -226,6 +258,14 @@ private static void MapInt(int? value, string valueName, IDictionary<string, str
226258
}
227259
}
228260

261+
private static void MapBool(bool? value, string valueName, IDictionary<string, string> map)
262+
{
263+
if (null != value)
264+
{
265+
map.Add(valueName, ConvertUtils.ToString(value, CultureInfo.InvariantCulture));
266+
}
267+
}
268+
229269
// private static void MapValue(object? value, string valueName, string separator, IDictionary<string, string> map)
230270
// {
231271
// if (null != value)

0 commit comments

Comments
 (0)