Skip to content

Commit 194a5ea

Browse files
authored
Fix a few binding callsites (#8262)
These should use the generated binding extensions.
1 parent 3510556 commit 194a5ea

File tree

1 file changed

+15
-14
lines changed

1 file changed

+15
-14
lines changed

src/Tools/dotnet-monitor/ServiceCollectionExtensions.cs

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
using Microsoft.Diagnostics.Tools.Monitor.Stacks;
3434
using Microsoft.Diagnostics.Tools.Monitor.StartupHook;
3535
using Microsoft.Extensions.Configuration;
36+
using Microsoft.Extensions.Configuration.Binder.SourceGeneration;
3637
using Microsoft.Extensions.DependencyInjection;
3738
using Microsoft.Extensions.DependencyInjection.Extensions;
3839
using Microsoft.Extensions.FileProviders;
@@ -49,43 +50,43 @@ internal static class ServiceCollectionExtensions
4950
{
5051
public static IServiceCollection ConfigureCors(this IServiceCollection services, IConfiguration configuration)
5152
{
52-
return services.Configure<CorsConfigurationOptions>(configuration.GetSection(ConfigurationKeys.CorsConfiguration));
53+
return BindingExtensions.Configure<CorsConfigurationOptions>(services, configuration.GetSection(ConfigurationKeys.CorsConfiguration));
5354
}
5455

5556
public static IServiceCollection ConfigureDotnetMonitorDebug(this IServiceCollection services, IConfiguration configuration)
5657
{
57-
return services.Configure<DotnetMonitorDebugOptions>(configuration.GetSection(ConfigurationKeys.DotnetMonitorDebug));
58+
return BindingExtensions.Configure<DotnetMonitorDebugOptions>(services, configuration.GetSection(ConfigurationKeys.DotnetMonitorDebug));
5859
}
5960

6061
public static IServiceCollection ConfigureGlobalCounter(this IServiceCollection services, IConfiguration configuration)
6162
{
62-
return services.Configure<GlobalCounterOptions>(configuration.GetSection(ConfigurationKeys.GlobalCounter))
63+
return BindingExtensions.Configure<GlobalCounterOptions>(services, configuration.GetSection(ConfigurationKeys.GlobalCounter))
6364
.AddSingleton<IValidateOptions<GlobalCounterOptions>, DataAnnotationValidateOptions<GlobalCounterOptions>>();
6465

6566
}
6667

6768
public static IServiceCollection ConfigureCollectionRuleDefaults(this IServiceCollection services, IConfiguration configuration)
6869
{
69-
return services.Configure<CollectionRuleDefaultsOptions>(configuration.GetSection(ConfigurationKeys.CollectionRuleDefaults));
70+
return BindingExtensions.Configure<CollectionRuleDefaultsOptions>(services, configuration.GetSection(ConfigurationKeys.CollectionRuleDefaults));
7071
}
7172

7273
public static IServiceCollection ConfigureTemplates(this IServiceCollection services, IConfiguration configuration)
7374
{
74-
return services.Configure<TemplateOptions>(configuration.GetSection(ConfigurationKeys.Templates));
75+
return BindingExtensions.Configure<TemplateOptions>(services, configuration.GetSection(ConfigurationKeys.Templates));
7576
}
7677

7778
public static IServiceCollection ConfigureInProcessFeatures(this IServiceCollection services, IConfiguration configuration)
7879
{
79-
services.Configure<CallStacksOptions>(configuration.GetSection(ConfigurationKeys.InProcessFeatures_CallStacks))
80+
BindingExtensions.Configure<CallStacksOptions>(services, configuration.GetSection(ConfigurationKeys.InProcessFeatures_CallStacks))
8081
.AddSingleton<IPostConfigureOptions<CallStacksOptions>, CallStacksPostConfigureOptions>();
8182

82-
services.Configure<ExceptionsOptions>(configuration.GetSection(ConfigurationKeys.InProcessFeatures_Exceptions))
83+
BindingExtensions.Configure<ExceptionsOptions>(services, configuration.GetSection(ConfigurationKeys.InProcessFeatures_Exceptions))
8384
.AddSingleton<IPostConfigureOptions<ExceptionsOptions>, ExceptionsPostConfigureOptions>();
8485

85-
services.Configure<ParameterCapturingOptions>(configuration.GetSection(ConfigurationKeys.InProcessFeatures_ParameterCapturing))
86+
BindingExtensions.Configure<ParameterCapturingOptions>(services, configuration.GetSection(ConfigurationKeys.InProcessFeatures_ParameterCapturing))
8687
.AddSingleton<IPostConfigureOptions<ParameterCapturingOptions>, ParameterCapturingPostConfigureOptions>();
8788

88-
services.Configure<InProcessFeaturesOptions>(configuration.GetSection(ConfigurationKeys.InProcessFeatures))
89+
BindingExtensions.Configure<InProcessFeaturesOptions>(services, configuration.GetSection(ConfigurationKeys.InProcessFeatures))
8990
.AddSingleton<InProcessFeaturesService>()
9091
.AddSingleton<IEndpointInfoSourceCallbacks, InProcessFeaturesEndpointInfoSourceCallbacks>();
9192

@@ -94,7 +95,7 @@ public static IServiceCollection ConfigureInProcessFeatures(this IServiceCollect
9495

9596
public static IServiceCollection ConfigureMetrics(this IServiceCollection services, IConfiguration configuration)
9697
{
97-
return services.Configure<MetricsOptions>(configuration.GetSection(ConfigurationKeys.Metrics))
98+
return BindingExtensions.Configure<MetricsOptions>(services, configuration.GetSection(ConfigurationKeys.Metrics))
9899
.AddSingleton<IValidateOptions<MetricsOptions>, DataAnnotationValidateOptions<MetricsOptions>>()
99100
.AddSingleton<MetricsStoreService>()
100101
.AddHostedService<MetricsService>()
@@ -103,7 +104,7 @@ public static IServiceCollection ConfigureMetrics(this IServiceCollection servic
103104

104105
public static IServiceCollection ConfigureMonitorApiKeyOptions(this IServiceCollection services, IConfiguration configuration, bool allowConfigurationUpdates)
105106
{
106-
services.Configure<MonitorApiKeyOptions>(configuration.GetSection(ConfigurationKeys.MonitorApiKey));
107+
BindingExtensions.Configure<MonitorApiKeyOptions>(services, configuration.GetSection(ConfigurationKeys.MonitorApiKey));
107108

108109
// Loads and validates MonitorApiKeyOptions into MonitorApiKeyConfiguration
109110
services.AddSingleton<IPostConfigureOptions<MonitorApiKeyConfiguration>, MonitorApiKeyPostConfigure>();
@@ -237,7 +238,7 @@ public static IServiceCollection RegisterCollectionRuleTrigger<TFactory, TOption
237238

238239
public static IServiceCollection ConfigureStorage(this IServiceCollection services, IConfiguration configuration)
239240
{
240-
services.Configure<StorageOptions>(configuration.GetSection(ConfigurationKeys.Storage));
241+
BindingExtensions.Configure<StorageOptions>(services, configuration.GetSection(ConfigurationKeys.Storage));
241242
services.AddSingleton<IPostConfigureOptions<StorageOptions>, StoragePostConfigureOptions>();
242243
return services;
243244
}
@@ -255,7 +256,7 @@ public static IServiceCollection ConfigureCapabilities(this IServiceCollection s
255256

256257
public static IServiceCollection ConfigureDefaultProcess(this IServiceCollection services, IConfiguration configuration)
257258
{
258-
return services.Configure<ProcessFilterOptions>(configuration.GetSection(ConfigurationKeys.DefaultProcess));
259+
return BindingExtensions.Configure<ProcessFilterOptions>(services, configuration.GetSection(ConfigurationKeys.DefaultProcess));
259260
}
260261

261262
public static IServiceCollection ConfigureExtensions(this IServiceCollection services)
@@ -333,7 +334,7 @@ public static IServiceCollection ConfigureEgress(this IServiceCollection service
333334

334335
public static IServiceCollection ConfigureDiagnosticPort(this IServiceCollection services, IConfiguration configuration)
335336
{
336-
services.Configure<DiagnosticPortOptions>(configuration.GetSection(ConfigurationKeys.DiagnosticPort));
337+
BindingExtensions.Configure<DiagnosticPortOptions>(services, configuration.GetSection(ConfigurationKeys.DiagnosticPort));
337338
services.AddSingleton<IPostConfigureOptions<DiagnosticPortOptions>, DiagnosticPortPostConfigureOptions>();
338339
services.AddSingleton<IValidateOptions<DiagnosticPortOptions>, DiagnosticPortValidateOptions>();
339340

0 commit comments

Comments
 (0)