Skip to content

Commit 2b6b4da

Browse files
Merge remote-tracking branch 'origin/main' into feature/10.0
2 parents 83260bd + fc938da commit 2b6b4da

File tree

19 files changed

+482
-143
lines changed

19 files changed

+482
-143
lines changed

.github/learning-path-sha.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0c3a91196f7e0abe8b9fa5cd8907378c4598b10a
1+
e973263b09f539d9e3751799a1c4416d0b9b2749

.github/releases.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,17 +35,17 @@
3535
"outOfSupportDate": "2025-05-11T00:00:00.000Z"
3636
},
3737
"9.0": {
38-
"tag": "v9.0.3",
38+
"tag": "v9.0.4",
3939
"minorReleaseDate": "2024-11-12T00:00:00.000Z",
40-
"patchReleaseDate": "2025-05-13T00:00:00.000Z",
40+
"patchReleaseDate": "2025-08-06T00:00:00.000Z",
4141
"supportedFrameworks": [
4242
"net9.0"
4343
]
4444
},
4545
"8.1": {
46-
"tag": "v8.1.1",
46+
"tag": "v8.1.2",
4747
"minorReleaseDate": "2025-02-11T00:00:00.000Z",
48-
"patchReleaseDate": "2025-05-14T00:00:00.000Z",
48+
"patchReleaseDate": "2025-08-06T00:00:00.000Z",
4949
"supportedFrameworks": [
5050
"net8.0"
5151
]

.github/workflows/spellcheck.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,23 @@ jobs:
1717
with:
1818
persist-credentials: false
1919

20-
- uses: streetsidesoftware/cspell-action@6f05386161564ebe24dcfa1513cde203230d1edc
20+
- uses: streetsidesoftware/cspell-action@dcd03dc3e8a59ec2e360d0c62db517baa0b4bb6d
2121
name: Documentation spellcheck
2222
if: ${{ !cancelled() }}
2323
with:
2424
files: '**/*.md'
2525
inline: error
2626
incremental_files_only: true
2727

28-
- uses: streetsidesoftware/cspell-action@6f05386161564ebe24dcfa1513cde203230d1edc
28+
- uses: streetsidesoftware/cspell-action@dcd03dc3e8a59ec2e360d0c62db517baa0b4bb6d
2929
name: Resx spellcheck
3030
if: ${{ !cancelled() }}
3131
with:
3232
files: 'src/**/*.resx'
3333
inline: error
3434
incremental_files_only: true
3535

36-
- uses: streetsidesoftware/cspell-action@6f05386161564ebe24dcfa1513cde203230d1edc
36+
- uses: streetsidesoftware/cspell-action@dcd03dc3e8a59ec2e360d0c62db517baa0b4bb6d
3737
name: Source code spellcheck
3838
if: ${{ !cancelled() }}
3939
with:

.vscode/settings.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
"omnisharp.enableAsyncCompletion": true,
3030
"omnisharp.enableEditorConfigSupport": true,
3131
"omnisharp.enableRoslynAnalyzers": true,
32-
"omnisharp.organizeImportsOnFormat": true,
3332
"omnisharp.autoStart": true,
3433

3534
// ms-vscode.powershell settings
@@ -47,5 +46,6 @@
4746
"xml",
4847
"msbuild",
4948
"javascript"
50-
]
49+
],
50+
"dotnet.formatting.organizeImportsOnFormat": true
5151
}

documentation/learningPath/aks.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ In addition to its availability as a .NET CLI tool, the `dotnet monitor` tool is
66

77
This workflow takes your local development copy of `dotnet-monitor`, patches it with a local development copy of the [.NET Core Diagnostics Repo](https://github.com/dotnet/diagnostics#net-core-diagnostics-repo), and makes it available as an image for you to consume in an ACR (Azure Container Registry). Note that there are many other ways to do this - this is meant to serve as a basic template that can be adapted to match your needs.
88

9-
1. Open `pwsh` and run the [generate-dev-sln script](https://github.com/dotnet/dotnet-monitor/blob/0c3a91196f7e0abe8b9fa5cd8907378c4598b10a/generate-dev-sln.ps1), providing a path to your local copy of the diagnostics repo.
9+
1. Open `pwsh` and run the [generate-dev-sln script](https://github.com/dotnet/dotnet-monitor/blob/e973263b09f539d9e3751799a1c4416d0b9b2749/generate-dev-sln.ps1), providing a path to your local copy of the diagnostics repo.
1010

1111
> [!NOTE]
1212
> If your changes do not involve the [.NET Core Diagnostics Repo](https://github.com/dotnet/diagnostics#net-core-diagnostics-repo), you don't need to complete this step.

documentation/learningPath/api.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@ dotnet-monitor exposes functionality through both [collection rules](./collectio
44

55
## Adding New APIs
66

7-
The web API surface is defined by a series of controllers [here](https://github.com/dotnet/dotnet-monitor/blob/0c3a91196f7e0abe8b9fa5cd8907378c4598b10a/src/Microsoft.Diagnostics.Monitoring.WebApi/Controllers/). It's common for an API to expose functionality also available via [Actions](./collectionrules.md#actions) and so methods in these controllers are often wrappers around a shared implementation. Each controller may have one or more attributes that configure how and where it is exposed, you can learn more about the notable controller attributes [here](#notable-controller-attributes).
7+
The web API surface is defined by a series of controllers [here](https://github.com/dotnet/dotnet-monitor/blob/e973263b09f539d9e3751799a1c4416d0b9b2749/src/Microsoft.Diagnostics.Monitoring.WebApi/Controllers/). It's common for an API to expose functionality also available via [Actions](./collectionrules.md#actions) and so methods in these controllers are often wrappers around a shared implementation. Each controller may have one or more attributes that configure how and where it is exposed, you can learn more about the notable controller attributes [here](#notable-controller-attributes).
88

9-
If the new API needs to either accept or return structured data, a dedicated model should be used. Models are defined [here](https://github.com/dotnet/dotnet-monitor/blob/0c3a91196f7e0abe8b9fa5cd8907378c4598b10a/src/Microsoft.Diagnostics.Monitoring.WebApi/Models/).
9+
If the new API needs to either accept or return structured data, a dedicated model should be used. Models are defined [here](https://github.com/dotnet/dotnet-monitor/blob/e973263b09f539d9e3751799a1c4416d0b9b2749/src/Microsoft.Diagnostics.Monitoring.WebApi/Models/).
1010

1111
When adding a new API, it's important to also update the [`openapi.json`](../openapi.json) spec which describes the API surface. There are CI tests that will ensure this file has been updated to reflect any API changes. Learn more about updating `openapi.json` [here](./testing.md#openapi-generation).
1212

1313
### Adding Tests
1414

15-
Web APIs in dotnet-monitor are typically tested using functional tests that leverage the [ApiClient](https://github.com/dotnet/dotnet-monitor/blob/0c3a91196f7e0abe8b9fa5cd8907378c4598b10a/src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/HttpApi/ApiClient.cs) to call a specific API. Learn more about how the functional tests are defined and operate [here](./testing.md#functional-tests).
15+
Web APIs in dotnet-monitor are typically tested using functional tests that leverage the [ApiClient](https://github.com/dotnet/dotnet-monitor/blob/e973263b09f539d9e3751799a1c4416d0b9b2749/src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/HttpApi/ApiClient.cs) to call a specific API. Learn more about how the functional tests are defined and operate [here](./testing.md#functional-tests).
1616

1717
## Notable Controller Attributes
1818

@@ -32,6 +32,6 @@ dotnet-monitor supports multiple different [authentication modes](../authenticat
3232

3333
### Determining Authentication Mode
3434

35-
When dotnet-monitor starts, the command line arguments are first inspected to see if a specific authentication mode was set (such as `--no-auth`), referred to as the `StartupAuthenticationMode`, this is calculated [here](https://github.com/dotnet/dotnet-monitor/blob/0c3a91196f7e0abe8b9fa5cd8907378c4598b10a/src/Tools/dotnet-monitor/Commands/CollectCommandHandler.cs#L28). If no modes were explicitly set via a command line argument, dotnet-monitor will select `Deferred` as the `StartupAuthenticationMode`. This indicates that the user configuration should be looked at to determine the authentication mode later on in the startup process.
35+
When dotnet-monitor starts, the command line arguments are first inspected to see if a specific authentication mode was set (such as `--no-auth`), referred to as the `StartupAuthenticationMode`, this is calculated [here](https://github.com/dotnet/dotnet-monitor/blob/e973263b09f539d9e3751799a1c4416d0b9b2749/src/Tools/dotnet-monitor/Commands/CollectCommandHandler.cs#L28). If no modes were explicitly set via a command line argument, dotnet-monitor will select `Deferred` as the `StartupAuthenticationMode`. This indicates that the user configuration should be looked at to determine the authentication mode later on in the startup process.
3636

37-
After determining the `StartupAuthenticationMode` mode, the relevant [IAuthenticationConfigurator](https://github.com/dotnet/dotnet-monitor/blob/0c3a91196f7e0abe8b9fa5cd8907378c4598b10a/src/Tools/dotnet-monitor/Auth/IAuthenticationConfigurator.cs) is created by the [AuthConfiguratorFactory](https://github.com/dotnet/dotnet-monitor/blob/0c3a91196f7e0abe8b9fa5cd8907378c4598b10a/src/Tools/dotnet-monitor/Auth/AuthConfiguratorFactory.cs). This factory also handles deciding what authentication mode to use when `StartupAuthenticationMode` is `Deferred`. The selected configurator is used to configure various parts of dotnet-monitor that are specific to authentication, such as protecting the web APIs and adding authentication-mode specific logging.
37+
After determining the `StartupAuthenticationMode` mode, the relevant [IAuthenticationConfigurator](https://github.com/dotnet/dotnet-monitor/blob/e973263b09f539d9e3751799a1c4416d0b9b2749/src/Tools/dotnet-monitor/Auth/IAuthenticationConfigurator.cs) is created by the [AuthConfiguratorFactory](https://github.com/dotnet/dotnet-monitor/blob/e973263b09f539d9e3751799a1c4416d0b9b2749/src/Tools/dotnet-monitor/Auth/AuthConfiguratorFactory.cs). This factory also handles deciding what authentication mode to use when `StartupAuthenticationMode` is `Deferred`. The selected configurator is used to configure various parts of dotnet-monitor that are specific to authentication, such as protecting the web APIs and adding authentication-mode specific logging.

0 commit comments

Comments
 (0)