Skip to content

Commit 6deccef

Browse files
committed
Add more validatable types, mapping logic
1 parent 668e4c6 commit 6deccef

File tree

6 files changed

+797
-52
lines changed

6 files changed

+797
-52
lines changed

src/Tests/CollectionRuleActions.UnitTests/ActionListExecutorTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public Task ActionListExecutor_SecondActionFail_DeferredCompletion()
8282
return ActionListExecutor_SecondActionFail(waitForCompletion: false);
8383
}
8484

85-
[Fact]
85+
[Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]
8686
public Task ActionListExecutor_SecondActionFail_WaitedCompletion()
8787
{
8888
return ActionListExecutor_SecondActionFail(waitForCompletion: true);

src/Tests/CollectionRuleActions.UnitTests/CollectGCDumpActionTests.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
using Microsoft.Diagnostics.Monitoring.TestCommon.Options;
66
using Microsoft.Diagnostics.Monitoring.TestCommon.Runners;
77
using Microsoft.Diagnostics.Monitoring.WebApi;
8+
using Microsoft.Diagnostics.Tools.Monitor;
89
using Microsoft.Diagnostics.Tools.Monitor.CollectionRules;
910
using Microsoft.Diagnostics.Tools.Monitor.CollectionRules.Actions;
1011
using Microsoft.Diagnostics.Tools.Monitor.CollectionRules.Exceptions;
@@ -104,7 +105,7 @@ await runner.ExecuteAsync(async () =>
104105

105106
await runner.SendCommandAsync(TestAppScenarios.AsyncWait.Commands.Continue);
106107
});
107-
});
108+
}, TestValidatableTypes.AddValidation);
108109
}
109110

110111
private static async Task ValidateGCDump(Stream gcdumpStream)

src/Tests/CollectionRuleActions.UnitTests/CollectLiveMetricsActionTests.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
using Microsoft.Diagnostics.Monitoring.TestCommon.Runners;
88
using Microsoft.Diagnostics.Monitoring.WebApi;
99
using Microsoft.Diagnostics.Monitoring.WebApi.Models;
10+
using Microsoft.Diagnostics.Tools.Monitor;
1011
using Microsoft.Diagnostics.Tools.Monitor.CollectionRules;
1112
using Microsoft.Diagnostics.Tools.Monitor.CollectionRules.Actions;
1213
using Microsoft.Diagnostics.Tools.Monitor.CollectionRules.Options.Actions;
@@ -111,7 +112,7 @@ await LiveMetricsTestUtilities.ValidateMetrics(new[] { providerName },
111112

112113
await runner.SendCommandAsync(TestAppScenarios.AsyncWait.Commands.Continue);
113114
});
114-
});
115+
}, TestValidatableTypes.AddValidation);
115116
}
116117

117118
[Theory(Skip = "Flaky")]

src/Tests/CollectionRuleActions.UnitTests/TestValidatableType.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
using Microsoft.Diagnostics.Tools.Monitor.CollectionRules.Options;
88
using Microsoft.Diagnostics.Tools.Monitor.CollectionRules.Options.Actions;
99
using Microsoft.Diagnostics.Monitoring.WebApi;
10+
using Microsoft.Diagnostics.Tools.Monitor.Egress.FileSystem;
1011

1112
namespace Microsoft.Diagnostics.Tools.Monitor
1213
{
@@ -29,6 +30,14 @@ internal sealed class TestValidatableTypes
2930

3031
public required GlobalCounterOptions GlobalCounterOptions { get; init; }
3132

33+
public required CollectGCDumpOptions CollectGCDumpOptions { get; init; }
34+
35+
public required CollectLiveMetricsOptions CollectLiveMetricsOptions { get; init; }
36+
37+
public required RootOptions RootOptions { get; init; }
38+
39+
public required FileSystemEgressProviderOptions FileSystemEgressProviderOptions { get; init; }
40+
3241
public static void AddValidation(IServiceCollection services)
3342
{
3443
GeneratedServiceCollectionExtensions.AddValidation(services);

0 commit comments

Comments
 (0)