Fix validation behavior for CollectionRuleActionOptions

The generator expects IValidatableObject results to have
a MemberName.

Author: sbomer

src/Tests/CollectionRuleActions.UnitTests/ActionListExecutorTests.cs

@@ -76,7 +76,7 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
             });
         }
 
-        [Fact]
+        [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]
         public Task ActionListExecutor_SecondActionFail_DeferredCompletion()
         {
             return ActionListExecutor_SecondActionFail(waitForCompletion: false);
@@ -165,9 +165,9 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
                 Assert.Equal(string.Format(Strings.ErrorMessage_NonzeroExitCode, "1"), actionExecutionException.Message);
 
                 VerifyStartCallbackCount(waitForCompletion, callbackCount);
-            }, services =>
+            }, serviceCollection =>
             {
-                services.AddValidation();
+                AddValidation(serviceCollection);
             });
         }
 
@@ -190,9 +190,15 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
             }, serviceCollection =>
             {
                 serviceCollection.RegisterCollectionRuleAction<PassThroughActionFactory, PassThroughOptions>(nameof(PassThroughAction));
+                AddValidation(serviceCollection);
             });
         }
 
+        static void AddValidation(IServiceCollection serviceCollection)
+        {
+            serviceCollection.AddValidation();
+        }
+
         private static void VerifyStartCallbackCount(bool waitForCompletion, int callbackCount)
         {
             //Currently, any attempt to wait on completion will automatically trigger the start callback.

src/Tests/CollectionRuleActions.UnitTests/CollectionRuleActions.UnitTests.csproj

@@ -1,4 +1,6 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project>
+
+  <Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk.Web" />
 
   <PropertyGroup>
     <TargetFrameworks>$(ToolTargetFrameworks)</TargetFrameworks>
@@ -16,4 +18,20 @@
     <ProjectReference Include="..\Microsoft.Diagnostics.Monitoring.Tool.UnitTestCommon\Microsoft.Diagnostics.Monitoring.Tool.UnitTestCommon.csproj" />
   </ItemGroup>
 
+  <ItemGroup>
+    <KnownFrameworkReference
+      Update="Microsoft.NETCore.App"
+      TargetingPackVersion="$(NetCoreAppVersion)"
+      DefaultRuntimeFrameworkVersion="$(NetCoreAppVersion)"
+      LatestRuntimeFrameworkVersion="$(NetCoreAppVersion)" />
+
+    <KnownFrameworkReference
+      Update="Microsoft.AspNetCore.App"
+      TargetingPackVersion="$(AspNetCoreAppVersion)"
+      DefaultRuntimeFrameworkVersion="$(AspNetCoreAppVersion)"
+      LatestRuntimeFrameworkVersion="$(AspNetCoreAppVersion)" />
+  </ItemGroup>
+
+  <Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk.Web" />
+
 </Project>

src/Tools/dotnet-monitor/CollectionRules/Options/CollectionRuleActionOptions.Validate.cs

@@ -18,6 +18,10 @@ IEnumerable<ValidationResult> IValidatableObject.Validate(ValidationContext vali
 
             if (!string.IsNullOrEmpty(Type))
             {
+                validationContext = new ValidationContext(this, displayName: Type, validationContext, items: null)
+                {
+                    MemberName = nameof(Settings)
+                };
                 actionOperations.TryValidateOptions(Type, Settings, validationContext, results);
             }