Skip to content

Commit 8a72753

Browse files
committed
Fix short-circuit test
1 parent ef7b701 commit 8a72753

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/CollectionRuleOptionsTests.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -195,10 +195,7 @@ public Task CollectionRuleOptions_EventCounterTrigger_PropertyValidation()
195195
ex =>
196196
{
197197
string[] failures = ex.Failures.ToArray();
198-
// Property validation failures will short-circuit the remainder of the validation
199-
// rules, thus only observe 3 errors when one might expect 4 (the fourth being that
200-
// either GreaterThan or LessThan should be specified).
201-
Assert.Equal(3, failures.Length);
198+
Assert.Equal(4, failures.Length);
202199
VerifyRequiredMessage(failures, 0, nameof(EventCounterOptions.ProviderName));
203200
VerifyRequiredMessage(failures, 1, nameof(EventCounterOptions.CounterName));
204201
VerifyRangeMessage<TimeSpan>(failures, 2, nameof(EventCounterOptions.SlidingWindowDuration),

0 commit comments

Comments
 (0)