Clean up skipped tests, remove per-test AddValidation

sbomer · sbomer · commit affc0984ee03 · 2025-04-28T20:00:45.000Z
diff --git a/src/Tests/CollectionRuleActions.UnitTests/ActionListExecutorTests.cs b/src/Tests/CollectionRuleActions.UnitTests/ActionListExecutorTests.cs
@@ -46,7 +46,7 @@ public ActionListExecutorTests(ITestOutputHelper outputHelper)
             _outputHelper = outputHelper;
         }
 
-        [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]
+        [Fact]
         public async Task ActionListExecutor_AllActionsSucceed()
         {
             await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
@@ -73,16 +73,16 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
                 await executor.ExecuteActions(context, startCallback, cancellationTokenSource.Token);
 
                 VerifyStartCallbackCount(waitForCompletion: false, callbackCount);
-            }, TestValidatableTypes.AddValidation);
+            });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]
+        [Fact]
         public Task ActionListExecutor_SecondActionFail_DeferredCompletion()
         {
             return ActionListExecutor_SecondActionFail(waitForCompletion: false);
         }
 
-        [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]
+        [Fact]
         public Task ActionListExecutor_SecondActionFail_WaitedCompletion()
         {
             return ActionListExecutor_SecondActionFail(waitForCompletion: true);
@@ -119,7 +119,7 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
                 Assert.Equal(string.Format(Strings.ErrorMessage_NonzeroExitCode, "1"), actionExecutionException.Message);
 
                 VerifyStartCallbackCount(waitForCompletion, callbackCount);
-            }, TestValidatableTypes.AddValidation);
+            });
         }
 
         [Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/61379")]
@@ -165,7 +165,7 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
                 Assert.Equal(string.Format(Strings.ErrorMessage_NonzeroExitCode, "1"), actionExecutionException.Message);
 
                 VerifyStartCallbackCount(waitForCompletion, callbackCount);
-            }, TestValidatableTypes.AddValidation);
+            });
         }
 
 
@@ -187,7 +187,6 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
             }, serviceCollection =>
             {
                 serviceCollection.RegisterCollectionRuleAction<PassThroughActionFactory, PassThroughOptions, PassThroughActionDescriptor>();
-                TestValidatableTypes.AddValidation(serviceCollection);
             });
         }
         private static void VerifyStartCallbackCount(bool waitForCompletion, int callbackCount)
diff --git a/src/Tests/CollectionRuleActions.UnitTests/CollectDumpActionTests.cs b/src/Tests/CollectionRuleActions.UnitTests/CollectDumpActionTests.cs
@@ -101,7 +101,7 @@ await runner.ExecuteAsync(async () =>
 
                     await runner.SendCommandAsync(TestAppScenarios.AsyncWait.Commands.Continue);
                 });
-            }, TestValidatableTypes.AddValidation);
+            });
         }
     }
 }
diff --git a/src/Tests/CollectionRuleActions.UnitTests/CollectGCDumpActionTests.cs b/src/Tests/CollectionRuleActions.UnitTests/CollectGCDumpActionTests.cs
@@ -104,7 +104,7 @@ await runner.ExecuteAsync(async () =>
 
                     await runner.SendCommandAsync(TestAppScenarios.AsyncWait.Commands.Continue);
                 });
-            }, TestValidatableTypes.AddValidation);
+            });
         }
 
         private static async Task ValidateGCDump(Stream gcdumpStream)
diff --git a/src/Tests/CollectionRuleActions.UnitTests/CollectLiveMetricsActionTests.cs b/src/Tests/CollectionRuleActions.UnitTests/CollectLiveMetricsActionTests.cs
@@ -111,7 +111,7 @@ await LiveMetricsTestUtilities.ValidateMetrics(new[] { providerName },
 
                     await runner.SendCommandAsync(TestAppScenarios.AsyncWait.Commands.Continue);
                 });
-            }, TestValidatableTypes.AddValidation);
+            });
         }
 
         [Theory(Skip = "Flaky")]
diff --git a/src/Tests/CollectionRuleActions.UnitTests/CollectTraceActionTests.cs b/src/Tests/CollectionRuleActions.UnitTests/CollectTraceActionTests.cs
@@ -55,7 +55,7 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
             }, async host =>
             {
                 await PerformTrace(host, tfm);
-            }, TestValidatableTypes.AddValidation);
+            });
         }
 
         [Theory]
@@ -79,8 +79,7 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
                         options.Duration = TimeSpan.FromSeconds(2);
                     })
                     .SetStartupTrigger();
-            }, host => PerformTrace(host, tfm),
-            TestValidatableTypes.AddValidation);
+            }, host => PerformTrace(host, tfm));
         }
 
         [Fact]
@@ -100,8 +99,7 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
                         options.Duration = TimeSpan.FromSeconds(2);
                     })
                     .SetStartupTrigger();
-            }, host => PerformTrace(host, TargetFrameworkMoniker.Current, artifactName),
-            TestValidatableTypes.AddValidation);
+            }, host => PerformTrace(host, TargetFrameworkMoniker.Current, artifactName));
         }
 
         private async Task PerformTrace(IHost host, TargetFrameworkMoniker tfm, string artifactName = null)
diff --git a/src/Tests/CollectionRuleActions.UnitTests/EnvironmentVariableActionTests.cs b/src/Tests/CollectionRuleActions.UnitTests/EnvironmentVariableActionTests.cs
@@ -41,7 +41,7 @@ public EnvironmentVariableActionTests(ITestOutputHelper outputHelper)
         /// <remarks>
         /// The required APIs only exist on .NET 6.0+
         /// </remarks>
-        [Theory(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]
+        [Theory]
         [MemberData(nameof(ActionTestsHelper.GetTfms), MemberType = typeof(ActionTestsHelper))]
         public async Task TestSetEnvVar(TargetFrameworkMoniker tfm)
         {
@@ -79,7 +79,7 @@ await runner.ExecuteAsync(async () =>
 
                         await runner.SendCommandAsync(TestAppScenarios.EnvironmentVariables.Commands.ShutdownScenario);
                     });
-                }, TestValidatableTypes.AddValidation);
+                });
         }
 
         /// <summary>
@@ -88,7 +88,7 @@ await runner.ExecuteAsync(async () =>
         /// <remarks>
         /// The required APIs only exist on .NET 6.0+
         /// </remarks>
-        [Theory(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]
+        [Theory]
         [MemberData(nameof(ActionTestsHelper.GetTfms), MemberType = typeof(ActionTestsHelper))]
         public async Task TestGetEnvVar(TargetFrameworkMoniker tfm)
         {
@@ -145,7 +145,7 @@ await runner.ExecuteAsync(async () =>
 
                         await runner.SendCommandAsync(TestAppScenarios.EnvironmentVariables.Commands.ShutdownScenario);
                     });
-                }, TestValidatableTypes.AddValidation);
+                });
         }
 
         /// <summary>
@@ -155,7 +155,7 @@ await runner.ExecuteAsync(async () =>
         /// <remarks>
         /// The required APIs only exist on .NET 6.0+
         /// </remarks>
-        [Theory(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]
+        [Theory]
         [MemberData(nameof(ActionTestsHelper.GetTfms), MemberType = typeof(ActionTestsHelper))]
         public async Task TestEnvVarRoundTrip(TargetFrameworkMoniker tfm)
         {
@@ -199,7 +199,7 @@ await runner.ExecuteAsync(async () =>
                             Assert.True(getResult.OutputValues.TryGetValue(CollectionRuleActionConstants.EnvironmentVariableValueName, out string value));
                             Assert.Equal(DefaultVarValue, value);
                         });
-                }, TestValidatableTypes.AddValidation);
+                });
         }
     }
 }
diff --git a/src/Tests/CollectionRuleActions.UnitTests/ExecuteActionTests.cs b/src/Tests/CollectionRuleActions.UnitTests/ExecuteActionTests.cs
@@ -41,7 +41,7 @@ public ExecuteActionTests(ITestOutputHelper outputHelper, ExecuteActionFixture f
             _fixture = fixture;
         }
 
-        [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]
+        [Fact]
         public async Task ExecuteAction_ZeroExitCode()
         {
             await ValidateAction(
@@ -60,7 +60,7 @@ await ValidateAction(
                 });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]
+        [Fact]
         public async Task ExecuteAction_NonzeroExitCode()
         {
             await ValidateAction(
@@ -80,7 +80,7 @@ await ValidateAction(
                 });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]
+        [Fact]
         public async Task ExecuteAction_TokenCancellation()
         {
             // This timeout is much shorter than the default test timeout.
@@ -107,7 +107,7 @@ await Assert.ThrowsAsync<TaskCanceledException>(
                 });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]
+        [Fact]
         public async Task ExecuteAction_TextFileOutput()
         {
             using TemporaryDirectory outputDirectory = new(_outputHelper);
@@ -134,7 +134,7 @@ await ValidateAction(
             Assert.Equal(testMessage, File.ReadAllText(textFileOutputPath));
         }
 
-        [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]
+        [Fact]
         public async Task ExecuteAction_InvalidPath()
         {
             string uniquePathName = Guid.NewGuid().ToString();
@@ -154,7 +154,7 @@ await ValidateAction(
                 });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]
+        [Fact]
         public async Task ExecuteAction_IgnoreExitCode()
         {
             await ValidateAction(
diff --git a/src/Tests/CollectionRuleActions.UnitTests/LoadProfilerActionTests.cs b/src/Tests/CollectionRuleActions.UnitTests/LoadProfilerActionTests.cs
@@ -73,7 +73,7 @@ await runner.ExecuteAsync(async () =>
 
                     await runner.SendCommandAsync(TestAppScenarios.AsyncWait.Commands.Continue);
                 });
-            }, TestValidatableTypes.AddValidation);
+            });
         }
 
         /// <summary>
diff --git a/src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/ActionDependencyAnalyzerTests.cs b/src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/ActionDependencyAnalyzerTests.cs
@@ -136,7 +136,6 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
             }, serviceCollection =>
             {
                 serviceCollection.RegisterCollectionRuleAction<PassThroughActionFactory, PassThroughOptions, PassThroughActionDescriptor>();
-                TestValidatableTypes.AddValidation(serviceCollection);
             });
         }
 
@@ -177,7 +176,6 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
             }, serviceCollection =>
             {
                 serviceCollection.RegisterCollectionRuleAction<PassThroughActionFactory, PassThroughOptions, PassThroughActionDescriptor>();
-                TestValidatableTypes.AddValidation(serviceCollection);
             });
         }
 
@@ -216,7 +214,6 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
             {
                 serviceCollection.AddSingleton<TimeProvider, MockTimeProvider>();
                 serviceCollection.RegisterCollectionRuleAction<PassThroughActionFactory, PassThroughOptions, PassThroughActionDescriptor>();
-                TestValidatableTypes.AddValidation(serviceCollection);
             });
         }
 
@@ -261,7 +258,6 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
             }, serviceCollection =>
             {
                 serviceCollection.RegisterCollectionRuleAction<PassThroughActionFactory, PassThroughOptions, PassThroughActionDescriptor>();
-                TestValidatableTypes.AddValidation(serviceCollection);
             }, loggingBuilder =>
             {
                 loggingBuilder.AddProvider(new TestLoggerProvider(record));
@@ -299,7 +295,6 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
             }, serviceCollection =>
             {
                 serviceCollection.RegisterCollectionRuleAction<PassThroughActionFactory, PassThroughOptions, PassThroughActionDescriptor>();
-                TestValidatableTypes.AddValidation(serviceCollection);
             });
         }
 
@@ -362,7 +357,6 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
             }, serviceCollection =>
             {
                 serviceCollection.RegisterCollectionRuleAction<PassThroughActionFactory, PassThroughOptions, PassThroughActionDescriptor>();
-                TestValidatableTypes.AddValidation(serviceCollection);
             });
         }
     }
diff --git a/src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/CollectionRuleDefaultsTests.cs b/src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/CollectionRuleDefaultsTests.cs
@@ -73,7 +73,7 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>
                         () => ActionTestsHelper.GetActionOptions<OptionsValidationException>(host, DefaultRuleName));
 
                 Assert.Equal(string.Format(OptionsDisplayStrings.ErrorMessage_NoDefaultEgressProvider), invalidOptionsException.Message);
-            }, TestValidatableTypes.AddValidation);
+            });
         }
 
         [Fact]
diff --git a/src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/CollectionRuleDescriptionPipelineTests.cs b/src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/CollectionRuleDescriptionPipelineTests.cs
@@ -91,7 +91,6 @@ public Task CollectionRuleDescriptionPipeline_StartupTriggerTest(TargetFramework
                 services =>
                 {
                     services.RegisterTestAction(callbackService);
-                    TestValidatableTypes.AddValidation(services);
                 });
         }
 
@@ -292,7 +291,6 @@ await CollectionRulePipelineTestsHelper.ManualTriggerAsync(
                     services.AddSingleton<TimeProvider>(timeProvider);
                     services.RegisterManualTrigger(triggerService);
                     services.RegisterTestAction(callbackService);
-                    TestValidatableTypes.AddValidation(services);
                 });
         }
 
@@ -340,7 +338,6 @@ public Task CollectionRuleDescriptionPipeline_ReachedRuleDuration(TargetFramewor
                 {
                     services.RegisterManualTrigger(triggerService);
                     services.RegisterTestAction(callbackService);
-                    TestValidatableTypes.AddValidation(services);
                 });
         }
 
@@ -409,7 +406,6 @@ await CollectionRulePipelineTestsHelper.ManualTriggerAsync(
                     services.AddSingleton<TimeProvider>(timeProvider);
                     services.RegisterManualTrigger(triggerService);
                     services.RegisterTestAction(callbackService);
-                    TestValidatableTypes.AddValidation(services);
                 });
         }
 
diff --git a/src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/CollectionRulePipelineTests.cs b/src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/CollectionRulePipelineTests.cs
@@ -94,7 +94,6 @@ public Task CollectionRulePipeline_StartupTriggerTest(TargetFrameworkMoniker app
                 services =>
                 {
                     services.RegisterTestAction(callbackService);
-                    TestValidatableTypes.AddValidation(services);
                 });
         }
 
@@ -224,7 +223,6 @@ public Task CollectionRulePipeline_EventMeterTriggerTest_Gauge(TargetFrameworkMo
                 services =>
                 {
                     services.RegisterTestAction(callbackService);
-                    TestValidatableTypes.AddValidation(services);
                 });
         }
 
@@ -400,7 +398,6 @@ public Task CollectionRulePipeline_DurationLimitTest(TargetFrameworkMoniker appT
                 {
                     services.RegisterManualTrigger(triggerService);
                     services.RegisterTestAction(callbackService);
-                    TestValidatableTypes.AddValidation(services);
                 });
         }
 
@@ -464,7 +461,6 @@ await CollectionRulePipelineTestsHelper.ManualTriggerAsync(
                     services.AddSingleton<TimeProvider>(timeProvider);
                     services.RegisterManualTrigger(triggerService);
                     services.RegisterTestAction(callbackService);
-                    TestValidatableTypes.AddValidation(services);
                 });
         }
 

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ public ActionListExecutorTests(ITestOutputHelper outputHelper)`
`46`	`46`	`_outputHelper = outputHelper;`
`47`	`47`	`}`
`48`	`48`
`49`		`- [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]`
	`49`	`+ [Fact]`
`50`	`50`	`public async Task ActionListExecutor_AllActionsSucceed()`
`51`	`51`	`{`
`52`	`52`	`await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>`
`@@ -73,16 +73,16 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>`
`73`	`73`	`await executor.ExecuteActions(context, startCallback, cancellationTokenSource.Token);`
`74`	`74`
`75`	`75`	`VerifyStartCallbackCount(waitForCompletion: false, callbackCount);`
`76`		`- }, TestValidatableTypes.AddValidation);`
	`76`	`+ });`
`77`	`77`	`}`
`78`	`78`
`79`		`- [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]`
	`79`	`+ [Fact]`
`80`	`80`	`public Task ActionListExecutor_SecondActionFail_DeferredCompletion()`
`81`	`81`	`{`
`82`	`82`	`return ActionListExecutor_SecondActionFail(waitForCompletion: false);`
`83`	`83`	`}`
`84`	`84`
`85`		`- [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]`
	`85`	`+ [Fact]`
`86`	`86`	`public Task ActionListExecutor_SecondActionFail_WaitedCompletion()`
`87`	`87`	`{`
`88`	`88`	`return ActionListExecutor_SecondActionFail(waitForCompletion: true);`
`@@ -119,7 +119,7 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>`
`119`	`119`	`Assert.Equal(string.Format(Strings.ErrorMessage_NonzeroExitCode, "1"), actionExecutionException.Message);`
`120`	`120`
`121`	`121`	`VerifyStartCallbackCount(waitForCompletion, callbackCount);`
`122`		`- }, TestValidatableTypes.AddValidation);`
	`122`	`+ });`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`[Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/61379")]`
`@@ -165,7 +165,7 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>`
`165`	`165`	`Assert.Equal(string.Format(Strings.ErrorMessage_NonzeroExitCode, "1"), actionExecutionException.Message);`
`166`	`166`
`167`	`167`	`VerifyStartCallbackCount(waitForCompletion, callbackCount);`
`168`		`- }, TestValidatableTypes.AddValidation);`
	`168`	`+ });`
`169`	`169`	`}`
`170`	`170`
`171`	`171`
`@@ -187,7 +187,6 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>`
`187`	`187`	`}, serviceCollection =>`
`188`	`188`	`{`
`189`	`189`	`serviceCollection.RegisterCollectionRuleAction<PassThroughActionFactory, PassThroughOptions, PassThroughActionDescriptor>();`
`190`		`- TestValidatableTypes.AddValidation(serviceCollection);`
`191`	`190`	`});`
`192`	`191`	`}`
`193`	`192`	`private static void VerifyStartCallbackCount(bool waitForCompletion, int callbackCount)`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ await runner.ExecuteAsync(async () =>`
`101`	`101`
`102`	`102`	`await runner.SendCommandAsync(TestAppScenarios.AsyncWait.Commands.Continue);`
`103`	`103`	`});`
`104`		`- }, TestValidatableTypes.AddValidation);`
	`104`	`+ });`
`105`	`105`	`}`
`106`	`106`	`}`
`107`	`107`	`}`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ await runner.ExecuteAsync(async () =>`
`104`	`104`
`105`	`105`	`await runner.SendCommandAsync(TestAppScenarios.AsyncWait.Commands.Continue);`
`106`	`106`	`});`
`107`		`- }, TestValidatableTypes.AddValidation);`
	`107`	`+ });`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`private static async Task ValidateGCDump(Stream gcdumpStream)`
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ await LiveMetricsTestUtilities.ValidateMetrics(new[] { providerName },`
`111`	`111`
`112`	`112`	`await runner.SendCommandAsync(TestAppScenarios.AsyncWait.Commands.Continue);`
`113`	`113`	`});`
`114`		`- }, TestValidatableTypes.AddValidation);`
	`114`	`+ });`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`[Theory(Skip = "Flaky")]`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>`
`55`	`55`	`}, async host =>`
`56`	`56`	`{`
`57`	`57`	`await PerformTrace(host, tfm);`
`58`		`- }, TestValidatableTypes.AddValidation);`
	`58`	`+ });`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`[Theory]`
`@@ -79,8 +79,7 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>`
`79`	`79`	`options.Duration = TimeSpan.FromSeconds(2);`
`80`	`80`	`})`
`81`	`81`	`.SetStartupTrigger();`
`82`		`- }, host => PerformTrace(host, tfm),`
`83`		`- TestValidatableTypes.AddValidation);`
	`82`	`+ }, host => PerformTrace(host, tfm));`
`84`	`83`	`}`
`85`	`84`
`86`	`85`	`[Fact]`
`@@ -100,8 +99,7 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>`
`100`	`99`	`options.Duration = TimeSpan.FromSeconds(2);`
`101`	`100`	`})`
`102`	`101`	`.SetStartupTrigger();`
`103`		`- }, host => PerformTrace(host, TargetFrameworkMoniker.Current, artifactName),`
`104`		`- TestValidatableTypes.AddValidation);`
	`102`	`+ }, host => PerformTrace(host, TargetFrameworkMoniker.Current, artifactName));`
`105`	`103`	`}`
`106`	`104`
`107`	`105`	`private async Task PerformTrace(IHost host, TargetFrameworkMoniker tfm, string artifactName = null)`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public ExecuteActionTests(ITestOutputHelper outputHelper, ExecuteActionFixture f`
`41`	`41`	`_fixture = fixture;`
`42`	`42`	`}`
`43`	`43`
`44`		`- [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]`
	`44`	`+ [Fact]`
`45`	`45`	`public async Task ExecuteAction_ZeroExitCode()`
`46`	`46`	`{`
`47`	`47`	`await ValidateAction(`
`@@ -60,7 +60,7 @@ await ValidateAction(`
`60`	`60`	`});`
`61`	`61`	`}`
`62`	`62`
`63`		`- [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]`
	`63`	`+ [Fact]`
`64`	`64`	`public async Task ExecuteAction_NonzeroExitCode()`
`65`	`65`	`{`
`66`	`66`	`await ValidateAction(`
`@@ -80,7 +80,7 @@ await ValidateAction(`
`80`	`80`	`});`
`81`	`81`	`}`
`82`	`82`
`83`		`- [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]`
	`83`	`+ [Fact]`
`84`	`84`	`public async Task ExecuteAction_TokenCancellation()`
`85`	`85`	`{`
`86`	`86`	`// This timeout is much shorter than the default test timeout.`
`@@ -107,7 +107,7 @@ await Assert.ThrowsAsync<TaskCanceledException>(`
`107`	`107`	`});`
`108`	`108`	`}`
`109`	`109`
`110`		`- [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]`
	`110`	`+ [Fact]`
`111`	`111`	`public async Task ExecuteAction_TextFileOutput()`
`112`	`112`	`{`
`113`	`113`	`using TemporaryDirectory outputDirectory = new(_outputHelper);`
`@@ -134,7 +134,7 @@ await ValidateAction(`
`134`	`134`	`Assert.Equal(testMessage, File.ReadAllText(textFileOutputPath));`
`135`	`135`	`}`
`136`	`136`
`137`		`- [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]`
	`137`	`+ [Fact]`
`138`	`138`	`public async Task ExecuteAction_InvalidPath()`
`139`	`139`	`{`
`140`	`140`	`string uniquePathName = Guid.NewGuid().ToString();`
`@@ -154,7 +154,7 @@ await ValidateAction(`
`154`	`154`	`});`
`155`	`155`	`}`
`156`	`156`
`157`		`- [Fact(Skip = "https://github.com/dotnet/aspnetcore/pull/61402")]`
	`157`	`+ [Fact]`
`158`	`158`	`public async Task ExecuteAction_IgnoreExitCode()`
`159`	`159`	`{`
`160`	`160`	`await ValidateAction(`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ await runner.ExecuteAsync(async () =>`
`73`	`73`
`74`	`74`	`await runner.SendCommandAsync(TestAppScenarios.AsyncWait.Commands.Continue);`
`75`	`75`	`});`
`76`		`- }, TestValidatableTypes.AddValidation);`
	`76`	`+ });`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,6 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>`
`136`	`136`	`}, serviceCollection =>`
`137`	`137`	`{`
`138`	`138`	`serviceCollection.RegisterCollectionRuleAction<PassThroughActionFactory, PassThroughOptions, PassThroughActionDescriptor>();`
`139`		`- TestValidatableTypes.AddValidation(serviceCollection);`
`140`	`139`	`});`
`141`	`140`	`}`
`142`	`141`
`@@ -177,7 +176,6 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>`
`177`	`176`	`}, serviceCollection =>`
`178`	`177`	`{`
`179`	`178`	`serviceCollection.RegisterCollectionRuleAction<PassThroughActionFactory, PassThroughOptions, PassThroughActionDescriptor>();`
`180`		`- TestValidatableTypes.AddValidation(serviceCollection);`
`181`	`179`	`});`
`182`	`180`	`}`
`183`	`181`
`@@ -216,7 +214,6 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>`
`216`	`214`	`{`
`217`	`215`	`serviceCollection.AddSingleton<TimeProvider, MockTimeProvider>();`
`218`	`216`	`serviceCollection.RegisterCollectionRuleAction<PassThroughActionFactory, PassThroughOptions, PassThroughActionDescriptor>();`
`219`		`- TestValidatableTypes.AddValidation(serviceCollection);`
`220`	`217`	`});`
`221`	`218`	`}`
`222`	`219`
`@@ -261,7 +258,6 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>`
`261`	`258`	`}, serviceCollection =>`
`262`	`259`	`{`
`263`	`260`	`serviceCollection.RegisterCollectionRuleAction<PassThroughActionFactory, PassThroughOptions, PassThroughActionDescriptor>();`
`264`		`- TestValidatableTypes.AddValidation(serviceCollection);`
`265`	`261`	`}, loggingBuilder =>`
`266`	`262`	`{`
`267`	`263`	`loggingBuilder.AddProvider(new TestLoggerProvider(record));`
`@@ -299,7 +295,6 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>`
`299`	`295`	`}, serviceCollection =>`
`300`	`296`	`{`
`301`	`297`	`serviceCollection.RegisterCollectionRuleAction<PassThroughActionFactory, PassThroughOptions, PassThroughActionDescriptor>();`
`302`		`- TestValidatableTypes.AddValidation(serviceCollection);`
`303`	`298`	`});`
`304`	`299`	`}`
`305`	`300`
`@@ -362,7 +357,6 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>`
`362`	`357`	`}, serviceCollection =>`
`363`	`358`	`{`
`364`	`359`	`serviceCollection.RegisterCollectionRuleAction<PassThroughActionFactory, PassThroughOptions, PassThroughActionDescriptor>();`
`365`		`- TestValidatableTypes.AddValidation(serviceCollection);`
`366`	`360`	`});`
`367`	`361`	`}`
`368`	`362`	`}`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ await TestHostHelper.CreateCollectionRulesHost(_outputHelper, rootOptions =>`
`73`	`73`	`() => ActionTestsHelper.GetActionOptions<OptionsValidationException>(host, DefaultRuleName));`
`74`	`74`
`75`	`75`	`Assert.Equal(string.Format(OptionsDisplayStrings.ErrorMessage_NoDefaultEgressProvider), invalidOptionsException.Message);`
`76`		`- }, TestValidatableTypes.AddValidation);`
	`76`	`+ });`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`[Fact]`