Fix trim warnings

Author: sbomer

src/Tools/dotnet-monitor/CollectionRules/Options/Actions/CollectLogsOptions.Validate.cs

@@ -23,7 +23,7 @@ IEnumerable<ValidationResult> IValidatableObject.Validate(ValidationContext vali
                 RequiredAttribute requiredAttribute = new();
                 EnumDataTypeAttribute enumValidationAttribute = new(typeof(LogLevel));
 
-                ValidationContext filterSpecsContext = new(FilterSpecs, validationContext, validationContext.Items);
+                ValidationContext filterSpecsContext = new(FilterSpecs, nameof(FilterSpecs), validationContext, validationContext.Items);
                 filterSpecsContext.MemberName = nameof(FilterSpecs);
 
                 // Validate that the category is not null and that the level is a valid level value.

src/Tools/dotnet-monitor/CollectionRules/Options/Actions/CollectTraceOptions.Validate.cs

@@ -88,7 +88,7 @@ IEnumerable<ValidationResult> IValidatableObject.Validate(ValidationContext vali
                 int index = 0;
                 foreach (EventPipeProvider provider in Providers)
                 {
-                    ValidationContext providerContext = new(provider, validationContext, validationContext.Items);
+                    ValidationContext providerContext = new(provider, nameof(Providers), validationContext, validationContext.Items);
                     providerContext.MemberName = nameof(Providers) + "[" + index.ToString(CultureInfo.InvariantCulture) + "]";
 
                     // Note: generated validation logic doesn't recurse into members of T for List<T>, when List<T> is not required.

src/Tools/dotnet-monitor/ConfigurationTokenParser.cs

@@ -64,7 +64,7 @@ public ConfigurationTokenParser(ILogger logger)
             _logger = logger;
         }
 
-        public object? SubstituteOptionValues(object? originalSettings, Type settingsType, TokenContext context)
+        public object? SubstituteOptionValues(object? originalSettings, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] Type settingsType, TokenContext context)
         {
             object? settings = originalSettings;
 

src/Tools/dotnet-monitor/CustomValidationInfo.cs

@@ -193,6 +193,7 @@ public CustomValidatablePropertyInfo(
                 Name = name;
             }
 
+            [global::System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembers(global::System.Diagnostics.CodeAnalysis.DynamicallyAccessedMemberTypes.PublicProperties | global::System.Diagnostics.CodeAnalysis.DynamicallyAccessedMemberTypes.PublicConstructors)]
             internal Type ContainingType { get; }
             internal string Name { get; }
 
@@ -202,10 +203,14 @@ protected override ValidationAttribute[] GetValidationAttributes()
 
         static class ValidationAttributeCache
         {
-            private sealed record CacheKey(Type ContainingType, string PropertyName);
+            private sealed record CacheKey(
+                [property: global::System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembers(global::System.Diagnostics.CodeAnalysis.DynamicallyAccessedMemberTypes.PublicProperties | global::System.Diagnostics.CodeAnalysis.DynamicallyAccessedMemberTypes.PublicConstructors)]
+                Type ContainingType,
+                string PropertyName);
             private static readonly ConcurrentDictionary<CacheKey, ValidationAttribute[]> _cache = new();
 
             public static ValidationAttribute[] GetValidationAttributes(
+                [param: global::System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembers(global::System.Diagnostics.CodeAnalysis.DynamicallyAccessedMemberTypes.PublicProperties | global::System.Diagnostics.CodeAnalysis.DynamicallyAccessedMemberTypes.PublicConstructors)]
                 Type containingType,
                 string propertyName)
             {
@@ -216,7 +221,7 @@ public static ValidationAttribute[] GetValidationAttributes(
 
                 // Get attributes from the property
                     var property = k.ContainingType.GetProperty(k.PropertyName);
-                if (property != null)
+                    if (property != null)
                     {
                     var propertyAttributes = CustomAttributeExtensions.GetCustomAttributes<ValidationAttribute>(property, inherit: true);
 

src/Tools/dotnet-monitor/ServiceCollectionExtensions.cs

@@ -197,7 +197,7 @@ public static IServiceCollection ConfigureCollectionRules(this IServiceCollectio
             return services;
         }
 
-        public static IServiceCollection RegisterCollectionRuleAction<TFactory, TOptions, TDescriptor>(this IServiceCollection services)
+        public static IServiceCollection RegisterCollectionRuleAction<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] TFactory, TOptions, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] TDescriptor>(this IServiceCollection services)
             where TFactory : class, ICollectionRuleActionFactory<TOptions>
             where TOptions : BaseRecordOptions, new()
             where TDescriptor : class, ICollectionRuleActionDescriptor
@@ -211,7 +211,7 @@ public static IServiceCollection RegisterCollectionRuleAction<TFactory, TOptions
             return services;
         }
 
-        public static IServiceCollection RegisterCollectionRuleTrigger<TFactory, TDescriptor>(this IServiceCollection services)
+        public static IServiceCollection RegisterCollectionRuleTrigger<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] TFactory, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] TDescriptor>(this IServiceCollection services)
             where TFactory : class, ICollectionRuleTriggerFactory
             where TDescriptor : class, ICollectionRuleTriggerDescriptor
         {
@@ -221,7 +221,7 @@ public static IServiceCollection RegisterCollectionRuleTrigger<TFactory, TDescri
             return services;
         }
 
-        public static IServiceCollection RegisterCollectionRuleTrigger<TFactory, TOptions, TDescriptor>(this IServiceCollection services)
+        public static IServiceCollection RegisterCollectionRuleTrigger<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] TFactory, TOptions, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] TDescriptor>(this IServiceCollection services)
             where TFactory : class, ICollectionRuleTriggerFactory<TOptions>
             where TOptions : class, new()
             where TDescriptor : class, ICollectionRuleTriggerDescriptor

src/Tools/dotnet-monitor/ValidatableInfoResolver.cs

@@ -1563,7 +1563,9 @@ internal static class GeneratedServiceCollectionExtensions
     [global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.AspNetCore.Http.ValidationsGenerator, Version=10.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60", "10.0.0.0")]
     file static class ValidationAttributeCache
     {
-        private sealed record CacheKey([property: global::System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembers(global::System.Diagnostics.CodeAnalysis.DynamicallyAccessedMemberTypes.PublicProperties)] global::System.Type ContainingType, string PropertyName);
+        private sealed record CacheKey(
+            [property: global::System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembers(global::System.Diagnostics.CodeAnalysis.DynamicallyAccessedMemberTypes.PublicProperties| global::System.Diagnostics.CodeAnalysis.DynamicallyAccessedMemberTypes.PublicConstructors)]
+            global::System.Type ContainingType, string PropertyName);
         private static readonly global::System.Collections.Concurrent.ConcurrentDictionary<CacheKey, global::System.ComponentModel.DataAnnotations.ValidationAttribute[]> _cache = new();
 
         public static global::System.ComponentModel.DataAnnotations.ValidationAttribute[] GetValidationAttributes(