[feature/10.0][WIP] Use options validation source generator #8254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use generated validators for recursive validation - Pass along service provider through validation context
sbomer
commented
Jun 2, 2025
| ValidationContext itemContext = new(item, validationContext, validationContext.Items); | ||
| itemContext.MemberName = validationContext.MemberName + "[" + index.ToString() + "]"; | ||
|
|
||
| Validator.TryValidateObject(item, itemContext, results); |
There was a problem hiding this comment.
This was the call we need to remove
wiktork
changed the title
Because they rely on .NET10+ ValidationContext ctor
This was referenced Jul 24, 2025
|
The 'no-recent-activity' label has been added to this pull request due to four weeks without any activity. If there is no activity in the next six weeks, this pull request will automatically be closed. You can learn more about our stale PR policy here: https://github.com/dotnet/dotnet-monitor/blob/main/CONTRIBUTING.md#stale-pr-policy |
dotnet-policy-service
bot
added
the
no-recent-activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now this checks in the generated code with fixes for dotnet/runtime#115347.