fix: fixed Finalizer-Registration (#874)

@buehler I'm terribly sorry, but I made a mistake during the
implementation of the finalizer registration. The metadata referenced a
wrong not existing interface, and I had forgotten a code fragment in the
unit tests that caused them to pass even though they were actually
incorrect.

I've fixed this with this PR.

sorry for the inconvenience and the additional effort this will make to
you - hope you will find some timeto bring out this hotfix soon.

---------

Co-authored-by: Christoph Bühler <[email protected]>

Author: kimpenhaus

src/KubeOps.Generator/SyntaxReceiver/EntityFinalizerSyntaxReceiver.cs

@@ -5,7 +5,7 @@ namespace KubeOps.Generator.SyntaxReceiver;
 
 internal sealed class EntityFinalizerSyntaxReceiver : ISyntaxContextReceiver
 {
-    private const string IEntityFinalizerMetadataName = "KubeOps.Abstractions.Controller.IEntityFinalizer`1";
+    private const string IEntityFinalizerMetadataName = "KubeOps.Abstractions.Finalizer.IEntityFinalizer`1";
 
     public List<(ClassDeclarationSyntax Finalizer, string EntityName)> Finalizer { get; } = [];
 

test/KubeOps.Generator.Test/FinalizerRegistrationGenerator.Test.cs

@@ -69,7 +69,7 @@ public sealed class V1TestEntity : IKubernetesObject<V1ObjectMeta>
                 {
                 }
 
-                public sealed class EntityFinalizerBase<TEntity> : IEntityFinalizer<TEntity> 
+                public abstract class EntityFinalizerBase<TEntity> : IEntityFinalizer<TEntity> 
                     where TEntity : IKubernetesObject<V1ObjectMeta>
                 {
                 }
@@ -142,7 +142,7 @@ public sealed class V1TestEntity : IKubernetesObject<V1ObjectMeta>
                 {
                 }
 
-                public sealed class EntityFinalizerBase<TEntity> : IEntityFinalizer<TEntity> 
+                public abstract class EntityFinalizerBase<TEntity> : IEntityFinalizer<TEntity> 
                     where TEntity : IKubernetesObject<V1ObjectMeta>
                 {
                 }
@@ -165,25 +165,18 @@ public sealed class V1TestEntityFinalizer2 : IEntityFinalizer<V1TestEntity>
                      public static class FinalizerRegistrations
                      {
                          public const string V1TestEntityFinalizerIdentifier = "testing.dev/v1testentityfinalizer";
-                         public const string V1TestEntityFinalizer2 = "testing.dev/v1testentityfinalizer2";
+                         public const string V1TestEntityFinalizer2Identifier = "testing.dev/v1testentityfinalizer2finalizer";
                          public static IOperatorBuilder RegisterFinalizers(this IOperatorBuilder builder)
                          {
-                             builder.AddFinalizer<global::V1TestEntityFinalizer, global::V1TestEntity>(V1TestEntityFinalizer);
-                             builder.AddFinalizer<global::V1TestEntityFinalizer2, global::V1TestEntity>(V1TestEntityFinalizer2);
+                             builder.AddFinalizer<global::V1TestEntityFinalizer, global::V1TestEntity>(V1TestEntityFinalizerIdentifier);
+                             builder.AddFinalizer<global::V1TestEntityFinalizer2, global::V1TestEntity>(V1TestEntityFinalizer2Identifier);
                              return builder;
                          }
                      }
                      """)]
     public void Should_Generate_Correct_Code(string input, string expectedResult)
     {
         var inputCompilation = input.CreateCompilation();
-
-        var diagnostics = inputCompilation.GetDiagnostics();
-        if (diagnostics.Any(d => d.Severity == DiagnosticSeverity.Error))
-        {
-            return;
-        }
-
         expectedResult = expectedResult.ReplaceLineEndings();
 
         var driver = CSharpGeneratorDriver.Create(new FinalizerRegistrationGenerator());