Skip to content

Commit 4dd0d1c

Browse files
author
Christoph Bühler
committed
fix(code generator): correctly overwrite files and zero them when opening (fixes #13).
1 parent e09b45f commit 4dd0d1c

File tree

5 files changed

+15
-14
lines changed

5 files changed

+15
-14
lines changed

src/KubeOps/Operator/Commands/Generators/CrdGenerator.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)
5858
},
5959
}, Format));
6060
await using var kustomizationFile =
61-
File.OpenWrite(Path.Join(OutputPath, $"kustomization.{Format.ToString().ToLower()}"));
61+
File.Open(Path.Join(OutputPath, $"kustomization.{Format.ToString().ToLower()}"), FileMode.Create);
6262
await kustomizationFile.WriteAsync(kustomizeOutput);
6363
}
6464

@@ -70,8 +70,8 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)
7070

7171
if (!string.IsNullOrWhiteSpace(OutputPath))
7272
{
73-
await using var file = File.OpenWrite(Path.Join(OutputPath,
74-
$"{crd.Metadata.Name.Replace('.', '_')}.{Format.ToString().ToLower()}"));
73+
await using var file = File.Open(Path.Join(OutputPath,
74+
$"{crd.Metadata.Name.Replace('.', '_')}.{Format.ToString().ToLower()}"), FileMode.Create);
7575
await file.WriteAsync(Encoding.UTF8.GetBytes(output));
7676
}
7777
else

src/KubeOps/Operator/Commands/Generators/DockerGenerator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)
2929
var dockerfile = GenerateDockerfile();
3030
if (!string.IsNullOrWhiteSpace(OutputPath))
3131
{
32-
await using var file = File.OpenWrite(OutputPath);
32+
await using var file = File.Open(OutputPath, FileMode.Create);
3333
await file.WriteAsync(Encoding.UTF8.GetBytes(dockerfile));
3434
}
3535
else

src/KubeOps/Operator/Commands/Generators/InstallerGenerator.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,11 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)
7171
if (!string.IsNullOrWhiteSpace(OutputPath))
7272
{
7373
Directory.CreateDirectory(OutputPath);
74-
await using var nsFile = File.OpenWrite(Path.Join(OutputPath,
75-
$"namespace.{Format.ToString().ToLower()}"));
74+
await using var nsFile = File.Open(Path.Join(OutputPath,
75+
$"namespace.{Format.ToString().ToLower()}"), FileMode.Create);
7676
await nsFile.WriteAsync(Encoding.UTF8.GetBytes(ns));
77-
await using var kustomizeFile = File.OpenWrite(Path.Join(OutputPath,
78-
$"kustomization.{Format.ToString().ToLower()}"));
77+
await using var kustomizeFile = File.Open(Path.Join(OutputPath,
78+
$"kustomization.{Format.ToString().ToLower()}"), FileMode.Create);
7979
await kustomizeFile.WriteAsync(Encoding.UTF8.GetBytes(kustomize));
8080
}
8181
else

src/KubeOps/Operator/Commands/Generators/OperatorGenerator.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,9 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)
6262
if (!string.IsNullOrWhiteSpace(OutputPath))
6363
{
6464
Directory.CreateDirectory(OutputPath);
65-
await using var file = File.OpenWrite(Path.Join(OutputPath,
66-
$"deployment.{Format.ToString().ToLower()}"));
65+
await using var file = File.Open(Path.Join(OutputPath,
66+
$"deployment.{Format.ToString().ToLower()}"), FileMode.Create);
67+
6768
await file.WriteAsync(Encoding.UTF8.GetBytes(output));
6869

6970
var kustomize = new KustomizationConfig
@@ -76,7 +77,7 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)
7677
};
7778
var kustomizeOutput = Encoding.UTF8.GetBytes(_serializer.Serialize(kustomize, Format));
7879
await using var kustomizationFile =
79-
File.OpenWrite(Path.Join(OutputPath, $"kustomization.{Format.ToString().ToLower()}"));
80+
File.Open(Path.Join(OutputPath, $"kustomization.{Format.ToString().ToLower()}"), FileMode.Create);
8081
await kustomizationFile.WriteAsync(kustomizeOutput);
8182
}
8283
else

src/KubeOps/Operator/Commands/Generators/RbacGenerator.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)
3030
if (!string.IsNullOrWhiteSpace(OutputPath))
3131
{
3232
Directory.CreateDirectory(OutputPath);
33-
await using var file = File.OpenWrite(Path.Join(OutputPath,
34-
$"operator.{Format.ToString().ToLower()}"));
33+
await using var file = File.Open(Path.Join(OutputPath,
34+
$"operator.{Format.ToString().ToLower()}"), FileMode.Create);
3535
await file.WriteAsync(Encoding.UTF8.GetBytes(output));
3636

3737
var kustomize = new KustomizationConfig
@@ -44,7 +44,7 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)
4444
};
4545
var kustomizeOutput = Encoding.UTF8.GetBytes(_serializer.Serialize(kustomize, Format));
4646
await using var kustomizationFile =
47-
File.OpenWrite(Path.Join(OutputPath, $"kustomization.{Format.ToString().ToLower()}"));
47+
File.Open(Path.Join(OutputPath, $"kustomization.{Format.ToString().ToLower()}"), FileMode.Create);
4848
await kustomizationFile.WriteAsync(kustomizeOutput);
4949
}
5050
else

0 commit comments

Comments
 (0)