refactor(function naming): Use best practice names.

buehler · buehler · commit 4e675b8546e0 · 2021-01-29T15:13:43.000+01:00
BREAKING CHANGE: This essentially renames all async functions.
According to best practices, async functions should have the
suffix `Async`.
diff --git a/src/KubeOps/Operator/Caching/ResourceCache.cs b/src/KubeOps/Operator/Caching/ResourceCache.cs
@@ -9,8 +9,8 @@
 
 namespace KubeOps.Operator.Caching
 {
-    internal class ResourceCache<TEntity>
-        where TEntity : IKubernetesObject<V1ObjectMeta>
+    internal class ResourceCache<TResource>
+        where TResource : IKubernetesObject<V1ObjectMeta>
     {
         private const string ResourceVersion = "ResourceVersion";
         private const string ManagedFields = "ManagedFields";
@@ -25,18 +25,18 @@ internal class ResourceCache<TEntity>
                 MembersToIgnore = new() { ResourceVersion, ManagedFields },
             });
 
-        private readonly ConcurrentDictionary<string, TEntity> _cache = new();
+        private readonly ConcurrentDictionary<string, TResource> _cache = new();
 
-        private readonly ResourceCacheMetrics<TEntity> _metrics;
+        private readonly ResourceCacheMetrics<TResource> _metrics;
 
-        public ResourceCache(ResourceCacheMetrics<TEntity> metrics)
+        public ResourceCache(ResourceCacheMetrics<TResource> metrics)
         {
             _metrics = metrics;
         }
 
-        public TEntity Get(string id) => _cache[id];
+        public TResource Get(string id) => _cache[id];
 
-        public TEntity Upsert(TEntity resource, out CacheComparisonResult result)
+        public TResource Upsert(TResource resource, out CacheComparisonResult result)
         {
             result = CompareCache(resource);
 
@@ -48,9 +48,9 @@ public TEntity Upsert(TEntity resource, out CacheComparisonResult result)
             return resource;
         }
 
-        public void Fill(IEnumerable<TEntity> entities)
+        public void Fill(IEnumerable<TResource> resources)
         {
-            foreach (var entity in entities)
+            foreach (var entity in resources)
             {
                 var clone = entity.DeepClone();
                 _cache.AddOrUpdate(entity.Metadata.Uid, clone, (_, _) => clone);
@@ -60,7 +60,7 @@ public void Fill(IEnumerable<TEntity> entities)
             _metrics.CachedItemsSummary.Observe(_cache.Count);
         }
 
-        public void Remove(TEntity resource) => Remove(resource.Metadata.Uid);
+        public void Remove(TResource resource) => Remove(resource.Metadata.Uid);
 
         public void Clear()
         {
@@ -69,7 +69,7 @@ public void Clear()
             _metrics.CachedItemsSummary.Observe(_cache.Count);
         }
 
-        private CacheComparisonResult CompareCache(TEntity resource)
+        private CacheComparisonResult CompareCache(TResource resource)
         {
             if (!Exists(resource))
             {
@@ -96,7 +96,7 @@ private CacheComparisonResult CompareCache(TEntity resource)
             return CacheComparisonResult.Modified;
         }
 
-        private bool Exists(TEntity resource) => _cache.ContainsKey(resource.Metadata.Uid);
+        private bool Exists(TResource resource) => _cache.ContainsKey(resource.Metadata.Uid);
 
         private void Remove(string resourceUid)
         {
diff --git a/src/KubeOps/Operator/Commands/CommandHelpers/CertificateGenerator.cs b/src/KubeOps/Operator/Commands/CommandHelpers/CertificateGenerator.cs
@@ -62,7 +62,7 @@ public void Dispose()
             Delete(_servercsr);
         }
 
-        public async Task CreateCaCertificate(string outputFolder)
+        public async Task CreateCaCertificateAsync(string outputFolder)
         {
             if (!_initialized)
             {
@@ -90,7 +90,7 @@ await ExecuteProcess(
             await ListDir(outputFolder);
         }
 
-        public async Task CreateServerCertificate(
+        public async Task CreateServerCertificateAsync(
             string outputFolder,
             string name,
             string @namespace,
diff --git a/src/KubeOps/Operator/Commands/CommandHelpers/FileWriter.cs b/src/KubeOps/Operator/Commands/CommandHelpers/FileWriter.cs
@@ -21,7 +21,7 @@ public void Add(string filename, string content)
             _files.Add(filename, content);
         }
 
-        public async Task Output(string? outputPath = null)
+        public async Task OutputAsync(string? outputPath = null)
         {
             if (outputPath == null)
             {
diff --git a/src/KubeOps/Operator/Commands/Generators/CrdGenerator.cs b/src/KubeOps/Operator/Commands/Generators/CrdGenerator.cs
@@ -102,7 +102,7 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)
                     },
                     Format));
 
-            await fileWriter.Output(OutputPath);
+            await fileWriter.OutputAsync(OutputPath);
             return ExitCodes.Success;
         }
     }
diff --git a/src/KubeOps/Operator/Commands/Generators/InstallerGenerator.cs b/src/KubeOps/Operator/Commands/Generators/InstallerGenerator.cs
@@ -78,7 +78,7 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)
                     },
                     Format));
 
-            await fileWriter.Output(OutputPath);
+            await fileWriter.OutputAsync(OutputPath);
             return ExitCodes.Success;
         }
     }
diff --git a/src/KubeOps/Operator/Commands/Generators/OperatorGenerator.cs b/src/KubeOps/Operator/Commands/Generators/OperatorGenerator.cs
@@ -37,7 +37,7 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)
                 (!File.Exists(Path.Join(OutputPath, "ca.pem")) || !File.Exists(Path.Join(OutputPath, "ca-key.pem"))))
             {
                 using var certManager = new CertificateGenerator(app.Out);
-                await certManager.CreateCaCertificate(OutputPath);
+                await certManager.CreateCaCertificateAsync(OutputPath);
             }
 
             fileWriter.Add(
@@ -232,7 +232,7 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)
                         }),
                     Format));
 
-            await fileWriter.Output(OutputPath);
+            await fileWriter.OutputAsync(OutputPath);
             return ExitCodes.Success;
         }
     }
diff --git a/src/KubeOps/Operator/Commands/Generators/RbacGenerator.cs b/src/KubeOps/Operator/Commands/Generators/RbacGenerator.cs
@@ -99,7 +99,7 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)
                     },
                     Format));
 
-            await fileWriter.Output(OutputPath);
+            await fileWriter.OutputAsync(OutputPath);
             return ExitCodes.Success;
         }
     }
diff --git a/src/KubeOps/Operator/Commands/Management/Webhooks/Install.cs b/src/KubeOps/Operator/Commands/Management/Webhooks/Install.cs
@@ -52,12 +52,12 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)
 #if DEBUG
             CertificatesPath = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
             CaCertificatesPath = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
-            await certManager.CreateCaCertificate(CaCertificatesPath);
+            await certManager.CreateCaCertificateAsync(CaCertificatesPath);
 #endif
 
             Directory.CreateDirectory(CertificatesPath);
             File.Copy(Path.Join(CaCertificatesPath, "ca.pem"), Path.Join(Path.Join(CertificatesPath, "ca.pem")));
-            await certManager.CreateServerCertificate(
+            await certManager.CreateServerCertificateAsync(
                 CertificatesPath,
                 _settings.Name,
                 @namespace,
diff --git a/src/KubeOps/Operator/Commands/RunOperator.cs b/src/KubeOps/Operator/Commands/RunOperator.cs
@@ -18,7 +18,7 @@ internal class RunOperator
     {
         private readonly IHost _host;
         private readonly IKubernetesClient _client;
-        private OperatorSettings _settings;
+        private readonly OperatorSettings _settings;
 
         public RunOperator(IHost host, IKubernetesClient client, OperatorSettings settings)
         {
diff --git a/src/KubeOps/Operator/Controller/IManagedResourceController.cs b/src/KubeOps/Operator/Controller/IManagedResourceController.cs
@@ -7,8 +7,8 @@ internal interface IManagedResourceController : IDisposable
     {
         Type ControllerType { get; set; }
 
-        Task Start();
+        Task StartAsync();
 
-        Task Stop();
+        Task StopAsync();
     }
 }
diff --git a/src/KubeOps/Operator/Controller/ManagedResourceController{TResource}.cs b/src/KubeOps/Operator/Controller/ManagedResourceController{TResource}.cs
@@ -140,7 +140,7 @@ public ManagedResourceController(
                     ThreadPoolScheduler.Instance))
             .Merge();
 
-        public async Task Start()
+        public async Task StartAsync()
         {
             if (_settings.PreloadCache)
             {
@@ -159,7 +159,7 @@ public async Task Start()
             _metrics.Running.Set(1);
         }
 
-        public async Task Stop()
+        public async Task StopAsync()
         {
             _logger.LogTrace(@"Managed resource controller shutdown for type ""{type}"".", typeof(TResource));
             await _watcher.Stop();
diff --git a/src/KubeOps/Operator/Controller/ResourceControllerManager.cs b/src/KubeOps/Operator/Controller/ResourceControllerManager.cs
@@ -45,7 +45,7 @@ public Task StopAsync(CancellationToken cancellationToken)
             _leadershipSubscription?.Dispose();
             foreach (var controller in _controller)
             {
-                controller.Stop();
+                controller.StopAsync();
                 controller.Dispose();
             }
 
@@ -64,11 +64,11 @@ private void LeadershipChanged(LeaderState state)
             {
                 if (state == LeaderState.Leader)
                 {
-                    controller.Start();
+                    controller.StartAsync();
                 }
                 else
                 {
-                    controller.Stop();
+                    controller.StopAsync();
                 }
             }
         }
diff --git a/src/KubeOps/Operator/Events/EventManager.cs b/src/KubeOps/Operator/Events/EventManager.cs
@@ -25,7 +25,7 @@ public EventManager(IKubernetesClient client, OperatorSettings settings, ILogger
             _logger = logger;
         }
 
-        public async Task Publish(
+        public async Task PublishAsync(
             IKubernetesObject<V1ObjectMeta> resource,
             string reason,
             string message,
@@ -78,20 +78,25 @@ public async Task Publish(
                 @event.LastTimestamp);
 
             await _client.Save(@event);
-            _logger.LogDebug(@"Created or updated event with name ""{name}"".", eventName);
+            _logger.LogInformation(
+                @"Created or updated event with name ""{name}"" to new count {count} on resource ""{kind}/{name}"".",
+                eventName,
+                @event.Count,
+                resource.Kind,
+                resource.Name());
         }
 
-        public Task Publish(Corev1Event @event)
+        public Task PublishAsync(Corev1Event @event)
             => _client.Save(@event);
 
-        public IEventManager.Publisher CreatePublisher(string reason, string message, EventType type = EventType.Normal)
-            => resource => Publish(resource, reason, message, type);
+        public IEventManager.AsyncPublisher CreatePublisher(string reason, string message, EventType type = EventType.Normal)
+            => resource => PublishAsync(resource, reason, message, type);
 
-        public IEventManager.StaticPublisher CreatePublisher(
+        public IEventManager.AsyncStaticPublisher CreatePublisher(
             IKubernetesObject<V1ObjectMeta> resource,
             string reason,
             string message,
             EventType type = EventType.Normal)
-            => () => Publish(resource, reason, message, type);
+            => () => PublishAsync(resource, reason, message, type);
     }
 }
diff --git a/src/KubeOps/Operator/Events/IEventManager.cs b/src/KubeOps/Operator/Events/IEventManager.cs
@@ -17,7 +17,7 @@ public interface IEventManager
         /// When called, the publisher creates or updates the event defined by the params.
         /// </summary>
         /// <returns>A task that completes when the event is published.</returns>
-        public delegate Task StaticPublisher();
+        public delegate Task AsyncStaticPublisher();
 
         /// <summary>
         /// Delegate that publishes a predefined event for a resource that is passed.
@@ -27,18 +27,18 @@ public interface IEventManager
         /// </summary>
         /// <param name="resource">The resource on which the event should be published.</param>
         /// <returns>A task that completes when the event is published.</returns>
-        public delegate Task Publisher(IKubernetesObject<V1ObjectMeta> resource);
+        public delegate Task AsyncPublisher(IKubernetesObject<V1ObjectMeta> resource);
 
         /// <summary>
-        /// Publish an event in relation to a given resource.
+        /// PublishAsync an event in relation to a given resource.
         /// The event is created or updated if it exists.
         /// </summary>
         /// <param name="resource">The resource that is involved with the event.</param>
         /// <param name="reason">The reason string. This should be a machine readable reason string.</param>
         /// <param name="message">A human readable string for the event.</param>
         /// <param name="type">The type of the event.</param>
         /// <returns>A task that finishes when the event is created or updated.</returns>
-        Task Publish(
+        Task PublishAsync(
             IKubernetesObject<V1ObjectMeta> resource,
             string reason,
             string message,
@@ -49,33 +49,33 @@ Task Publish(
         /// </summary>
         /// <param name="event">The full event object that should be created or updated.</param>
         /// <returns>A task that finishes when the event is created or updated.</returns>
-        Task Publish(Corev1Event @event);
+        Task PublishAsync(Corev1Event @event);
 
         /// <summary>
-        /// Create a <see cref="Publisher"/> for a predefined event.
-        /// The <see cref="Publisher"/> is then called with a resource (<see cref="IKubernetesObject{V1ObjectMeta}"/>).
+        /// Create a <see cref="AsyncPublisher"/> for a predefined event.
+        /// The <see cref="AsyncPublisher"/> is then called with a resource (<see cref="IKubernetesObject{V1ObjectMeta}"/>).
         /// The predefined event is published with this resource as the involved object.
         /// </summary>
         /// <param name="reason">The reason string. This should be a machine readable reason string.</param>
         /// <param name="message">A human readable string for the event.</param>
         /// <param name="type">The type of the event.</param>
-        /// <returns>A <see cref="Publisher"/> delegate that can be called to create or update events.</returns>
-        Publisher CreatePublisher(
+        /// <returns>A <see cref="AsyncPublisher"/> delegate that can be called to create or update events.</returns>
+        AsyncPublisher CreatePublisher(
             string reason,
             string message,
             EventType type = EventType.Normal);
 
         /// <summary>
-        /// Create a <see cref="StaticPublisher"/> for a predefined event.
-        /// The <see cref="StaticPublisher"/> is then called without any parameters.
+        /// Create a <see cref="AsyncStaticPublisher"/> for a predefined event.
+        /// The <see cref="AsyncStaticPublisher"/> is then called without any parameters.
         /// The predefined event is published with the initially given resource as the involved object.
         /// </summary>
         /// <param name="resource">The resource that is involved with the event.</param>
         /// <param name="reason">The reason string. This should be a machine readable reason string.</param>
         /// <param name="message">A human readable string for the event.</param>
         /// <param name="type">The type of the event.</param>
-        /// <returns>A <see cref="StaticPublisher"/> delegate that can be called to create or update events.</returns>
-        StaticPublisher CreatePublisher(
+        /// <returns>A <see cref="AsyncStaticPublisher"/> delegate that can be called to create or update events.</returns>
+        AsyncStaticPublisher CreatePublisher(
             IKubernetesObject<V1ObjectMeta> resource,
             string reason,
             string message,
diff --git a/src/KubeOps/Operator/HostExtensions.cs b/src/KubeOps/Operator/HostExtensions.cs
@@ -20,7 +20,7 @@ public static class HostExtensions
         /// <param name="host">The <see cref="IHost"/>.</param>
         /// <param name="args">Program arguments.</param>
         /// <returns>Async task with completion result.</returns>
-        public static Task<int> RunOperator(this IHost host, string[] args)
+        public static Task<int> RunOperatorAsync(this IHost host, string[] args)
         {
             var app = new CommandLineApplication<RunOperator>();
             app
diff --git a/src/KubeOps/Operator/Kubernetes/ResourceWatcher{TEntity}.cs b/src/KubeOps/Operator/Kubernetes/ResourceWatcher{TEntity}.cs
@@ -46,7 +46,6 @@ public ResourceWatcher(
                     .Select(Observable.Timer)
                     .Switch()
                     .Subscribe(async _ => await WatchResource());
-            //new ExponentialBackoffHandler(async () => await WatchResource());
         }
 
         public IObservable<(WatchEventType Event, TResource Resource)> WatchEvents => _watchEvents;
diff --git a/tests/KubeOps.TestOperator/Program.cs b/tests/KubeOps.TestOperator/Program.cs
@@ -9,7 +9,7 @@ namespace KubeOps.TestOperator
 {
     public static class Program
     {
-        public static Task<int> Main(string[] args) => CreateHostBuilder(args).Build().RunOperator(args);
+        public static Task<int> Main(string[] args) => CreateHostBuilder(args).Build().RunOperatorAsync(args);
 
         private static IHostBuilder CreateHostBuilder(string[] args) =>
             Host.CreateDefaultBuilder(args)

Original file line number	Diff line number	Diff line change
`@@ -9,8 +9,8 @@`
`9`	`9`
`10`	`10`	`namespace KubeOps.Operator.Caching`
`11`	`11`	`{`
`12`		`- internal class ResourceCache<TEntity>`
`13`		`- where TEntity : IKubernetesObject<V1ObjectMeta>`
	`12`	`+ internal class ResourceCache<TResource>`
	`13`	`+ where TResource : IKubernetesObject<V1ObjectMeta>`
`14`	`14`	`{`
`15`	`15`	`private const string ResourceVersion = "ResourceVersion";`
`16`	`16`	`private const string ManagedFields = "ManagedFields";`
`@@ -25,18 +25,18 @@ internal class ResourceCache<TEntity>`
`25`	`25`	`MembersToIgnore = new() { ResourceVersion, ManagedFields },`
`26`	`26`	`});`
`27`	`27`
`28`		`- private readonly ConcurrentDictionary<string, TEntity> _cache = new();`
	`28`	`+ private readonly ConcurrentDictionary<string, TResource> _cache = new();`
`29`	`29`
`30`		`- private readonly ResourceCacheMetrics<TEntity> _metrics;`
	`30`	`+ private readonly ResourceCacheMetrics<TResource> _metrics;`
`31`	`31`
`32`		`- public ResourceCache(ResourceCacheMetrics<TEntity> metrics)`
	`32`	`+ public ResourceCache(ResourceCacheMetrics<TResource> metrics)`
`33`	`33`	`{`
`34`	`34`	`_metrics = metrics;`
`35`	`35`	`}`
`36`	`36`
`37`		`- public TEntity Get(string id) => _cache[id];`
	`37`	`+ public TResource Get(string id) => _cache[id];`
`38`	`38`
`39`		`- public TEntity Upsert(TEntity resource, out CacheComparisonResult result)`
	`39`	`+ public TResource Upsert(TResource resource, out CacheComparisonResult result)`
`40`	`40`	`{`
`41`	`41`	`result = CompareCache(resource);`
`42`	`42`
`@@ -48,9 +48,9 @@ public TEntity Upsert(TEntity resource, out CacheComparisonResult result)`
`48`	`48`	`return resource;`
`49`	`49`	`}`
`50`	`50`
`51`		`- public void Fill(IEnumerable<TEntity> entities)`
	`51`	`+ public void Fill(IEnumerable<TResource> resources)`
`52`	`52`	`{`
`53`		`- foreach (var entity in entities)`
	`53`	`+ foreach (var entity in resources)`
`54`	`54`	`{`
`55`	`55`	`var clone = entity.DeepClone();`
`56`	`56`	`_cache.AddOrUpdate(entity.Metadata.Uid, clone, (_, _) => clone);`
`@@ -60,7 +60,7 @@ public void Fill(IEnumerable<TEntity> entities)`
`60`	`60`	`_metrics.CachedItemsSummary.Observe(_cache.Count);`
`61`	`61`	`}`
`62`	`62`
`63`		`- public void Remove(TEntity resource) => Remove(resource.Metadata.Uid);`
	`63`	`+ public void Remove(TResource resource) => Remove(resource.Metadata.Uid);`
`64`	`64`
`65`	`65`	`public void Clear()`
`66`	`66`	`{`
`@@ -69,7 +69,7 @@ public void Clear()`
`69`	`69`	`_metrics.CachedItemsSummary.Observe(_cache.Count);`
`70`	`70`	`}`
`71`	`71`
`72`		`- private CacheComparisonResult CompareCache(TEntity resource)`
	`72`	`+ private CacheComparisonResult CompareCache(TResource resource)`
`73`	`73`	`{`
`74`	`74`	`if (!Exists(resource))`
`75`	`75`	`{`
`@@ -96,7 +96,7 @@ private CacheComparisonResult CompareCache(TEntity resource)`
`96`	`96`	`return CacheComparisonResult.Modified;`
`97`	`97`	`}`
`98`	`98`
`99`		`- private bool Exists(TEntity resource) => _cache.ContainsKey(resource.Metadata.Uid);`
	`99`	`+ private bool Exists(TResource resource) => _cache.ContainsKey(resource.Metadata.Uid);`
`100`	`100`
`101`	`101`	`private void Remove(string resourceUid)`
`102`	`102`	`{`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public void Dispose()`
`62`	`62`	`Delete(_servercsr);`
`63`	`63`	`}`
`64`	`64`
`65`		`- public async Task CreateCaCertificate(string outputFolder)`
	`65`	`+ public async Task CreateCaCertificateAsync(string outputFolder)`
`66`	`66`	`{`
`67`	`67`	`if (!_initialized)`
`68`	`68`	`{`
`@@ -90,7 +90,7 @@ await ExecuteProcess(`
`90`	`90`	`await ListDir(outputFolder);`
`91`	`91`	`}`
`92`	`92`
`93`		`- public async Task CreateServerCertificate(`
	`93`	`+ public async Task CreateServerCertificateAsync(`
`94`	`94`	`string outputFolder,`
`95`	`95`	`string name,`
`96`	`96`	`string @namespace,`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public void Add(string filename, string content)`
`21`	`21`	`_files.Add(filename, content);`
`22`	`22`	`}`
`23`	`23`
`24`		`- public async Task Output(string? outputPath = null)`
	`24`	`+ public async Task OutputAsync(string? outputPath = null)`
`25`	`25`	`{`
`26`	`26`	`if (outputPath == null)`
`27`	`27`	`{`
Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)`
`102`	`102`	`},`
`103`	`103`	`Format));`
`104`	`104`
`105`		`- await fileWriter.Output(OutputPath);`
	`105`	`+ await fileWriter.OutputAsync(OutputPath);`
`106`	`106`	`return ExitCodes.Success;`
`107`	`107`	`}`
`108`	`108`	`}`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)`
`78`	`78`	`},`
`79`	`79`	`Format));`
`80`	`80`
`81`		`- await fileWriter.Output(OutputPath);`
	`81`	`+ await fileWriter.OutputAsync(OutputPath);`
`82`	`82`	`return ExitCodes.Success;`
`83`	`83`	`}`
`84`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)`
`37`	`37`	`(!File.Exists(Path.Join(OutputPath, "ca.pem")) \|\| !File.Exists(Path.Join(OutputPath, "ca-key.pem"))))`
`38`	`38`	`{`
`39`	`39`	`using var certManager = new CertificateGenerator(app.Out);`
`40`		`- await certManager.CreateCaCertificate(OutputPath);`
	`40`	`+ await certManager.CreateCaCertificateAsync(OutputPath);`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`fileWriter.Add(`
`@@ -232,7 +232,7 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)`
`232`	`232`	`}),`
`233`	`233`	`Format));`
`234`	`234`
`235`		`- await fileWriter.Output(OutputPath);`
	`235`	`+ await fileWriter.OutputAsync(OutputPath);`
`236`	`236`	`return ExitCodes.Success;`
`237`	`237`	`}`
`238`	`238`	`}`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ public async Task<int> OnExecuteAsync(CommandLineApplication app)`
`99`	`99`	`},`
`100`	`100`	`Format));`
`101`	`101`
`102`		`- await fileWriter.Output(OutputPath);`
	`102`	`+ await fileWriter.OutputAsync(OutputPath);`
`103`	`103`	`return ExitCodes.Success;`
`104`	`104`	`}`
`105`	`105`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ internal class RunOperator`
`18`	`18`	`{`
`19`	`19`	`private readonly IHost _host;`
`20`	`20`	`private readonly IKubernetesClient _client;`
`21`		`- private OperatorSettings _settings;`
	`21`	`+ private readonly OperatorSettings _settings;`
`22`	`22`
`23`	`23`	`public RunOperator(IHost host, IKubernetesClient client, OperatorSettings settings)`
`24`	`24`	`{`
Original file line number	Diff line number	Diff line change
`@@ -7,8 +7,8 @@ internal interface IManagedResourceController : IDisposable`
`7`	`7`	`{`
`8`	`8`	`Type ControllerType { get; set; }`
`9`	`9`
`10`		`- Task Start();`
	`10`	`+ Task StartAsync();`
`11`	`11`
`12`		`- Task Stop();`
	`12`	`+ Task StopAsync();`
`13`	`13`	`}`
`14`	`14`	`}`