chore: upgrade src to c#12

This closes #659.

Author: buehler

.editorconfig

@@ -23,6 +23,8 @@ end_of_line = crlf
 insert_final_newline = true
 
 #### Custom Analyzer Rules ####
+# Until https://github.com/SonarSource/sonar-dotnet/issues/7624 is shipped.
+dotnet_diagnostic.S3604.severity = none
 
 dotnet_diagnostic.SA0001.severity = none
 dotnet_diagnostic.SA1600.severity = none

examples/Operator/Controller/V1TestEntityController.cs

@@ -10,34 +10,23 @@
 namespace Operator.Controller;
 
 [EntityRbac(typeof(V1TestEntity), Verbs = RbacVerb.All)]
-public class V1TestEntityController : IEntityController<V1TestEntity>
-{
-    private readonly ILogger<V1TestEntityController> _logger;
-    private readonly EntityRequeue<V1TestEntity> _requeue;
-    private readonly EventPublisher _eventPublisher;
-
-    public V1TestEntityController(
-        ILogger<V1TestEntityController> logger,
+public class V1TestEntityController(ILogger<V1TestEntityController> logger,
         EntityRequeue<V1TestEntity> requeue,
         EventPublisher eventPublisher)
-    {
-        _logger = logger;
-        _requeue = requeue;
-        _eventPublisher = eventPublisher;
-    }
-
+    : IEntityController<V1TestEntity>
+{
     public async Task ReconcileAsync(V1TestEntity entity)
     {
-        _logger.LogInformation("Reconciling entity {Entity}.", entity);
+        logger.LogInformation("Reconciling entity {Entity}.", entity);
 
-        await _eventPublisher(entity, "RECONCILED", "Entity was reconciled.");
+        await eventPublisher(entity, "RECONCILED", "Entity was reconciled.");
 
-        _requeue(entity, TimeSpan.FromSeconds(5));
+        requeue(entity, TimeSpan.FromSeconds(5));
     }
 
     public Task DeletedAsync(V1TestEntity entity)
     {
-        _logger.LogInformation("Deleting entity {Entity}.", entity);
+        logger.LogInformation("Deleting entity {Entity}.", entity);
         return Task.CompletedTask;
     }
 }

examples/WebhookOperator/Controller/V1TestEntityController.cs

@@ -6,25 +6,17 @@
 namespace WebhookOperator.Controller;
 
 [EntityRbac(typeof(V1TestEntity), Verbs = RbacVerb.All)]
-public class V1TestEntityController : IEntityController<V1TestEntity>
+public class V1TestEntityController(ILogger<V1TestEntityController> logger) : IEntityController<V1TestEntity>
 {
-    private readonly ILogger<V1TestEntityController> _logger;
-
-    public V1TestEntityController(
-        ILogger<V1TestEntityController> logger)
-    {
-        _logger = logger;
-    }
-
     public Task ReconcileAsync(V1TestEntity entity)
     {
-        _logger.LogInformation("Reconciling entity {Entity}.", entity);
+        logger.LogInformation("Reconciling entity {Entity}.", entity);
         return Task.CompletedTask;
     }
 
     public Task DeletedAsync(V1TestEntity entity)
     {
-        _logger.LogInformation("Deleted entity {Entity}.", entity);
+        logger.LogInformation("Deleted entity {Entity}.", entity);
         return Task.CompletedTask;
     }
 }

src/KubeOps.Abstractions/Entities/Attributes/AdditionalPrinterColumnAttribute.cs

@@ -4,18 +4,13 @@
 /// Defines a property as an additional printer column.
 /// </summary>
 [AttributeUsage(AttributeTargets.Property)]
-public class AdditionalPrinterColumnAttribute : Attribute
+public class AdditionalPrinterColumnAttribute(PrinterColumnPriority priority = default, string? name = null)
+    : Attribute
 {
-    public AdditionalPrinterColumnAttribute(PrinterColumnPriority priority = default, string? name = null)
-    {
-        Name = name;
-        Priority = priority;
-    }
-
     /// <summary>
     /// The name of the column. Defaults to the property-name.
     /// </summary>
-    public string? Name { get; }
+    public string? Name => name;
 
     /// <summary>
     /// The priority of the additional printer column.
@@ -31,5 +26,5 @@ public AdditionalPrinterColumnAttribute(PrinterColumnPriority priority = default
     /// </item>
     /// </list>
     /// </summary>
-    public PrinterColumnPriority Priority { get; }
+    public PrinterColumnPriority Priority => priority;
 }

src/KubeOps.Abstractions/Entities/Attributes/DescriptionAttribute.cs

@@ -5,12 +5,10 @@
 /// XML documentation file.
 /// </summary>
 [AttributeUsage(AttributeTargets.Property | AttributeTargets.Class)]
-public class DescriptionAttribute : Attribute
+public class DescriptionAttribute(string description) : Attribute
 {
-    public DescriptionAttribute(string description) => Description = description;
-
     /// <summary>
     /// The given description for the property.
     /// </summary>
-    public string Description { get; }
+    public string Description => description;
 }

src/KubeOps.Abstractions/Entities/Attributes/EmbeddedResourceAttribute.cs

@@ -9,6 +9,4 @@ namespace KubeOps.Abstractions.Entities.Attributes;
 /// This implicitly sets the <see cref="PreserveUnknownFieldsAttribute"/>.
 /// </summary>
 [AttributeUsage(AttributeTargets.Property)]
-public class EmbeddedResourceAttribute : Attribute
-{
-}
+public class EmbeddedResourceAttribute : Attribute;

src/KubeOps.Abstractions/Entities/Attributes/EntityScopeAttribute.cs

@@ -1,12 +1,7 @@
 namespace KubeOps.Abstractions.Entities.Attributes;
 
 [AttributeUsage(AttributeTargets.Class, Inherited = false)]
-public class EntityScopeAttribute : Attribute
+public class EntityScopeAttribute(EntityScope scope = default) : Attribute
 {
-    public EntityScopeAttribute(EntityScope scope = default)
-    {
-        Scope = scope;
-    }
-
-    public EntityScope Scope { get; }
+    public EntityScope Scope => scope;
 }

src/KubeOps.Abstractions/Entities/Attributes/ExternalDocsAttribute.cs

@@ -4,21 +4,15 @@
 /// Defines that the property has an external documentation.
 /// </summary>
 [AttributeUsage(AttributeTargets.Property)]
-public class ExternalDocsAttribute : Attribute
+public class ExternalDocsAttribute(string url, string? description = null) : Attribute
 {
-    public ExternalDocsAttribute(string url, string? description = null)
-    {
-        Description = description;
-        Url = url;
-    }
-
     /// <summary>
     /// Additional description.
     /// </summary>
-    public string? Description { get; }
+    public string? Description => description;
 
     /// <summary>
     /// Url where to find the documentation.
     /// </summary>
-    public string Url { get; }
+    public string Url => url;
 }

src/KubeOps.Abstractions/Entities/Attributes/IgnoreEntityAttribute.cs

@@ -5,6 +5,4 @@
 /// ignored during CRD generation.
 /// </summary>
 [AttributeUsage(AttributeTargets.Class | AttributeTargets.Property)]
-public class IgnoreAttribute : Attribute
-{
-}
+public class IgnoreAttribute : Attribute;

src/KubeOps.Abstractions/Entities/Attributes/ItemsAttribute.cs

@@ -4,29 +4,23 @@
 /// Define minimum and maximum items count for an array property.
 /// </summary>
 [AttributeUsage(AttributeTargets.Property)]
-public class ItemsAttribute : Attribute
+public class ItemsAttribute(long minItems = -1, long maxItems = -1) : Attribute
 {
-    public ItemsAttribute(long minItems = -1, long maxItems = -1)
-    {
-        MinItems = minItems switch
-        {
-            -1 => null,
-            _ => minItems,
-        };
-        MaxItems = maxItems switch
-        {
-            -1 => null,
-            _ => maxItems,
-        };
-    }
-
     /// <summary>
     /// Defines the minimal item count for the property.
     /// </summary>
-    public long? MinItems { get; }
+    public long? MinItems => minItems switch
+    {
+        -1 => null,
+        _ => minItems,
+    };
 
     /// <summary>
     /// Defines the maximal item count for the property.
     /// </summary>
-    public long? MaxItems { get; }
+    public long? MaxItems => maxItems switch
+    {
+        -1 => null,
+        _ => maxItems,
+    };
 }