fix: IKubernetesClient.Get<> not retrieving namespaced resources due to parameter swap (#511)

georgevella · web-flow · commit ff20e452e626 · 2023-01-26T13:19:45.000Z
While using the latest version of KubeOps,KubernetesClient, I've noticed
that retrieval of kubernetes resources (ConfigMaps and a Deployment) was
not working when passing a namespace.

After further investigation, I've noticed that the underlying
`GenericClient&lt;&gt;.ReadNamespacedAsync()` function had swapped parameters
which was causing retrieval of resources to fail.
diff --git a/src/KubeOps.KubernetesClient/KubernetesClient.cs b/src/KubeOps.KubernetesClient/KubernetesClient.cs
@@ -72,7 +72,7 @@ public Task<string> GetCurrentNamespace(string downwardApiEnvName = "POD_NAMESPA
 
             return await (string.IsNullOrWhiteSpace(@namespace)
                 ? client.ReadAsync<TResource>(name)
-                : client.ReadNamespacedAsync<TResource>(name, @namespace));
+                : client.ReadNamespacedAsync<TResource>(@namespace, name));
         }
         catch (HttpOperationException e) when (e.Response.StatusCode == HttpStatusCode.NotFound)
         {

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public Task<string> GetCurrentNamespace(string downwardApiEnvName = "POD_NAMESPA`
`72`	`72`
`73`	`73`	`return await (string.IsNullOrWhiteSpace(@namespace)`
`74`	`74`	`? client.ReadAsync<TResource>(name)`
`75`		`- : client.ReadNamespacedAsync<TResource>(name, @namespace));`
	`75`	`+ : client.ReadNamespacedAsync<TResource>(@namespace, name));`
`76`	`76`	`}`
`77`	`77`	`catch (HttpOperationException e) when (e.Response.StatusCode == HttpStatusCode.NotFound)`
`78`	`78`	`{`