remove misguided workaround

Author: majocha

src/Compiler/Checking/CheckDeclarations.fs

@@ -4218,13 +4218,16 @@ module TcDeclarations =
                 | Result res ->
                     // Update resolved type parameters with the names from the source.
                     let _, tcref, _ = res
-
-                    if (not g.deterministic) && tcref.TyparsNoRange.Length = synTypars.Length then
+                   
+                    if tcref.TyparsNoRange.Length = synTypars.Length then
                         (tcref.TyparsNoRange, synTypars)
                         ||> List.zip
                         |> List.iter (fun (typar, SynTyparDecl.SynTyparDecl (typar = tp)) ->
                             let (SynTypar(ident = untypedIdent; staticReq = sr)) = tp
                             if typar.StaticReq = sr then
+                                // TODO: mutating typar here can lead to a race during parallel type checking.
+                                // Some type extensions can end up with a wrong type argument name.
+                                // This will break deterministic builds.
                                 typar.SetIdent(untypedIdent)
                         )
 

src/Compiler/CodeGen/IlxGen.fs

@@ -2766,6 +2766,7 @@ let GenConstArray cenv (cgbuf: CodeGenBuffer) eenv ilElementType (data: 'a[]) (w
         CG.EmitInstrs cgbuf (pop 0) (Push [ ilArrayType ]) [ mkLdcInt32 0; I_newarr(ILArrayShape.SingleDimensional, ilElementType) ]
     else
         let vtspec = cgbuf.mgbuf.GenerateRawDataValueType(eenv.cloc, bytes.Length)
+
         let unique =
             g.CompilerGlobalState.Value.IlxGenNiceNameGenerator.IncrementOnly("@field", eenv.cloc.Range)
 

src/Compiler/Driver/CompilerImports.fs

@@ -2606,7 +2606,6 @@ and [<Sealed>] TcImports
                     tcConfig.pathMap,
                     tcConfig.langVersion,
                     tcConfig.realsig,
-                    tcConfig.deterministic,
                     tcConfig.compilationMode
                 )
 

src/Compiler/Service/IncrementalBuild.fs

@@ -573,7 +573,6 @@ type FrameworkImportsCache(size) =
                         tcGlobals.pathMap,
                         tcConfig.langVersion,
                         tcConfig.realsig,
-                        tcConfig.deterministic,
                         tcConfig.compilationMode
                     )
 

src/Compiler/SyntaxTree/UnicodeLexing.fs

@@ -8,7 +8,7 @@ open Internal.Utilities.Text.Lexing
 
 type Lexbuf = LexBuffer<char>
 
-type LexBuffer<'char> with
+type LexBuffer<'Char> with
 
     member lexbuf.GetLocalData<'T when 'T: not null>(key: string, initializer) =
         match lexbuf.BufferLocalStore.TryGetValue key with

src/Compiler/SyntaxTree/UnicodeLexing.fsi

@@ -9,7 +9,7 @@ open Internal.Utilities.Text.Lexing
 
 type Lexbuf = LexBuffer<char>
 
-type LexBuffer<'char> with
+type LexBuffer<'Char> with
     member GetLocalData<'T when 'T: not null> : key: string * initializer: (unit -> 'T) -> 'T
     member TryGetLocalData<'T when 'T: not null> : key: string -> 'T option
 

src/Compiler/TypedTree/TcGlobals.fs

@@ -198,7 +198,6 @@ type TcGlobals(
     pathMap: PathMap,
     langVersion: LanguageVersion,
     realsig: bool,
-    deterministic: bool,
     compilationMode: CompilationMode) =
 
   let v_langFeatureNullness = langVersion.SupportsFeature LanguageFeature.NullnessChecking
@@ -1848,8 +1847,6 @@ type TcGlobals(
   /// Are we assuming all code gen is for F# interactive, with no static linking
   member _.isInteractive=isInteractive
 
-  member val deterministic = deterministic
-
   member val compilationMode = compilationMode
 
   /// Indicates if we are generating witness arguments for SRTP constraints. Only done if the FSharp.Core

src/Compiler/TypedTree/TcGlobals.fsi

@@ -157,7 +157,6 @@ type internal TcGlobals =
         pathMap: Internal.Utilities.PathMap *
         langVersion: FSharp.Compiler.Features.LanguageVersion *
         realsig: bool *
-        deterministic: bool *
         compilationMode: CompilationMode ->
             TcGlobals