Update baselines

Author: auduchinok

tests/FSharp.Compiler.ComponentTests/Language/FixedBindings/FixedBindings.fs

@@ -43,9 +43,9 @@ module Legacy =
         |> withDiagnostics [
             (Warning 9, Line 5, Col 9, Line 5, Col 31, """Uses of this construct may result in the generation of unverifiable .NET IL code. This warning can be disabled using '--nowarn:9' or '#nowarn "9"'.""")
             (Error 1, Line 5, Col 9, Line 5, Col 31, """Type mismatch. Expecting a
-'nativeptr<int>' 
+    'nativeptr<int>'    
 but given a
-'nativeptr<byte>' 
+    'nativeptr<byte>'    
 The type 'int' does not match the type 'byte'""")
             (Warning 9, Line 6, Col 5, Line 6, Col 18, """Uses of this construct may result in the generation of unverifiable .NET IL code. This warning can be disabled using '--nowarn:9' or '#nowarn "9"'.""")
         ]

tests/FSharp.Compiler.Service.Tests/PatternMatchCompilationTests.fs

@@ -28,7 +28,7 @@ let ("": unit), (x: int) = let y = () in ()
     dumpDiagnostics checkResults |> shouldEqual [
         "(2,5--2,7): This expression was expected to have type 'unit' but here has type 'string'";
         "(2,41--2,43): This expression was expected to have type 'unit * int' but here has type 'unit'";
-        "(2,4--2,24): Incomplete pattern matches on this expression."
+        """(2,4--2,24): Incomplete pattern matches on this expression. For example, the value '("a",_)' may indicate a case not covered by the pattern(s)."""
     ]
 
 [<FactForNETCOREAPP>]
@@ -83,7 +83,7 @@ match A with
     assertHasSymbolUsages ["x"; "y"] checkResults
     dumpDiagnostics checkResults |> shouldEqual [
         "(7,5--7,12): This expression was expected to have type 'int' but here has type ''a * 'b * 'c'";
-        "(6,6--6,7): Incomplete pattern matches on this expression."
+        "(6,6--6,7): Incomplete pattern matches on this expression. For example, the value 'A' may indicate a case not covered by the pattern(s)."
     ]
 
 
@@ -171,7 +171,7 @@ match Some 1 with
     assertHasSymbolUsages ["a"] checkResults
     dumpDiagnostics checkResults |> shouldEqual [
         "(3,7--3,14): This expression was expected to have type 'int' but here has type ''a option'"
-        "(2,6--2,12): Incomplete pattern matches on this expression."
+        """(2,6--2,12): Incomplete pattern matches on this expression. For example, the value 'Some (Some ("a"))' may indicate a case not covered by the pattern(s)."""
     ]
 
 [<FactForNETCOREAPP>]
@@ -183,7 +183,7 @@ match Some 1 with
     assertHasSymbolUsages ["a"; "i"] checkResults
     dumpDiagnostics checkResults |> shouldEqual [
         "(3,7--3,18): This expression was expected to have type 'int' but here has type ''a option'";
-        "(2,6--2,12): Incomplete pattern matches on this expression."
+        """(2,6--2,12): Incomplete pattern matches on this expression. For example, the value 'Some (Some (("a",_)))' may indicate a case not covered by the pattern(s)."""
     ]
 
 [<FactForNETCOREAPP>]
@@ -337,6 +337,8 @@ match Unchecked.defaultof<System.ValueType> with
     assertHasSymbolUsages ["a"; "b"; "c"; "d"] checkResults
     dumpDiagnostics checkResults |> shouldEqual [
         "(5,21--5,27): Type constraint mismatch. The type 'int' is not compatible with type 'System.Enum'"
+        "(6,2--6,11): Type constraint mismatch. The type 'string' is not compatible with type 'System.ValueType'"
+        "(4,2--4,46): This rule will never be matched"
     ]
 
 [<FactForNETCOREAPP>]
@@ -958,6 +960,8 @@ Some "" |> eq<int> // No more type checks after the above line?
     dumpDiagnostics checkResults |> shouldEqual [
         "(27,2--27,14): This expression was expected to have type 'objnull' but here has type 'struct ('a * 'b)'";
         "(52,2--52,13): This expression was expected to have type 'objnull' but here has type 'AAA'";
+        "(53,11--53,18): Type mismatch. Expecting a 'string option -> 'a' but given a 'int option -> unit' The type 'int' does not match the type 'string'"
+        "(51,6--51,21): Incomplete pattern matches on this expression. For example, the value '``some-other-subtype``' may indicate a case not covered by the pattern(s).";
         "(26,6--26,24): Incomplete pattern matches on this expression. For example, the value '``some-other-subtype``' may indicate a case not covered by the pattern(s).";
         "(24,6--24,12): Incomplete pattern matches on this expression. For example, the value '``some-other-subtype``' may indicate a case not covered by the pattern(s).";
         "(22,6--22,12): Incomplete pattern matches on this expression. For example, the value '``some-other-subtype``' may indicate a case not covered by the pattern(s).";

tests/FSharp.Compiler.Service.Tests/ProjectAnalysisTests.fs

@@ -3060,7 +3060,7 @@ let ``Test Project21 whole project errors`` () =
     let wholeProjectResults = checker.ParseAndCheckProject(Project21.options) |> Async.RunImmediate
     for e in wholeProjectResults.Diagnostics do
         printfn "Project21 error: <<<%s>>>" e.Message
-    wholeProjectResults.Diagnostics.Length |> shouldEqual 2
+    wholeProjectResults.Diagnostics.Length |> shouldEqual 1
 
 
 [<Fact>]
@@ -3090,13 +3090,20 @@ let ``Test Project21 all symbols`` () =
             ("int", "int", "file1", ((8, 27), (8, 30)), ["type"], ["abbrev"]);
             ("val x", "x", "file1", ((9, 21), (9, 22)), ["defn"], []);
             ("string", "string", "file1", ((9, 37), (9, 43)), ["type"], ["abbrev"]);
+            ("val arg1", "arg1", "file1", ((9, 31), (9, 35)), ["defn"], []);
+            ("unit", "unit", "file1", ((9, 46), (9, 50)), ["type"], ["abbrev"]);
+            ("val raise", "raise", "file1", ((10, 18), (10, 23)), [], ["val"]);
+            ("System", "System", "file1", ((10, 25), (10, 31)), [], ["namespace"]);
+            ("member .ctor", "NotImplementedException", "file1", ((10, 25), (10, 55)), [], ["member"]);
             ("val x", "x", "file1", ((12, 21), (12, 22)), ["defn"], []);
             ("int", "int", "file1", ((12, 37), (12, 40)), ["type"], ["abbrev"]);
             ("val arg1", "arg1", "file1", ((12, 31), (12, 35)), ["defn"], []);
             ("unit", "unit", "file1", ((12, 43), (12, 47)), ["type"], ["abbrev"]);
             ("val raise", "raise", "file1", ((13, 18), (13, 23)), [], ["val"]);
             ("System", "System", "file1", ((13, 25), (13, 31)), [], ["namespace"]);
             ("member .ctor", "NotImplementedException", "file1", ((13, 25), (13, 55)), [], ["member"]);
+            ("member Method1", "Method1", "file1", ((9, 23), (9, 30)), ["override"], ["slot"; "member"]);
+            ("member Method2", "Method2", "file1", ((12, 23), (12, 30)), ["override"], ["slot"; "member"])
             ("Impl", "Impl", "file1", ((2, 7), (2, 11)), ["defn"], ["module"])|]
 
 //-----------------------------------------------------------------------------------------

tests/fsharp/Compiler/Language/AnonRecordTests.fs

@@ -27,24 +27,18 @@ let sAnon = StructClass<struct {| S: int |}>()
 
     [<Fact>]
     let NotStructConstraintFail() =
-        CompilerAssert.TypeCheckSingleError
-            """
+        CompilerAssert.TypeCheckWithErrors """
 type RefClass<'a when 'a : not struct>() = class end
 let rAnon = RefClass<struct {| R: int |}>()
-            """ 
-            FSharpDiagnosticSeverity.Error
-            1
-            (3, 13, 3, 42)
-            "A generic construct requires that the type 'struct {| R: int |}' have reference semantics, but it does not, i.e. it is a struct"
+"""
+            [| FSharpDiagnosticSeverity.Error, 1, (3, 13, 3, 42), "A generic construct requires that the type 'struct {| R: int |}' have reference semantics, but it does not, i.e. it is a struct"
+               FSharpDiagnosticSeverity.Error, 1, (3, 13, 3, 44), "A generic construct requires that the type 'struct {| R: int |}' have reference semantics, but it does not, i.e. it is a struct" |]
 
     [<Fact>]
     let StructConstraintFail() =
-        CompilerAssert.TypeCheckSingleError
-            """
+        CompilerAssert.TypeCheckWithErrors """
 type StructClass<'a when 'a : struct>() = class end
 let sAnon = StructClass<{| S: int |}>()
-            """
-            FSharpDiagnosticSeverity.Error
-            1
-            (3, 13, 3, 38)
-            "A generic construct requires that the type '{| S: int |}' is a CLI or F# struct type"
+"""
+            [| FSharpDiagnosticSeverity.Error, 1, (3, 13, 3, 38), "A generic construct requires that the type '{| S: int |}' is a CLI or F# struct type"
+               FSharpDiagnosticSeverity.Error, 1, (3, 13, 3, 40), "A generic construct requires that the type '{| S: int |}' is a CLI or F# struct type" |]

tests/fsharp/typecheck/sigs/neg103.bsl

@@ -19,21 +19,19 @@ neg103.fs(12,26,12,34): typecheck error FS0001: This expression was expected to
 but here has type
     'MyUnion'    
 
-neg103.fs(11,5,11,11): typecheck error FS0025: Incomplete pattern matches on this expression.
-
 neg103.fs(17,7,17,15): typecheck error FS0001: This expression was expected to have type
     'int'    
 but here has type
     'MyUnion'    
 
-neg103.fs(15,5,15,11): typecheck error FS0025: Incomplete pattern matches on this expression.
+neg103.fs(15,5,15,11): typecheck error FS0025: Incomplete pattern matches on this expression. For example, the value 'CaseB' may indicate a case not covered by the pattern(s).
 
 neg103.fs(21,7,21,9): typecheck error FS0001: This expression was expected to have type
     'Async<int>'    
 but here has type
     'int'    
 
-neg103.fs(20,5,20,11): typecheck error FS0025: Incomplete pattern matches on this expression.
+neg103.fs(20,5,20,11): typecheck error FS0025: Incomplete pattern matches on this expression. For example, the value '0' may indicate a case not covered by the pattern(s).
 
 neg103.fs(25,11,25,19): typecheck error FS0001: This expression was expected to have type
     'int'    
@@ -50,4 +48,3 @@ neg103.fs(25,30,25,38): typecheck error FS0001: This expression was expected to
 but here has type
     'MyUnion'    
 
-neg103.fs(24,9,24,15): typecheck error FS0025: Incomplete pattern matches on this expression.

tests/fsharp/typecheck/sigs/neg103.vsbsl

@@ -19,21 +19,19 @@ neg103.fs(12,26,12,34): typecheck error FS0001: This expression was expected to
 but here has type
     'MyUnion'    
 
-neg103.fs(11,5,11,11): typecheck error FS0025: Incomplete pattern matches on this expression.
-
 neg103.fs(17,7,17,15): typecheck error FS0001: This expression was expected to have type
     'int'    
 but here has type
     'MyUnion'    
 
-neg103.fs(15,5,15,11): typecheck error FS0025: Incomplete pattern matches on this expression.
+neg103.fs(15,5,15,11): typecheck error FS0025: Incomplete pattern matches on this expression. For example, the value 'CaseB' may indicate a case not covered by the pattern(s).
 
 neg103.fs(21,7,21,9): typecheck error FS0001: This expression was expected to have type
     'Async<int>'    
 but here has type
     'int'    
 
-neg103.fs(20,5,20,11): typecheck error FS0025: Incomplete pattern matches on this expression.
+neg103.fs(20,5,20,11): typecheck error FS0025: Incomplete pattern matches on this expression. For example, the value '0' may indicate a case not covered by the pattern(s).
 
 neg103.fs(25,11,25,19): typecheck error FS0001: This expression was expected to have type
     'int'    
@@ -49,5 +47,3 @@ neg103.fs(25,30,25,38): typecheck error FS0001: This expression was expected to
     'int'    
 but here has type
     'MyUnion'    
-
-neg103.fs(24,9,24,15): typecheck error FS0025: Incomplete pattern matches on this expression.

tests/fsharp/typecheck/sigs/neg24.bsl

@@ -42,3 +42,47 @@ neg24.fs(313,38,313,39): typecheck error FS0020: The result of this expression h
 neg24.fs(313,47,313,48): typecheck error FS0020: The result of this expression has type 'int' and is implicitly ignored. Consider using 'ignore' to discard this value explicitly, e.g. 'expr |> ignore', or 'let' to bind the result to a name, e.g. 'let result = expr'.
 
 neg24.fs(337,37,337,42): typecheck error FS0020: The result of this expression has type 'obj' and is implicitly ignored. Consider using 'ignore' to discard this value explicitly, e.g. 'expr |> ignore', or 'let' to bind the result to a name, e.g. 'let result = expr'.
+
+neg24.fs(53,24,53,30): typecheck error FS0816: One or more of the overloads of this method has curried arguments. Consider redesigning these members to take arguments in tupled form.
+
+neg24.fs(55,31,55,37): typecheck error FS0816: One or more of the overloads of this method has curried arguments. Consider redesigning these members to take arguments in tupled form.
+
+neg24.fs(57,38,57,42): typecheck error FS0816: One or more of the overloads of this method has curried arguments. Consider redesigning these members to take arguments in tupled form.
+
+neg24.fs(60,24,60,34): typecheck error FS0816: One or more of the overloads of this method has curried arguments. Consider redesigning these members to take arguments in tupled form.
+
+neg24.fs(62,31,62,41): typecheck error FS0816: One or more of the overloads of this method has curried arguments. Consider redesigning these members to take arguments in tupled form.
+
+neg24.fs(64,44,64,48): typecheck error FS0816: One or more of the overloads of this method has curried arguments. Consider redesigning these members to take arguments in tupled form.
+
+neg24.fs(70,15,70,18): typecheck error FS0495: The member or object constructor 'M' has no argument or settable return property 'qez'. The required signature is member C.M: abc: int * def: string -> int.
+
+neg24.fs(300,29,300,30): typecheck error FS0020: The result of this expression has type 'int' and is implicitly ignored. Consider using 'ignore' to discard this value explicitly, e.g. 'expr |> ignore', or 'let' to bind the result to a name, e.g. 'let result = expr'.
+
+neg24.fs(301,17,301,18): typecheck error FS0020: The result of this expression has type 'int' and is implicitly ignored. Consider using 'ignore' to discard this value explicitly, e.g. 'expr |> ignore', or 'let' to bind the result to a name, e.g. 'let result = expr'.
+
+neg24.fs(302,33,302,34): typecheck error FS0001: All elements of a list must be implicitly convertible to the type of the first element, which here is 'unit'. This element has type 'int'.
+
+neg24.fs(302,36,302,37): typecheck error FS0001: All elements of a list must be implicitly convertible to the type of the first element, which here is 'unit'. This element has type 'int'.
+
+neg24.fs(305,24,305,25): typecheck error FS0001: This expression was expected to have type
+    'unit'    
+but here has type
+    'int'    
+
+neg24.fs(305,31,305,32): typecheck error FS0001: This expression was expected to have type
+    'unit'    
+but here has type
+    'int'    
+
+neg24.fs(308,30,308,31): typecheck error FS0020: The result of this expression has type 'int' and is implicitly ignored. Consider using 'ignore' to discard this value explicitly, e.g. 'expr |> ignore', or 'let' to bind the result to a name, e.g. 'let result = expr'.
+
+neg24.fs(309,31,309,32): typecheck error FS0001: This 'if' expression is missing an 'else' branch. Because 'if' is an expression, and not a statement, add an 'else' branch which also returns a value of type 'int'.
+
+neg24.fs(312,33,312,34): typecheck error FS0020: The result of this expression has type 'int' and is implicitly ignored. Consider using 'ignore' to discard this value explicitly, e.g. 'expr |> ignore', or 'let' to bind the result to a name, e.g. 'let result = expr'.
+
+neg24.fs(313,38,313,39): typecheck error FS0020: The result of this expression has type 'int' and is implicitly ignored. Consider using 'ignore' to discard this value explicitly, e.g. 'expr |> ignore', or 'let' to bind the result to a name, e.g. 'let result = expr'.
+
+neg24.fs(313,47,313,48): typecheck error FS0020: The result of this expression has type 'int' and is implicitly ignored. Consider using 'ignore' to discard this value explicitly, e.g. 'expr |> ignore', or 'let' to bind the result to a name, e.g. 'let result = expr'.
+
+neg24.fs(337,37,337,42): typecheck error FS0020: The result of this expression has type 'obj' and is implicitly ignored. Consider using 'ignore' to discard this value explicitly, e.g. 'expr |> ignore', or 'let' to bind the result to a name, e.g. 'let result = expr'.

tests/fsharp/typecheck/sigs/neg28.bsl

@@ -31,8 +31,12 @@ neg28.fsx(69,39,69,40): typecheck error FS0001: The type 'int -> int' does not s
 
 neg28.fsx(70,17,70,34): typecheck error FS0001: The type 'int -> int' does not support the 'comparison' constraint. For example, it does not support the 'System.IComparable' interface
 
+neg28.fsx(70,39,70,40): typecheck error FS0001: The type 'int -> int' does not support the 'equality' constraint because it is a function type
+
 neg28.fsx(71,17,71,38): typecheck error FS0001: The type 'int -> int' does not support the 'comparison' constraint. For example, it does not support the 'System.IComparable' interface
 
+neg28.fsx(71,43,71,44): typecheck error FS0001: The type 'int -> int' does not support the 'equality' constraint because it is a function type
+
 neg28.fsx(79,17,79,39): typecheck error FS0001: The type 'System.Type' does not support the 'comparison' constraint. For example, it does not support the 'System.IComparable' interface
 
 neg28.fsx(80,17,80,41): typecheck error FS0001: The type 'System.Type' does not support the 'comparison' constraint. For example, it does not support the 'System.IComparable' interface

tests/fsharp/typecheck/sigs/neg30.bsl

@@ -9,16 +9,28 @@ neg30.fs(45,7,45,16): typecheck error FS0001: A generic construct requires that
 
 neg30.fs(46,7,46,26): typecheck error FS0001: A generic construct requires that the type 'SBadRecursion' is an unmanaged type
 
+neg30.fs(46,7,46,26): typecheck error FS1133: No constructors are available for the type 'SBadRecursion'
+
 neg30.fs(47,6,47,8): typecheck error FS0001: A generic construct requires that the type 'FSharpUnion' is an unmanaged type
 
+neg30.fs(59,9,59,26): typecheck error FS0001: A generic construct requires that the type 'SManaged' is an unmanaged type
+
 neg30.fs(59,13,59,24): typecheck error FS0001: A generic construct requires that the type 'SManaged' is an unmanaged type
 
+neg30.fs(60,9,60,35): typecheck error FS0001: A generic construct requires that the type 'SManagedRecursive' is an unmanaged type
+
 neg30.fs(60,13,60,33): typecheck error FS0001: A generic construct requires that the type 'SManagedRecursive' is an unmanaged type
 
+neg30.fs(61,9,61,21): typecheck error FS0001: A generic construct requires that the type 'obj' is an unmanaged type
+
 neg30.fs(61,13,61,19): typecheck error FS0001: A generic construct requires that the type 'obj' is an unmanaged type
 
+neg30.fs(62,9,62,31): typecheck error FS0001: A generic construct requires that the type 'SBadRecursion' is an unmanaged type
+
 neg30.fs(62,13,62,29): typecheck error FS0001: A generic construct requires that the type 'SBadRecursion' is an unmanaged type
 
+neg30.fs(63,9,63,29): typecheck error FS0001: A generic construct requires that the type 'FSharpUnion' is an unmanaged type
+
 neg30.fs(63,13,63,27): typecheck error FS0001: A generic construct requires that the type 'FSharpUnion' is an unmanaged type
 
 neg30.fs(71,12,71,35): typecheck error FS0120: hello!

tests/fsharp/typecheck/sigs/neg45.bsl

@@ -25,8 +25,6 @@ neg45.fs(64,19,64,20): typecheck error FS0025: Incomplete pattern matches on thi
 
 neg45.fs(72,26,72,31): typecheck error FS0001: A type parameter is missing a constraint 'when 'T :> System.IComparable'
 
-neg45.fs(72,10,72,19): typecheck error FS0035: This construct is deprecated: This type abbreviation has one or more declared type parameters that do not appear in the type being abbreviated. Type abbreviations must use all declared type parameters in the type being abbreviated. Consider removing one or more type parameters, or use a concrete type definition that wraps an underlying type, such as 'type C<'a> = C of ...'.
-
 neg45.fs(73,36,73,41): typecheck error FS0001: A type parameter is missing a constraint 'when 'T :> System.IComparable'
 
 neg45.fs(73,36,73,41): typecheck error FS0193: A type parameter is missing a constraint 'when 'T :> System.IComparable'