Skip to content

Commit 7fd419a

Browse files
committed
Revert "wip"
This reverts commit cdb8e93. # Conflicts: # tests/FSharp.Compiler.ComponentTests/ErrorMessages/ExtendedDiagnosticDataTests.fs
1 parent 5b80620 commit 7fd419a

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/Compiler/Checking/ConstraintSolver.fs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ exception ConstraintSolverTupleDiffLengths of displayEnv: DisplayEnv * contextIn
216216

217217
exception ConstraintSolverInfiniteTypes of displayEnv: DisplayEnv * contextInfo: ContextInfo * TType * TType * range * range
218218

219-
exception ConstraintSolverTypesNotInEqualityRelation of displayEnv: DisplayEnv * expectedTy: TType * actualTy: TType * range * range * ContextInfo
219+
exception ConstraintSolverTypesNotInEqualityRelation of displayEnv: DisplayEnv * TType * TType * range * range * ContextInfo
220220

221221
exception ConstraintSolverTypesNotInSubsumptionRelation of displayEnv: DisplayEnv * argTy: TType * paramTy: TType * callRange: range * parameterRange: range
222222

@@ -1756,7 +1756,7 @@ and SolveMemberConstraint (csenv: ConstraintSolverEnv) ignoreUnresolvedOverload
17561756
(minfos |> List.forall (fun (_, minfo) -> isIntegerTy g minfo.ApparentEnclosingType ) &&
17571757
( IsAddSubModType nm g argTy1 && IsBinaryOpOtherArgType g permitWeakResolution argTy2
17581758
|| IsAddSubModType nm g argTy2 && IsBinaryOpOtherArgType g permitWeakResolution argTy1)) ->
1759-
do! SolveTypeEqualsTypeKeepAbbrevs csenv ndeep m2 trace argTy1 argTy2
1759+
do! SolveTypeEqualsTypeKeepAbbrevs csenv ndeep m2 trace argTy2 argTy1
17601760
do! SolveTypeEqualsTypeKeepAbbrevs csenv ndeep m2 trace retTy argTy1
17611761
return TTraitBuiltIn
17621762

@@ -3184,8 +3184,6 @@ and SolveTypeEqualsTypeWithReport (csenv: ConstraintSolverEnv) ndeep m trace cxs
31843184
(fun () -> SolveTypeEqualsTypeKeepAbbrevsWithCxsln csenv ndeep m trace cxsln expectedTy actualTy)
31853185
(function
31863186
| AbortForFailedMemberConstraintResolution as err -> ErrorD err
3187-
| ConstraintSolverTypesNotInEqualityRelation(_, expectedTy, actualTy, _, _, _) as err ->
3188-
ErrorD (ErrorFromAddingTypeEquation(csenv.g, csenv.DisplayEnv, expectedTy, actualTy, err, m))
31893187
| res -> ErrorD (ErrorFromAddingTypeEquation(csenv.g, csenv.DisplayEnv, expectedTy, actualTy, res, m)))
31903188

31913189
and ArgsMustSubsumeOrConvert

src/Compiler/Checking/ConstraintSolver.fsi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,8 @@ exception ConstraintSolverInfiniteTypes of
104104

105105
exception ConstraintSolverTypesNotInEqualityRelation of
106106
displayEnv: DisplayEnv *
107-
expectedTy: TType *
108-
actualTy: TType *
107+
TType *
108+
TType *
109109
range *
110110
range *
111111
ContextInfo

0 commit comments

Comments
 (0)