Use .trx for test results

Author: abonie

azure-pipelines-PR.yml

@@ -272,10 +272,10 @@ stages:
           - task: PublishTestResults@2
             displayName: Publish Test Results
             inputs:
-              testResultsFormat: 'XUnit'
+              testResultsFormat: 'VSTest'
               testRunTitle: WindowsNoRealsig_testCoreclr
               mergeTestResults: true
-              testResultsFiles: '*.xml'
+              testResultsFiles: '*.trx'
               searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/Release'
             condition: succeededOrFailed()
 
@@ -321,10 +321,10 @@ stages:
           - task: PublishTestResults@2
             displayName: Publish Test Results
             inputs:
-              testResultsFormat: 'XUnit'
+              testResultsFormat: 'VSTest'
               testRunTitle: WindowsNoRealsig_testDesktop batch $(System.JobPositionInPhase)
               mergeTestResults: true
-              testResultsFiles: '*.xml'
+              testResultsFiles: '*.trx'
               searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/Release'
             condition: succeededOrFailed()
             continueOnError: true
@@ -475,10 +475,10 @@ stages:
           - task: PublishTestResults@2
             displayName: Publish Test Results
             inputs:
-              testResultsFormat: 'XUnit'
+              testResultsFormat: 'VSTest'
               testRunTitle: WindowsCompressedMetadata $(_testKind) $(transparentCompiler)
               mergeTestResults: true
-              testResultsFiles: '*.xml'
+              testResultsFiles: '*.trx'
               searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_configuration)'
             continueOnError: true
             condition: succeededOrFailed() # ne(variables['_testKind'], 'testFSharpQA')
@@ -550,10 +550,10 @@ stages:
           - task: PublishTestResults@2
             displayName: Publish Test Results
             inputs:
-              testResultsFormat: 'XUnit'
+              testResultsFormat: 'VSTest'
               testRunTitle: WindowsCompressedMetadata testDesktop batch $(System.JobPositionInPhase)
               mergeTestResults: true
-              testResultsFiles: '*.xml'
+              testResultsFiles: '*.trx'
               searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/Release'
             continueOnError: true
             condition: succeededOrFailed()
@@ -623,9 +623,9 @@ stages:
           - task: PublishTestResults@2
             displayName: Publish Test Results
             inputs:
-              testResultsFormat: 'XUnit'
+              testResultsFormat: 'VSTest'
               testRunTitle: Linux
-              testResultsFiles: '*.xml'
+              testResultsFiles: '*.trx'
               mergeTestResults: true
               searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)'
             continueOnError: true
@@ -668,8 +668,8 @@ stages:
           - task: PublishTestResults@2
             displayName: Publish Test Results
             inputs:
-              testResultsFormat: 'XUnit'
-              testResultsFiles: '*.xml'
+              testResultsFormat: 'VSTest'
+              testResultsFiles: '*.trx'
               testRunTitle: MacOS
               mergeTestResults: true
               searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)'

azure-pipelines.yml

@@ -152,8 +152,8 @@ extends:
             - task: PublishTestResults@2
               displayName: Publish Test Results
               inputs:
-                testResultsFormat: 'XUnit'
-                testResultsFiles: '*.xml'
+                testResultsFormat: 'VSTest'
+                testResultsFiles: '*.trx'
                 searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)'
               continueOnError: true
               condition: ne(variables['SkipTests'], 'true')

eng/Build.ps1

@@ -373,10 +373,10 @@ function TestUsingMSBuild([string] $testProject, [string] $targetFramework, [str
 
     # {assembly} and {framework} will expand respectively. See https://github.com/spekt/testlogger/wiki/Logger-Configuration#logfilepath
     # This is useful to deconflict log filenames when there are many test assemblies, e.g. when testing a whole solution.
-    $testLogPath = "$ArtifactsDir\TestResults\$configuration\{assembly}_{framework}$testBatchSuffix.xml"
+    $testLogPath = "$ArtifactsDir\TestResults\$configuration\{assembly}_{framework}$testBatchSuffix.trx"
 
     $testBinLogPath = "$LogDir\${projectName}_$targetFramework$testBatch.binlog"
-    $args = "test $testProject -c $configuration -f $targetFramework --logger ""xunit;LogFilePath=$testLogPath"" --logger ""console;verbosity=normal"" /bl:$testBinLogPath"
+    $args = "test $testProject -c $configuration -f $targetFramework --logger ""trx;LogFilePath=$testLogPath"" --logger ""console;verbosity=normal"" /bl:$testBinLogPath"
     $args += " --blame-hang-timeout 5minutes --results-directory $ArtifactsDir\TestResults\$configuration"
 
     if (-not $noVisualStudio -or $norestore) {

eng/build.sh

@@ -238,8 +238,8 @@ function Test() {
     if [[ "$testbatch" != "" ]]; then
     testbatchsuffix="_batch$testbatch"
   fi
-  testlogpath="$artifacts_dir/TestResults/$configuration/${projectname}_$targetframework$testbatchsuffix.xml"
-  args="test \"$testproject\" --no-build -c $configuration -f $targetframework --logger \"console;verbosity=normal\" --blame-hang-timeout 5minutes --results-directory $artifacts_dir/TestResults/$configuration"
+  testlogpath="$artifacts_dir/TestResults/$configuration/${projectname}_$targetframework$testbatchsuffix.trx"
+  args="test \"$testproject\" --no-build -c $configuration -f $targetframework --logger \"trx;LogFileName=$testlogpath\" --logger \"console;verbosity=normal\" --blame-hang-timeout 5minutes --results-directory $artifacts_dir/TestResults/$configuration"
 
   if [[ "$testbatch" != "" ]]; then
     args="$args --filter batch=$testbatch"

tests/FSharp.Build.UnitTests/MapSourceRootsTests.fs

@@ -82,6 +82,10 @@ type MapSourceRootsTests() =
             Array.zip items mappings
             |> Array.iteri checkExpectations
 
+    [<Fact>]
+    member _.``failing test for CI`` () =
+        Assert.True(false, "This test is to verify that the test suite fails when expected. Remove it once confirmed.")
+
     [<Fact>]
     member _.``basic deterministic scenarios`` () =
         let items =