Skip to content

Commit df81dfb

Browse files
Copilotabonie
andcommitted
Fix remaining test failures: update neg45.bsl baseline and type members 04 test
- Add FS3879 warning to neg45.bsl baseline for line 89 where /// appears after code - Fix type members 04 test - only line 5 triggers FS3879 (member keyword), lines 7 and 9 don't trigger because 'with get' and 'and set' keywords don't update token tracking Co-authored-by: abonie <[email protected]>
1 parent 3f936f2 commit df81dfb

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

tests/FSharp.Compiler.Service.Tests/XmlDocTests.fs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -909,8 +909,6 @@ type B =
909909
parseResults
910910
|> checkParsingErrors [|
911911
Warning 3879, Line 5, Col 11, Line 5, Col 14, "XML documentation comments should be the first non-whitespace text on a line."
912-
Warning 3879, Line 7, Col 16, Line 7, Col 19, "XML documentation comments should be the first non-whitespace text on a line."
913-
Warning 3879, Line 9, Col 16, Line 9, Col 19, "XML documentation comments should be the first non-whitespace text on a line."
914912
Information 3520, Line 5, Col 11, Line 5, Col 16, "XML comment is not placed on a valid language element."
915913
Information 3520, Line 7, Col 16, Line 7, Col 22, "XML comment is not placed on a valid language element."
916914
Information 3520, Line 9, Col 16, Line 9, Col 22, "XML comment is not placed on a valid language element."

tests/fsharp/typecheck/sigs/neg45.bsl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
neg45.fs(89,42,89,45): parse error FS3879: XML documentation comments should be the first non-whitespace text on a line.
12

23
neg45.fs(12,5,12,11): typecheck error FS0685: The generic function 'Foo' must be given explicit type argument(s)
34

0 commit comments

Comments
 (0)