How should F# bootstrapping be handled in source-build?

[crummel]

As I understand it the Proto build in F# bootstraps F# and requires a version of FSharp.Core that doesn't participate in version flow. This brings in the FSharp.Core version used as a source-build prebuilt. Should this package be updated with the previously-source-built version flow? Is bootstrapping necessary in the source-build F# build?

[vzarytovskii]

I'll leave it for @KevinRansom to describe :)

[KevinRansom]

@vzarytovskii , thanks mate, I appreciate it :-)
@crummel.

We use a last known good to build the proto compiler, including a proto fsharp.core and a proto fsharp.build.dll, as it were.

There is a crappy hack in there to use a published fsharp.core, solely because we expect the fsharp.build.dll to load into visual studio, and we "need" to ensure that when we build the proto fsharp.build.dll it matches a published fsharp.core.

In source build that is absolutely not necessary ... and so you can change the condition
to exclude doing this package reference on source build too.
Here:

fsharp/src/FSharp.Build/FSharp.Build.fsproj

Line 55 in 2211866

<ItemGroup Condition="'$(Configuration)' == 'Proto'">

and here:

fsharp/src/FSharp.Build/FSharp.Build.fsproj

Line 63 in 2211866

<ItemGroup Condition="'$(Configuration)' != 'Proto'">