Skip to content

Implement #elif preprocessor directive #19045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Implement #elif preprocessor directive #19045

wants to merge 5 commits into from
+341 −21

Conversation

@Thorium
Copy link
Contributor

@Thorium Thorium commented Nov 2, 2025 •
edited
Loading

Implement #elif preprocessor directive

Fix for fsharp/fslang-suggestions#1370

Checklist

  • Test cases added
  • Performance benchmarks added in case of performance changes
  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

Edit: RFC

@Thorium Thorium requested a review from a team as a code owner November 2, 2025 09:02
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/11.0.0.md

@Martin521
Copy link
Contributor

Martin521 commented Nov 2, 2025

Nice work.
But this is not a fix, but a new feature that needs an RFC.
(Which should also document the effect on tooling (where it is / can be a breaking change).

@T-Gro
Copy link
Member

T-Gro commented Nov 3, 2025

Thank you for the contribution.
The RFC makes sense, it also acts as a notification mechanism for other interested parties (IDEs and Fantomas come to mind).
Parts of the RFC text on usage should then also make their way into the docs.

It's definitely good to see this early in the F#11 development cycle, as it gives enough time to others for adjustment 👍

@Thorium
Copy link
Contributor Author

Thorium commented Nov 3, 2025

How is the RFC process working? Do I have to make it, or someone else?

auduchinok
auduchinok reviewed Nov 3, 2025
View reviewed changes
Copy link
Member

@auduchinok auduchinok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add lexing and parsing tests for the compiler service? TokenizerTests or SyntaxTreeTests would be a good place to start.

@Martin521
Copy link
Contributor

Martin521 commented Nov 3, 2025

How is the RFC process working? Do I have to make it, or someone else?

It is typically created by somebody interested in the feature. The process is described in the readme of the lang-design repo and further documentation is in the RFC template. I think the RFC can be rather brief in this case.

@Thorium Thorium mentioned this pull request Nov 3, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@auduchinok auduchinok auduchinok left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Status: New

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thorium @Martin521 @T-Gro @auduchinok