Use bash array for SED_INPLACE_FLAGS to properly handle empty string on macOS

Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>

Author: Copilot

builds/create-csproj-for-all-packagereferences.sh

@@ -6,9 +6,9 @@ CLEAR=$(tput sgr0 || true)
 
 # Detect the OS to use the right sed syntax
 if [[ "$(uname -s)" == "Darwin" ]]; then
-	SED_INPLACE_FLAGS="-i ''"
+	SED_INPLACE_FLAGS=(-i '')
 else
-	SED_INPLACE_FLAGS="-i"
+	SED_INPLACE_FLAGS=(-i)
 fi
 
 OUTPUTPATH=
@@ -51,16 +51,16 @@ cd "$(git rev-parse --show-toplevel)"
 git grep -e '<PackageReference.*Include="[a-zA-Z0-9._-]*".*Version="[a-zA-Z0-9._-]*".*>' -h > "$TMPPATH"
 
 # Replace double double quotes with a single double quote. This happens in source code that generates project files (for tests).
-sed $SED_INPLACE_FLAGS 's/""/"/g' "$TMPPATH"
+sed "${SED_INPLACE_FLAGS[@]}" 's/""/"/g' "$TMPPATH"
 
 # Remove packages that we build locally
-sed $SED_INPLACE_FLAGS '/Xamarin.Tests.FrameworksInRuntimesNativeDirectory/d' "$TMPPATH"
-sed $SED_INPLACE_FLAGS '/Xamarin.Tests.DynamicLibrariesInRuntimesNativeDirectory/d' "$TMPPATH"
-sed $SED_INPLACE_FLAGS '/Xamarin.Tests.XCFrameworkWithStaticLibraryInRuntimesNativeDirectory/d' "$TMPPATH"
-sed $SED_INPLACE_FLAGS '/Xamarin.Tests.XCFrameworkWithSymlinks/d' "$TMPPATH"
+sed "${SED_INPLACE_FLAGS[@]}" '/Xamarin.Tests.FrameworksInRuntimesNativeDirectory/d' "$TMPPATH"
+sed "${SED_INPLACE_FLAGS[@]}" '/Xamarin.Tests.DynamicLibrariesInRuntimesNativeDirectory/d' "$TMPPATH"
+sed "${SED_INPLACE_FLAGS[@]}" '/Xamarin.Tests.XCFrameworkWithStaticLibraryInRuntimesNativeDirectory/d' "$TMPPATH"
+sed "${SED_INPLACE_FLAGS[@]}" '/Xamarin.Tests.XCFrameworkWithSymlinks/d' "$TMPPATH"
 
 # Get only the name and version of each package, and write that back in a PackageDownload item
-sed $SED_INPLACE_FLAGS 's@.*<PackageReference.*Include="\([a-zA-Z0-9._-]*\)".*Version="\([a-zA-Z0-9._-]*\)".*>.*@\t\t<PackageDownload Include="\1" Version="[\2]" />@g' "$TMPPATH"
+sed "${SED_INPLACE_FLAGS[@]}" 's@.*<PackageReference.*Include="\([a-zA-Z0-9._-]*\)".*Version="\([a-zA-Z0-9._-]*\)".*>.*@\t\t<PackageDownload Include="\1" Version="[\2]" />@g' "$TMPPATH"
 
 # Sort the references and only list each once.
 sort -u -o "$TMPPATH" "$TMPPATH"

tools/common/create-makefile-fragment.sh

@@ -17,9 +17,9 @@ cd "$(dirname "$0")"
 
 # Detect OS for sed syntax
 if [[ "$OSTYPE" == "darwin"* ]]; then
-	SED_INPLACE_FLAGS="-i ''"
+	SED_INPLACE_FLAGS=(-i '')
 else
-	SED_INPLACE_FLAGS="-i"
+	SED_INPLACE_FLAGS=(-i)
 fi
 
 if test -z "$1"; then
@@ -111,12 +111,12 @@ for proj in $(sort "$REFERENCES_PATH" | uniq); do
 
 	# The output contains relative paths, relative to the csproj directory
 	# Change those to full paths by prepending the csproj directory.
-	sed $SED_INPLACE_FLAGS "s@^@$proj_dir/@" "$inputs_path"
+	sed "${SED_INPLACE_FLAGS[@]}" "s@^@$proj_dir/@" "$inputs_path"
 
 	# Change to Make syntax. This is horrifically difficult in MSBuild,
 	# because MSBuild blindly replaces backslashes with forward slashes (i.e.
 	# windows paths to unix paths...)
-	sed $SED_INPLACE_FLAGS "s_^\\(.*\\)\$_    \\1 \\\\_" "$inputs_path"
+	sed "${SED_INPLACE_FLAGS[@]}" "s_^\\(.*\\)\$_    \\1 \\\\_" "$inputs_path"
 
 	# Clean up
 	rm -f "$TMPPROJ"
@@ -132,7 +132,7 @@ sort "${INPUT_PATHS[@]}" | uniq >> "$FRAGMENT_PATH"
 
 # Simplify paths somewhat by removing the current directory
 if test -z "$ABSOLUTE_PATHS"; then
-	sed $SED_INPLACE_FLAGS "s@$PROJECT_DIR/@@" "$FRAGMENT_PATH"
+	sed "${SED_INPLACE_FLAGS[@]}" "s@$PROJECT_DIR/@@" "$FRAGMENT_PATH"
 fi
 
 # Cleanup