Skip to content

Commit 455aa55

Browse files
committed
[msbuild] Fix building apps with extensions remotely.
Pending: the actual fix. For now this only has a test. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2542958.
1 parent b3e805b commit 455aa55

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

tests/dotnet/UnitTests/ProjectTest.cs

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1868,6 +1868,19 @@ public void KillEverything ()
18681868
[TestCase (ApplePlatform.MacOSX, "osx-x64;osx-arm64", true)]
18691869
// [TestCase ("MacCatalyst", "")] - No extension support yet
18701870
public void BuildProjectsWithExtensions (ApplePlatform platform, string runtimeIdentifier, bool isNativeAot)
1871+
{
1872+
BuildProjectsWithExtensionsImpl (platform, runtimeIdentifier, isNativeAot);
1873+
}
1874+
1875+
[TestCase (ApplePlatform.iOS, "ios-arm64", false)]
1876+
[Category ("RemoteWindows")]
1877+
public void BuildProjectsWithExtensionsOnRemoteWindows (ApplePlatform platform, string runtimeIdentifier, bool isNativeAot)
1878+
{
1879+
Configuration.IgnoreIfNotOnWindows ();
1880+
BuildProjectsWithExtensionsImpl (platform, runtimeIdentifier, isNativeAot, AddRemoteProperties ());
1881+
}
1882+
1883+
void BuildProjectsWithExtensionsImpl (ApplePlatform platform, string runtimeIdentifier, bool isNativeAot, Dictionary<string, string>? properties = null)
18711884
{
18721885
Configuration.IgnoreIfIgnoredPlatform (platform);
18731886
var consumingProjectDir = GetProjectPath ("ExtensionConsumer", runtimeIdentifier, platform, out var appPath);
@@ -1876,7 +1889,7 @@ public void BuildProjectsWithExtensions (ApplePlatform platform, string runtimeI
18761889
Clean (extensionProjectDir);
18771890
Clean (consumingProjectDir);
18781891

1879-
var properties = GetDefaultProperties (runtimeIdentifier);
1892+
properties = GetDefaultProperties (runtimeIdentifier, extraProperties: properties);
18801893

18811894
if (isNativeAot) {
18821895
properties ["PublishAot"] = "true";

0 commit comments

Comments
 (0)