Skip to content

Commit 49f65ca

Browse files
dalexsotodalexsoto
authored
Merge branch 'main' into dev/rolf/uikit-nullability-uiappearance-04
2 parents 0cd7fcf + 0c9b826 commit 49f65ca

File tree

15 files changed

+173
-105
lines changed

15 files changed

+173
-105
lines changed

‎.github/agents/xml-doc-writer.md‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
---
2+
name: xml-doc-writer
3+
description: Specialized agent for working with XML docs in C# source code.
4+
---
5+
6+
## Role
7+
8+
You are a specialized agent for writing XML docs in C# source code. Your job is to validate and improve existing XML docs, and also write XML docs.
9+
10+
## When to Invoke
11+
12+
- When asked to from the Copilot CLI.
13+
14+
## Workflow
15+
16+
Step 1: Gather required information
17+
18+
Before invoking this skill, make sure to know exactly which C# API whose XML docs to work on.
19+
20+
Step 2: Write XML docs
21+
22+
* Add XML docs for public or protected members and types that don't have any docs.
23+
* Remove any XML docs that are exactly "To be added."
24+
* If there's an XML doc that is added with an include attribute, replace the include attribute with the contents from the included file instead. Also remove the inlined content from the included file, and if there's nothing left in the included file, remove that file completely.
25+
* Verify existing XML comments for language, grammar, consistency and correctness.
26+
* Create 'see cref' attributes whenever suitable.
27+
* Remove unnecessary whitespace between the triple-slash and the xml comment; but keep/fix correct indentation.
28+
* Correct indentation: each nesting level adds exactly 2 spaces of indentation.
29+
* Reorder any top-level XML elements to have the following order: summary, value, param, return, exception, remarks.

‎docs/api/UIKit/UIActionSheet.xml‎

Lines changed: 0 additions & 47 deletions
This file was deleted.

‎macios/Localize/loc/de/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2716,6 +2716,15 @@
27162716
</Str>
27172717
<Disp Icon="Str" />
27182718
</Item>
2719+
<Item ItemId=";E7164" ItemType="0;.resx" PsrId="211" Leaf="true">
2720+
<Str Cat="Text">
2721+
<Val><![CDATA[The task '{0}' is trying to call an external process, but a path to Xcode has not been provided. Please file an issue at https://github.com/dotnet/macios/issues/new/choose.]]></Val>
2722+
<Tgt Cat="Text" Stat="Loc" Orig="New">
2723+
<Val><![CDATA[Die Aufgabe „{0}“ versucht, einen externen Prozess aufzurufen, aber es wurde kein Pfad zu Xcode angegeben. Melden Sie unter https://github.com/dotnet/macios/issues/new/choose ein Problem.]]></Val>
2724+
</Tgt>
2725+
</Str>
2726+
<Disp Icon="Str" />
2727+
</Item>
27192728
<Item ItemId=";E7169" ItemType="0;.resx" PsrId="211" Leaf="true">
27202729
<Str Cat="Text">
27212730
<Val><![CDATA[The task '{0}' requires the property '{1}' to be set. Please file an issue at https://github.com/dotnet/macios/issues/new/choose.]]></Val>

‎macios/Localize/loc/es/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2716,6 +2716,15 @@
27162716
</Str>
27172717
<Disp Icon="Str" />
27182718
</Item>
2719+
<Item ItemId=";E7164" ItemType="0;.resx" PsrId="211" Leaf="true">
2720+
<Str Cat="Text">
2721+
<Val><![CDATA[The task '{0}' is trying to call an external process, but a path to Xcode has not been provided. Please file an issue at https://github.com/dotnet/macios/issues/new/choose.]]></Val>
2722+
<Tgt Cat="Text" Stat="Loc" Orig="New">
2723+
<Val><![CDATA[La tarea ''{0}'' está intentando llamar a un proceso externo, pero no se ha proporcionado una ruta de acceso a Xcode. Envíe un problema en https://github.com/dotnet/macios/issues/new/choose.]]></Val>
2724+
</Tgt>
2725+
</Str>
2726+
<Disp Icon="Str" />
2727+
</Item>
27192728
<Item ItemId=";E7169" ItemType="0;.resx" PsrId="211" Leaf="true">
27202729
<Str Cat="Text">
27212730
<Val><![CDATA[The task '{0}' requires the property '{1}' to be set. Please file an issue at https://github.com/dotnet/macios/issues/new/choose.]]></Val>

‎macios/Localize/loc/fr/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2716,6 +2716,15 @@
27162716
</Str>
27172717
<Disp Icon="Str" />
27182718
</Item>
2719+
<Item ItemId=";E7164" ItemType="0;.resx" PsrId="211" Leaf="true">
2720+
<Str Cat="Text">
2721+
<Val><![CDATA[The task '{0}' is trying to call an external process, but a path to Xcode has not been provided. Please file an issue at https://github.com/dotnet/macios/issues/new/choose.]]></Val>
2722+
<Tgt Cat="Text" Stat="Loc" Orig="New">
2723+
<Val><![CDATA[La tâche « {0} » tente d’appeler un processus externe, mais aucun chemin d’accès à Xcode n’a été fourni. Veuillez signaler un problème sur https://github.com/dotnet/macios/issues/new/choose.]]></Val>
2724+
</Tgt>
2725+
</Str>
2726+
<Disp Icon="Str" />
2727+
</Item>
27192728
<Item ItemId=";E7169" ItemType="0;.resx" PsrId="211" Leaf="true">
27202729
<Str Cat="Text">
27212730
<Val><![CDATA[The task '{0}' requires the property '{1}' to be set. Please file an issue at https://github.com/dotnet/macios/issues/new/choose.]]></Val>

‎macios/Localize/loc/it/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2716,6 +2716,15 @@
27162716
</Str>
27172717
<Disp Icon="Str" />
27182718
</Item>
2719+
<Item ItemId=";E7164" ItemType="0;.resx" PsrId="211" Leaf="true">
2720+
<Str Cat="Text">
2721+
<Val><![CDATA[The task '{0}' is trying to call an external process, but a path to Xcode has not been provided. Please file an issue at https://github.com/dotnet/macios/issues/new/choose.]]></Val>
2722+
<Tgt Cat="Text" Stat="Loc" Orig="New">
2723+
<Val><![CDATA[L'attività '{0}' sta tentando di chiamare un processo esterno, ma non è stato specificato il percorso a Xcode. Segnalare un problema all'indirizzo https://github.com/dotnet/macios/issues/new/choose.]]></Val>
2724+
</Tgt>
2725+
</Str>
2726+
<Disp Icon="Str" />
2727+
</Item>
27192728
<Item ItemId=";E7169" ItemType="0;.resx" PsrId="211" Leaf="true">
27202729
<Str Cat="Text">
27212730
<Val><![CDATA[The task '{0}' requires the property '{1}' to be set. Please file an issue at https://github.com/dotnet/macios/issues/new/choose.]]></Val>

‎macios/Localize/loc/pl/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2716,6 +2716,15 @@
27162716
</Str>
27172717
<Disp Icon="Str" />
27182718
</Item>
2719+
<Item ItemId=";E7164" ItemType="0;.resx" PsrId="211" Leaf="true">
2720+
<Str Cat="Text">
2721+
<Val><![CDATA[The task '{0}' is trying to call an external process, but a path to Xcode has not been provided. Please file an issue at https://github.com/dotnet/macios/issues/new/choose.]]></Val>
2722+
<Tgt Cat="Text" Stat="Loc" Orig="New">
2723+
<Val><![CDATA[Zadanie „{0}” próbuje wywołać proces zewnętrzny, ale nie podano ścieżki do Xcode. Zgłoś problem pod adresem https://github.com/dotnet/macios/issues/new/choose.]]></Val>
2724+
</Tgt>
2725+
</Str>
2726+
<Disp Icon="Str" />
2727+
</Item>
27192728
<Item ItemId=";E7169" ItemType="0;.resx" PsrId="211" Leaf="true">
27202729
<Str Cat="Text">
27212730
<Val><![CDATA[The task '{0}' requires the property '{1}' to be set. Please file an issue at https://github.com/dotnet/macios/issues/new/choose.]]></Val>

‎macios/Localize/loc/tr/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2716,6 +2716,15 @@
27162716
</Str>
27172717
<Disp Icon="Str" />
27182718
</Item>
2719+
<Item ItemId=";E7164" ItemType="0;.resx" PsrId="211" Leaf="true">
2720+
<Str Cat="Text">
2721+
<Val><![CDATA[The task '{0}' is trying to call an external process, but a path to Xcode has not been provided. Please file an issue at https://github.com/dotnet/macios/issues/new/choose.]]></Val>
2722+
<Tgt Cat="Text" Stat="Loc" Orig="New">
2723+
<Val><![CDATA['{0}' görevi bir dış işlemi çağırmaya çalışıyor, ancak Xcode yolu belirtilmemiş. Lütfen sorunu https://github.com/dotnet/macios/issues/new/choose adresinden bildirin.]]></Val>
2724+
</Tgt>
2725+
</Str>
2726+
<Disp Icon="Str" />
2727+
</Item>
27192728
<Item ItemId=";E7169" ItemType="0;.resx" PsrId="211" Leaf="true">
27202729
<Str Cat="Text">
27212730
<Val><![CDATA[The task '{0}' requires the property '{1}' to be set. Please file an issue at https://github.com/dotnet/macios/issues/new/choose.]]></Val>

‎macios/Localize/loc/zh-Hans/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2716,6 +2716,15 @@
27162716
</Str>
27172717
<Disp Icon="Str" />
27182718
</Item>
2719+
<Item ItemId=";E7164" ItemType="0;.resx" PsrId="211" Leaf="true">
2720+
<Str Cat="Text">
2721+
<Val><![CDATA[The task '{0}' is trying to call an external process, but a path to Xcode has not been provided. Please file an issue at https://github.com/dotnet/macios/issues/new/choose.]]></Val>
2722+
<Tgt Cat="Text" Stat="Loc" Orig="New">
2723+
<Val><![CDATA[任务 "{0}" 正在尝试调用外部进程，但 Xcode 的路径尚未提供。请通过 https://github.com/dotnet/macios/issues/new/choose 提交问题。]]></Val>
2724+
</Tgt>
2725+
</Str>
2726+
<Disp Icon="Str" />
2727+
</Item>
27192728
<Item ItemId=";E7169" ItemType="0;.resx" PsrId="211" Leaf="true">
27202729
<Str Cat="Text">
27212730
<Val><![CDATA[The task '{0}' requires the property '{1}' to be set. Please file an issue at https://github.com/dotnet/macios/issues/new/choose.]]></Val>

‎src/CoreVideo/CVPixelBufferAttributes.cs‎

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -259,12 +259,7 @@ public int? PlaneAlignment {
259259
}
260260
}
261261

262-
// TODO: kCVPixelBufferIOSurfacePropertiesKey
263-
#if !MONOMAC
264-
// The presence of the IOSurfacePropertiesKey mandates the allocation via IOSurfaceProperty
265-
/// <summary>If this key is set, this instructs CoreVideo to allocate the video buffers using the IOSurface.    This is required for some uses of pixel buffers.</summary>
266-
/// <value>To be added.</value>
267-
/// <remarks>To be added.</remarks>
262+
/// <summary>If this key is set, this instructs CoreVideo to allocate the video buffers using the <see cref="IOSurface.IOSurface" />. This is required for some uses of pixel buffers.</summary>
268263
public bool? AllocateWithIOSurface {
269264
set {
270265
if (value.HasValue && value.Value)
@@ -277,11 +272,9 @@ public bool? AllocateWithIOSurface {
277272
}
278273
}
279274

280-
#if !__MACCATALYST__
275+
#if !__MACCATALYST__ && !__MACOS__
281276
/// <summary>Indicates whether the pixel buffer is compatible with OpenGL for Embedded Systems contexts.</summary>
282-
/// <value>
283-
/// </value>
284-
/// <remarks>The property uses constant kCVPixelBufferOpenGLESCompatibilityKey value to access the underlying dictionary.</remarks>
277+
/// <remarks>The property uses the <c>kCVPixelBufferOpenGLESCompatibilityKey</c> constant to access the underlying dictionary.</remarks>
285278
[SupportedOSPlatform ("ios")]
286279
[UnsupportedOSPlatform ("maccatalyst")]
287280
[UnsupportedOSPlatform ("macos")]
@@ -297,12 +290,6 @@ public bool? OpenGLESCompatibility {
297290
#endif
298291

299292
/// <summary>Indicates whether the pixel buffer is compatible with Metal.</summary>
300-
/// <value>To be added.</value>
301-
/// <remarks>To be added.</remarks>
302-
[SupportedOSPlatform ("ios")]
303-
[SupportedOSPlatform ("maccatalyst")]
304-
[SupportedOSPlatform ("tvos")]
305-
[UnsupportedOSPlatform ("macos")]
306293
public bool? MetalCompatibility {
307294
set {
308295
SetBooleanValue (CVPixelBuffer.MetalCompatibilityKey, value);
@@ -311,7 +298,6 @@ public bool? MetalCompatibility {
311298
return GetBoolValue (CVPixelBuffer.MetalCompatibilityKey);
312299
}
313300
}
314-
#endif
315-
#endif
301+
#endif // !COREBUILD
316302
}
317303
}

0 commit comments

Comments
 (0)