[src] Don't copy xml docs from the declaring type of a method with [DelegateName]. (#23427)

Author: rolfbjarne

src/bgen/Generator.cs

@@ -4651,7 +4651,9 @@ group fullname by ns into g
 				if (shortName.StartsWith ("Func<", StringComparison.Ordinal))
 					continue;
 
-				WriteDocumentation (mi.DeclaringType);
+				// we might get "delegates" from DelegateName attributes, and in that case the declaring type doesn't have xml docs for the delegate (the declaring type is the container type for the member with the DelegateName attribute, and its documentation has nothing to do with the delegate type)
+				if (mi.DeclaringType.IsSubclassOf (TypeCache.System_Delegate))
+					WriteDocumentation (mi.DeclaringType);
 
 				var del = mi.DeclaringType;
 

tests/cecil-tests/Documentation.KnownFailures.txt

@@ -25933,6 +25933,7 @@ T:CoreLocation.CLBeaconIdentityConstraint
 T:CoreLocation.CLCircularGeographicCondition
 T:CoreLocation.CLCondition
 T:CoreLocation.CLLiveUpdateConfiguration
+T:CoreLocation.CLLocationManagerEventArgs
 T:CoreLocation.CLLocationPushServiceError
 T:CoreLocation.CLLocationSourceInformation
 T:CoreLocation.CLLocationUpdater
@@ -26222,6 +26223,7 @@ T:EventKit.EKParticipantScheduleStatus
 T:EventKit.EKReminderPriority
 T:EventKit.VirtualConferenceHandler
 T:EventKit.VirtualConferenceRoomTypeHandler
+T:EventKitUI.EKEventEditController
 T:ExecutionPolicy.EPDeveloperTool
 T:ExecutionPolicy.EPDeveloperToolStatus
 T:ExecutionPolicy.EPError
@@ -26287,8 +26289,11 @@ T:Foundation.NSBindingSelectionMarker
 T:Foundation.NSCollectionChangeType
 T:Foundation.NSConnectionDelegate
 T:Foundation.NSDataCompressionAlgorithm
+T:Foundation.NSDecoderCallback
+T:Foundation.NSDecoderHandler
 T:Foundation.NSDictionaryEnumerator
 T:Foundation.NSDictionaryKeyFilter
+T:Foundation.NSEncodeHook
 T:Foundation.NSExceptionError
 T:Foundation.NSExpressionCallbackHandler
 T:Foundation.NSFileManager_NSUserInformation
@@ -26310,6 +26315,8 @@ T:Foundation.NSItemProviderUTTypeLoadDelegate
 T:Foundation.NSKeyValueSharedObserverRegistration_NSObject
 T:Foundation.NSLinguisticAnalysis
 T:Foundation.NSMeasurementFormatterUnitOptions
+T:Foundation.NSMetadataQueryObject
+T:Foundation.NSMetadataQueryValue
 T:Foundation.NSNotificationFlags
 T:Foundation.NSNotificationSuspensionBehavior
 T:Foundation.NSOrderedCollectionDifferenceCalculationOptions
@@ -26492,6 +26499,7 @@ T:GameController.InputStateAvailableHandler
 T:GameController.UISceneConnectionOptions_GameController
 T:GameKit.GKAccessPointLocation
 T:GameKit.GKChallengeComposeHandler2
+T:GameKit.GKChallengePredicate
 T:GameKit.GKChallengesViewControllerDelegate
 T:GameKit.GKConnectionState
 T:GameKit.GKEntriesForPlayerScopeHandler
@@ -26502,6 +26510,8 @@ T:GameKit.GKGameSessionErrorCode
 T:GameKit.GKGameSessionSharingViewControllerDelegate
 T:GameKit.GKLeaderboardType
 T:GameKit.GKMatchmakingMode
+T:GameKit.GKMatchReinvitation
+T:GameKit.GKMatchReinvitationForDisconnectedPlayer
 T:GameKit.GKReleaseState
 T:GameKit.GKTransportType
 T:GameplayKit.GKRTreeSplitStrategy
@@ -26935,6 +26945,7 @@ T:MailKit.MEMessageEncryptionState
 T:MailKit.MEMessageSecurityErrorCode
 T:MailKit.MEMessageState
 T:MapKit.MKAddressFilterOption
+T:MapKit.MKCreateClusterAnnotation
 T:MapKit.MKDirectionsRoutePreference
 T:MapKit.MKLocalSearchCompleterResultType
 T:MapKit.MKLocalSearchRegionPriority
@@ -26946,8 +26957,12 @@ T:MapKit.MKMapFeatureOptions
 T:MapKit.MKMapFeatureType
 T:MapKit.MKMapItemDetailSelectionAccessoryCalloutStyle
 T:MapKit.MKMapItemDetailViewControllerDelegate
+T:MapKit.MKMapViewAnnotation
 T:MapKit.MKMapViewDefault
+T:MapKit.MKMapViewDelegateGetSelectionAccessory
+T:MapKit.MKMapViewOverlay
 T:MapKit.MKPointOfInterestCategory
+T:MapKit.MKRendererForOverlayDelegate
 T:MapKit.MKScaleViewAlignment
 T:MapKit.MKStandardMapEmphasisStyle
 T:MediaAccessibility.MAFlashingLightsProcessor
@@ -27796,6 +27811,8 @@ T:PassKit.PKVehicleConnectionDelegate
 T:PassKit.PKVehicleConnectionErrorCode
 T:PassKit.PKVehicleConnectionSession
 T:PassKit.PKVehicleConnectionSessionConnectionState
+T:PdfKit.ClassForAnnotationClassDelegate
+T:PdfKit.ClassForAnnotationTypeDelegate
 T:PdfKit.PdfAccessPermissions
 T:PdfKit.PdfAnnotationButtonWidget
 T:PdfKit.PdfAnnotationChoiceWidget
@@ -27827,6 +27844,8 @@ T:PdfKit.PdfPageImageInitializationOption
 T:PdfKit.PdfPageImageInitializationOptionKeys
 T:PdfKit.PdfSelectionGranularity
 T:PdfKit.PdfThumbnailLayoutMode
+T:PdfKit.PdfViewScale
+T:PdfKit.PdfViewTitle
 T:PdfKit.PdfWidgetCellState
 T:PencilKit.PKCanvasViewDelegate
 T:PencilKit.PKCanvasViewDrawingPolicy
@@ -27986,7 +28005,10 @@ T:PushToTalk.PTTransmissionMode
 T:QuartzComposer.QCComposition
 T:QuartzComposer.QCCompositionLayer
 T:QuartzComposer.QCCompositionRepository
+T:QuickLook.QLEditingMode
 T:QuickLook.QLFilePreviewRequest
+T:QuickLook.QLFrame
+T:QuickLook.QLOpenUrl
 T:QuickLook.QLPreviewItemEditingMode
 T:QuickLook.QLPreviewProvider
 T:QuickLook.QLPreviewReply
@@ -27996,6 +28018,8 @@ T:QuickLook.QLPreviewReplyDrawingHandler
 T:QuickLook.QLPreviewReplyUIDocumentCreationHandler
 T:QuickLook.QLPreviewSceneActivationConfiguration
 T:QuickLook.QLPreviewSceneOptions
+T:QuickLook.QLTransition
+T:QuickLook.QLTransitionView
 T:QuickLookThumbnailing.QLFileThumbnailRequest
 T:QuickLookThumbnailing.QLThumbnailError
 T:QuickLookThumbnailing.QLThumbnailGenerationRequest
@@ -28293,6 +28317,7 @@ T:UIKit.NSTextSelectionNavigationModifier
 T:UIKit.NSTextSelectionNavigationWritingDirection
 T:UIKit.NSTextViewportLayoutControllerDelegate
 T:UIKit.OptionsMenuProviderHandler
+T:UIKit.ShouldDismiss
 T:UIKit.UIAccessibilityContrast
 T:UIKit.UIAccessibilityCustomActionHandler
 T:UIKit.UIAccessibilityCustomRotorSearch
@@ -28312,6 +28337,7 @@ T:UIKit.UIActivityItemsConfigurationPreviewIntent
 T:UIKit.UIActivityItemsConfigurationPreviewProviderHandler
 T:UIKit.UIActivitySectionTypes
 T:UIKit.UIAlertControllerSeverity
+T:UIKit.UIAlertViewPredicate
 T:UIKit.UIApplication_DefaultApplication
 T:UIKit.UIApplicationCategory
 T:UIKit.UIApplicationCategoryDefaultErrorCode
@@ -28378,6 +28404,10 @@ T:UIKit.UIDatePickerStyle
 T:UIKit.UIDeferredMenuElementCompletionHandler
 T:UIKit.UIDeferredMenuElementProviderHandler
 T:UIKit.UIDocumentCreationIntent
+T:UIKit.UIDocumentInteractionProbe
+T:UIKit.UIDocumentInteractionRectangle
+T:UIKit.UIDocumentViewController
+T:UIKit.UIDocumentViewForPreview
 T:UIKit.UIEditingInteractionConfiguration
 T:UIKit.UIEditMenuArrowDirection
 T:UIKit.UIEditMenuInteractionDelegate
@@ -28395,6 +28425,10 @@ T:UIKit.UIFontPickerViewControllerDelegate
 T:UIKit.UIFontWeightConstants
 T:UIKit.UIFontWeightExtensions
 T:UIKit.UIFontWidth
+T:UIKit.UIGestureProbe
+T:UIKit.UIGesturesEvent
+T:UIKit.UIGesturesPress
+T:UIKit.UIGesturesProbe
 T:UIKit.UIGraphicsImageRendererFormatRange
 T:UIKit.UIGuidedAccessAccessibilityFeature
 T:UIKit.UIGuidedAccessErrorCode
@@ -28434,6 +28468,9 @@ T:UIKit.UIPageControlDirection
 T:UIKit.UIPageControlInteractionState
 T:UIKit.UIPageControlProgressDelegate
 T:UIKit.UIPageControlTimerProgressDelegate
+T:UIKit.UIPageViewGetNumber
+T:UIKit.UIPageViewGetViewController
+T:UIKit.UIPageViewSpineLocationCallback
 T:UIKit.UIPasteboardDetectionPattern
 T:UIKit.UIPasteboardOptionKeys
 T:UIKit.UIPasteControlDisplayMode
@@ -28443,7 +28480,11 @@ T:UIKit.UIPencilPreferredAction
 T:UIKit.UIPointerAccessoryPosition
 T:UIKit.UIPointerEffectTintMode
 T:UIKit.UIPointerInteractionDelegate
+T:UIKit.UIPopoverControllerCondition
 T:UIKit.UIPreviewHandler
+T:UIKit.UIPrintInteraction
+T:UIKit.UIPrintInteractionCutterBehavior
+T:UIKit.UIPrintInteractionPaperList
 T:UIKit.UIPrintRenderingQuality
 T:UIKit.UISceneActivationState
 T:UIKit.UISceneCaptureState
@@ -28456,21 +28497,36 @@ T:UIKit.UIScreenshotServiceDelegatePdfHandler
 T:UIKit.UIScribbleInteractionDelegate
 T:UIKit.UIScrollType
 T:UIKit.UIScrollTypeMask
+T:UIKit.UIScrollViewCondition
+T:UIKit.UIScrollViewGetZoomView
+T:UIKit.UISearchBarPredicate
+T:UIKit.UISearchBarRangeEventArgs
 T:UIKit.UISearchControllerScopeBarActivation
 T:UIKit.UISearchTextFieldDelegate
 T:UIKit.UISheetPresentationControllerDelegate
 T:UIKit.UISheetPresentationControllerDetentIdentifier
 T:UIKit.UISplitViewControllerBackgroundStyle
+T:UIKit.UISplitViewControllerCanCollapsePredicate
 T:UIKit.UISplitViewControllerColumn
+T:UIKit.UISplitViewControllerDisplayEvent
 T:UIKit.UISplitViewControllerDisplayModeButtonVisibility
+T:UIKit.UISplitViewControllerFetchTargetForActionHandler
+T:UIKit.UISplitViewControllerGetDisplayModeForExpanding
+T:UIKit.UISplitViewControllerGetSecondaryViewController
+T:UIKit.UISplitViewControllerGetTopColumnForCollapsing
+T:UIKit.UISplitViewControllerGetViewController
+T:UIKit.UISplitViewControllerHidePredicate
 T:UIKit.UISplitViewControllerSplitBehavior
 T:UIKit.UISplitViewControllerStyle
 T:UIKit.UIStoryboardViewControllerCreator
 T:UIKit.UISwitchStyle
 T:UIKit.UITabBarControllerMode
 T:UIKit.UITabBarControllerSidebarDelegate
 T:UIKit.UITabBarControllerSidebarLayout
+T:UIKit.UITabBarGetDisplayedViewControllers
 T:UIKit.UITabBarItemAppearanceStyle
+T:UIKit.UITabBarSelection
+T:UIKit.UITabBarTabSelection
 T:UIKit.UITabGroupSidebarAppearance
 T:UIKit.UITableViewCellConfigurationUpdateHandler
 T:UIKit.UITableViewContentHuggingElements
@@ -28499,15 +28555,22 @@ T:UIKit.UITextSearchFoundTextStyle
 T:UIKit.UITextSearchMatchMethod
 T:UIKit.UITextSelectionDisplayInteractionDelegate
 T:UIKit.UITextViewBorderStyle
+T:UIKit.UITextViewChange
+T:UIKit.UITextViewCondition
+T:UIKit.UITextViewDelegateShouldInteractTextDelegate
+T:UIKit.UITextViewDelegateShouldInteractUrlDelegate
+T:UIKit.UITextViewRange
 T:UIKit.UITitlebarSeparatorStyle
 T:UIKit.UITitlebarTitleVisibility
 T:UIKit.UITitlebarToolbarStyle
 T:UIKit.UIToolTipInteractionDelegate
+T:UIKit.UITouchEventArgs
 T:UIKit.UITraitMutations
 T:UIKit.UIUpdateLinkCallback
 T:UIKit.UIUserInterfaceActiveAppearance
 T:UIKit.UIUserInterfaceLevel
 T:UIKit.UIVibrancyEffectStyle
+T:UIKit.UIWebLoaderControl
 T:UIKit.UIWindowSceneActivationActionConfigurationProvider
 T:UIKit.UIWindowSceneActivationInteractionConfigurationProvider
 T:UIKit.UIWindowSceneDelegate