Skip to content

Commit 87d4004

Browse files
authored
[src] Don't copy xml docs from the declaring type of a method with [DelegateName]. (#23427)
1 parent 2ad8a0e commit 87d4004

File tree

2 files changed

+66
-1
lines changed

2 files changed

+66
-1
lines changed

src/bgen/Generator.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4651,7 +4651,9 @@ group fullname by ns into g
46514651
if (shortName.StartsWith ("Func<", StringComparison.Ordinal))
46524652
continue;
46534653

4654-
WriteDocumentation (mi.DeclaringType);
4654+
// we might get "delegates" from DelegateName attributes, and in that case the declaring type doesn't have xml docs for the delegate (the declaring type is the container type for the member with the DelegateName attribute, and its documentation has nothing to do with the delegate type)
4655+
if (mi.DeclaringType.IsSubclassOf (TypeCache.System_Delegate))
4656+
WriteDocumentation (mi.DeclaringType);
46554657

46564658
var del = mi.DeclaringType;
46574659

tests/cecil-tests/Documentation.KnownFailures.txt

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25933,6 +25933,7 @@ T:CoreLocation.CLBeaconIdentityConstraint
2593325933
T:CoreLocation.CLCircularGeographicCondition
2593425934
T:CoreLocation.CLCondition
2593525935
T:CoreLocation.CLLiveUpdateConfiguration
25936+
T:CoreLocation.CLLocationManagerEventArgs
2593625937
T:CoreLocation.CLLocationPushServiceError
2593725938
T:CoreLocation.CLLocationSourceInformation
2593825939
T:CoreLocation.CLLocationUpdater
@@ -26222,6 +26223,7 @@ T:EventKit.EKParticipantScheduleStatus
2622226223
T:EventKit.EKReminderPriority
2622326224
T:EventKit.VirtualConferenceHandler
2622426225
T:EventKit.VirtualConferenceRoomTypeHandler
26226+
T:EventKitUI.EKEventEditController
2622526227
T:ExecutionPolicy.EPDeveloperTool
2622626228
T:ExecutionPolicy.EPDeveloperToolStatus
2622726229
T:ExecutionPolicy.EPError
@@ -26287,8 +26289,11 @@ T:Foundation.NSBindingSelectionMarker
2628726289
T:Foundation.NSCollectionChangeType
2628826290
T:Foundation.NSConnectionDelegate
2628926291
T:Foundation.NSDataCompressionAlgorithm
26292+
T:Foundation.NSDecoderCallback
26293+
T:Foundation.NSDecoderHandler
2629026294
T:Foundation.NSDictionaryEnumerator
2629126295
T:Foundation.NSDictionaryKeyFilter
26296+
T:Foundation.NSEncodeHook
2629226297
T:Foundation.NSExceptionError
2629326298
T:Foundation.NSExpressionCallbackHandler
2629426299
T:Foundation.NSFileManager_NSUserInformation
@@ -26310,6 +26315,8 @@ T:Foundation.NSItemProviderUTTypeLoadDelegate
2631026315
T:Foundation.NSKeyValueSharedObserverRegistration_NSObject
2631126316
T:Foundation.NSLinguisticAnalysis
2631226317
T:Foundation.NSMeasurementFormatterUnitOptions
26318+
T:Foundation.NSMetadataQueryObject
26319+
T:Foundation.NSMetadataQueryValue
2631326320
T:Foundation.NSNotificationFlags
2631426321
T:Foundation.NSNotificationSuspensionBehavior
2631526322
T:Foundation.NSOrderedCollectionDifferenceCalculationOptions
@@ -26492,6 +26499,7 @@ T:GameController.InputStateAvailableHandler
2649226499
T:GameController.UISceneConnectionOptions_GameController
2649326500
T:GameKit.GKAccessPointLocation
2649426501
T:GameKit.GKChallengeComposeHandler2
26502+
T:GameKit.GKChallengePredicate
2649526503
T:GameKit.GKChallengesViewControllerDelegate
2649626504
T:GameKit.GKConnectionState
2649726505
T:GameKit.GKEntriesForPlayerScopeHandler
@@ -26502,6 +26510,8 @@ T:GameKit.GKGameSessionErrorCode
2650226510
T:GameKit.GKGameSessionSharingViewControllerDelegate
2650326511
T:GameKit.GKLeaderboardType
2650426512
T:GameKit.GKMatchmakingMode
26513+
T:GameKit.GKMatchReinvitation
26514+
T:GameKit.GKMatchReinvitationForDisconnectedPlayer
2650526515
T:GameKit.GKReleaseState
2650626516
T:GameKit.GKTransportType
2650726517
T:GameplayKit.GKRTreeSplitStrategy
@@ -26935,6 +26945,7 @@ T:MailKit.MEMessageEncryptionState
2693526945
T:MailKit.MEMessageSecurityErrorCode
2693626946
T:MailKit.MEMessageState
2693726947
T:MapKit.MKAddressFilterOption
26948+
T:MapKit.MKCreateClusterAnnotation
2693826949
T:MapKit.MKDirectionsRoutePreference
2693926950
T:MapKit.MKLocalSearchCompleterResultType
2694026951
T:MapKit.MKLocalSearchRegionPriority
@@ -26946,8 +26957,12 @@ T:MapKit.MKMapFeatureOptions
2694626957
T:MapKit.MKMapFeatureType
2694726958
T:MapKit.MKMapItemDetailSelectionAccessoryCalloutStyle
2694826959
T:MapKit.MKMapItemDetailViewControllerDelegate
26960+
T:MapKit.MKMapViewAnnotation
2694926961
T:MapKit.MKMapViewDefault
26962+
T:MapKit.MKMapViewDelegateGetSelectionAccessory
26963+
T:MapKit.MKMapViewOverlay
2695026964
T:MapKit.MKPointOfInterestCategory
26965+
T:MapKit.MKRendererForOverlayDelegate
2695126966
T:MapKit.MKScaleViewAlignment
2695226967
T:MapKit.MKStandardMapEmphasisStyle
2695326968
T:MediaAccessibility.MAFlashingLightsProcessor
@@ -27796,6 +27811,8 @@ T:PassKit.PKVehicleConnectionDelegate
2779627811
T:PassKit.PKVehicleConnectionErrorCode
2779727812
T:PassKit.PKVehicleConnectionSession
2779827813
T:PassKit.PKVehicleConnectionSessionConnectionState
27814+
T:PdfKit.ClassForAnnotationClassDelegate
27815+
T:PdfKit.ClassForAnnotationTypeDelegate
2779927816
T:PdfKit.PdfAccessPermissions
2780027817
T:PdfKit.PdfAnnotationButtonWidget
2780127818
T:PdfKit.PdfAnnotationChoiceWidget
@@ -27827,6 +27844,8 @@ T:PdfKit.PdfPageImageInitializationOption
2782727844
T:PdfKit.PdfPageImageInitializationOptionKeys
2782827845
T:PdfKit.PdfSelectionGranularity
2782927846
T:PdfKit.PdfThumbnailLayoutMode
27847+
T:PdfKit.PdfViewScale
27848+
T:PdfKit.PdfViewTitle
2783027849
T:PdfKit.PdfWidgetCellState
2783127850
T:PencilKit.PKCanvasViewDelegate
2783227851
T:PencilKit.PKCanvasViewDrawingPolicy
@@ -27986,7 +28005,10 @@ T:PushToTalk.PTTransmissionMode
2798628005
T:QuartzComposer.QCComposition
2798728006
T:QuartzComposer.QCCompositionLayer
2798828007
T:QuartzComposer.QCCompositionRepository
28008+
T:QuickLook.QLEditingMode
2798928009
T:QuickLook.QLFilePreviewRequest
28010+
T:QuickLook.QLFrame
28011+
T:QuickLook.QLOpenUrl
2799028012
T:QuickLook.QLPreviewItemEditingMode
2799128013
T:QuickLook.QLPreviewProvider
2799228014
T:QuickLook.QLPreviewReply
@@ -27996,6 +28018,8 @@ T:QuickLook.QLPreviewReplyDrawingHandler
2799628018
T:QuickLook.QLPreviewReplyUIDocumentCreationHandler
2799728019
T:QuickLook.QLPreviewSceneActivationConfiguration
2799828020
T:QuickLook.QLPreviewSceneOptions
28021+
T:QuickLook.QLTransition
28022+
T:QuickLook.QLTransitionView
2799928023
T:QuickLookThumbnailing.QLFileThumbnailRequest
2800028024
T:QuickLookThumbnailing.QLThumbnailError
2800128025
T:QuickLookThumbnailing.QLThumbnailGenerationRequest
@@ -28293,6 +28317,7 @@ T:UIKit.NSTextSelectionNavigationModifier
2829328317
T:UIKit.NSTextSelectionNavigationWritingDirection
2829428318
T:UIKit.NSTextViewportLayoutControllerDelegate
2829528319
T:UIKit.OptionsMenuProviderHandler
28320+
T:UIKit.ShouldDismiss
2829628321
T:UIKit.UIAccessibilityContrast
2829728322
T:UIKit.UIAccessibilityCustomActionHandler
2829828323
T:UIKit.UIAccessibilityCustomRotorSearch
@@ -28312,6 +28337,7 @@ T:UIKit.UIActivityItemsConfigurationPreviewIntent
2831228337
T:UIKit.UIActivityItemsConfigurationPreviewProviderHandler
2831328338
T:UIKit.UIActivitySectionTypes
2831428339
T:UIKit.UIAlertControllerSeverity
28340+
T:UIKit.UIAlertViewPredicate
2831528341
T:UIKit.UIApplication_DefaultApplication
2831628342
T:UIKit.UIApplicationCategory
2831728343
T:UIKit.UIApplicationCategoryDefaultErrorCode
@@ -28378,6 +28404,10 @@ T:UIKit.UIDatePickerStyle
2837828404
T:UIKit.UIDeferredMenuElementCompletionHandler
2837928405
T:UIKit.UIDeferredMenuElementProviderHandler
2838028406
T:UIKit.UIDocumentCreationIntent
28407+
T:UIKit.UIDocumentInteractionProbe
28408+
T:UIKit.UIDocumentInteractionRectangle
28409+
T:UIKit.UIDocumentViewController
28410+
T:UIKit.UIDocumentViewForPreview
2838128411
T:UIKit.UIEditingInteractionConfiguration
2838228412
T:UIKit.UIEditMenuArrowDirection
2838328413
T:UIKit.UIEditMenuInteractionDelegate
@@ -28395,6 +28425,10 @@ T:UIKit.UIFontPickerViewControllerDelegate
2839528425
T:UIKit.UIFontWeightConstants
2839628426
T:UIKit.UIFontWeightExtensions
2839728427
T:UIKit.UIFontWidth
28428+
T:UIKit.UIGestureProbe
28429+
T:UIKit.UIGesturesEvent
28430+
T:UIKit.UIGesturesPress
28431+
T:UIKit.UIGesturesProbe
2839828432
T:UIKit.UIGraphicsImageRendererFormatRange
2839928433
T:UIKit.UIGuidedAccessAccessibilityFeature
2840028434
T:UIKit.UIGuidedAccessErrorCode
@@ -28434,6 +28468,9 @@ T:UIKit.UIPageControlDirection
2843428468
T:UIKit.UIPageControlInteractionState
2843528469
T:UIKit.UIPageControlProgressDelegate
2843628470
T:UIKit.UIPageControlTimerProgressDelegate
28471+
T:UIKit.UIPageViewGetNumber
28472+
T:UIKit.UIPageViewGetViewController
28473+
T:UIKit.UIPageViewSpineLocationCallback
2843728474
T:UIKit.UIPasteboardDetectionPattern
2843828475
T:UIKit.UIPasteboardOptionKeys
2843928476
T:UIKit.UIPasteControlDisplayMode
@@ -28443,7 +28480,11 @@ T:UIKit.UIPencilPreferredAction
2844328480
T:UIKit.UIPointerAccessoryPosition
2844428481
T:UIKit.UIPointerEffectTintMode
2844528482
T:UIKit.UIPointerInteractionDelegate
28483+
T:UIKit.UIPopoverControllerCondition
2844628484
T:UIKit.UIPreviewHandler
28485+
T:UIKit.UIPrintInteraction
28486+
T:UIKit.UIPrintInteractionCutterBehavior
28487+
T:UIKit.UIPrintInteractionPaperList
2844728488
T:UIKit.UIPrintRenderingQuality
2844828489
T:UIKit.UISceneActivationState
2844928490
T:UIKit.UISceneCaptureState
@@ -28456,21 +28497,36 @@ T:UIKit.UIScreenshotServiceDelegatePdfHandler
2845628497
T:UIKit.UIScribbleInteractionDelegate
2845728498
T:UIKit.UIScrollType
2845828499
T:UIKit.UIScrollTypeMask
28500+
T:UIKit.UIScrollViewCondition
28501+
T:UIKit.UIScrollViewGetZoomView
28502+
T:UIKit.UISearchBarPredicate
28503+
T:UIKit.UISearchBarRangeEventArgs
2845928504
T:UIKit.UISearchControllerScopeBarActivation
2846028505
T:UIKit.UISearchTextFieldDelegate
2846128506
T:UIKit.UISheetPresentationControllerDelegate
2846228507
T:UIKit.UISheetPresentationControllerDetentIdentifier
2846328508
T:UIKit.UISplitViewControllerBackgroundStyle
28509+
T:UIKit.UISplitViewControllerCanCollapsePredicate
2846428510
T:UIKit.UISplitViewControllerColumn
28511+
T:UIKit.UISplitViewControllerDisplayEvent
2846528512
T:UIKit.UISplitViewControllerDisplayModeButtonVisibility
28513+
T:UIKit.UISplitViewControllerFetchTargetForActionHandler
28514+
T:UIKit.UISplitViewControllerGetDisplayModeForExpanding
28515+
T:UIKit.UISplitViewControllerGetSecondaryViewController
28516+
T:UIKit.UISplitViewControllerGetTopColumnForCollapsing
28517+
T:UIKit.UISplitViewControllerGetViewController
28518+
T:UIKit.UISplitViewControllerHidePredicate
2846628519
T:UIKit.UISplitViewControllerSplitBehavior
2846728520
T:UIKit.UISplitViewControllerStyle
2846828521
T:UIKit.UIStoryboardViewControllerCreator
2846928522
T:UIKit.UISwitchStyle
2847028523
T:UIKit.UITabBarControllerMode
2847128524
T:UIKit.UITabBarControllerSidebarDelegate
2847228525
T:UIKit.UITabBarControllerSidebarLayout
28526+
T:UIKit.UITabBarGetDisplayedViewControllers
2847328527
T:UIKit.UITabBarItemAppearanceStyle
28528+
T:UIKit.UITabBarSelection
28529+
T:UIKit.UITabBarTabSelection
2847428530
T:UIKit.UITabGroupSidebarAppearance
2847528531
T:UIKit.UITableViewCellConfigurationUpdateHandler
2847628532
T:UIKit.UITableViewContentHuggingElements
@@ -28499,15 +28555,22 @@ T:UIKit.UITextSearchFoundTextStyle
2849928555
T:UIKit.UITextSearchMatchMethod
2850028556
T:UIKit.UITextSelectionDisplayInteractionDelegate
2850128557
T:UIKit.UITextViewBorderStyle
28558+
T:UIKit.UITextViewChange
28559+
T:UIKit.UITextViewCondition
28560+
T:UIKit.UITextViewDelegateShouldInteractTextDelegate
28561+
T:UIKit.UITextViewDelegateShouldInteractUrlDelegate
28562+
T:UIKit.UITextViewRange
2850228563
T:UIKit.UITitlebarSeparatorStyle
2850328564
T:UIKit.UITitlebarTitleVisibility
2850428565
T:UIKit.UITitlebarToolbarStyle
2850528566
T:UIKit.UIToolTipInteractionDelegate
28567+
T:UIKit.UITouchEventArgs
2850628568
T:UIKit.UITraitMutations
2850728569
T:UIKit.UIUpdateLinkCallback
2850828570
T:UIKit.UIUserInterfaceActiveAppearance
2850928571
T:UIKit.UIUserInterfaceLevel
2851028572
T:UIKit.UIVibrancyEffectStyle
28573+
T:UIKit.UIWebLoaderControl
2851128574
T:UIKit.UIWindowSceneActivationActionConfigurationProvider
2851228575
T:UIKit.UIWindowSceneActivationInteractionConfigurationProvider
2851328576
T:UIKit.UIWindowSceneDelegate

0 commit comments

Comments
 (0)