[src] Fix numerous memory leaks.

Author: rolfbjarne

src/AddressBook/ABAddressBook.cs

@@ -422,7 +422,7 @@ public nint PeopleCount {
 		public ABPerson [] GetPeople ()
 		{
 			var cfArrayRef = ABAddressBookCopyArrayOfAllPeople (GetCheckedHandle ());
-			return NSArray.ArrayFromHandle (cfArrayRef, h => new ABPerson (h, this));
+			return NSArray.ArrayFromHandle (cfArrayRef, h => new ABPerson (h, this), releaseHandle: true);
 		}
 
 		[DllImport (Constants.AddressBookLibrary)]
@@ -438,7 +438,7 @@ public ABPerson [] GetPeople (ABRecord source)
 				ObjCRuntime.ThrowHelper.ThrowArgumentNullException (nameof (source));
 			var cfArrayRef = ABAddressBookCopyArrayOfAllPeopleInSource (GetCheckedHandle (), source.Handle);
 			GC.KeepAlive (source);
-			return NSArray.ArrayFromHandle (cfArrayRef, l => new ABPerson (l, this));
+			return NSArray.ArrayFromHandle (cfArrayRef, l => new ABPerson (l, this), releaseHandle: true);
 		}
 
 		[DllImport (Constants.AddressBookLibrary)]
@@ -455,7 +455,7 @@ public ABPerson [] GetPeople (ABRecord source, ABPersonSortBy sortOrdering)
 				ObjCRuntime.ThrowHelper.ThrowArgumentNullException (nameof (source));
 			var cfArrayRef = ABAddressBookCopyArrayOfAllPeopleInSourceWithSortOrdering (GetCheckedHandle (), source.Handle, sortOrdering);
 			GC.KeepAlive (source);
-			return NSArray.ArrayFromHandle (cfArrayRef, l => new ABPerson (l, this));
+			return NSArray.ArrayFromHandle (cfArrayRef, l => new ABPerson (l, this), releaseHandle: true);
 		}
 
 		[DllImport (Constants.AddressBookLibrary)]
@@ -490,7 +490,7 @@ public nint GroupCount {
 		public ABGroup [] GetGroups ()
 		{
 			var cfArrayRef = ABAddressBookCopyArrayOfAllGroups (GetCheckedHandle ());
-			return NSArray.ArrayFromHandle (cfArrayRef, h => new ABGroup (h, this));
+			return NSArray.ArrayFromHandle (cfArrayRef, h => new ABGroup (h, this), releaseHandle: true);
 		}
 
 		[DllImport (Constants.AddressBookLibrary)]
@@ -507,7 +507,7 @@ public ABGroup [] GetGroups (ABRecord source)
 
 			var cfArrayRef = ABAddressBookCopyArrayOfAllGroupsInSource (GetCheckedHandle (), source.Handle);
 			GC.KeepAlive (source);
-			return NSArray.ArrayFromHandle (cfArrayRef, l => new ABGroup (l, this));
+			return NSArray.ArrayFromHandle (cfArrayRef, l => new ABGroup (l, this), releaseHandle: true);
 		}
 
 		[DllImport (Constants.AddressBookLibrary)]
@@ -720,7 +720,7 @@ public ABPerson [] GetPeopleWithName (string name)
 			var nameHandle = CFString.CreateNative (name);
 			try {
 				var cfArrayRef = ABAddressBookCopyPeopleWithName (Handle, nameHandle);
-				return NSArray.ArrayFromHandle (cfArrayRef, h => new ABPerson (h, this));
+				return NSArray.ArrayFromHandle (cfArrayRef, h => new ABPerson (h, this), releaseHandle: true);
 			} finally {
 				CFString.ReleaseNative (nameHandle);
 			}
@@ -739,7 +739,7 @@ public ABPerson [] GetPeopleWithName (string name)
 		public ABSource []? GetAllSources ()
 		{
 			var cfArrayRef = ABAddressBookCopyArrayOfAllSources (GetCheckedHandle ());
-			return NSArray.ArrayFromHandle (cfArrayRef, h => new ABSource (h, this));
+			return NSArray.ArrayFromHandle (cfArrayRef, h => new ABSource (h, this), releaseHandle: true);
 		}
 
 		[DllImport (Constants.AddressBookLibrary)]

src/AddressBook/ABGroup.cs

@@ -223,7 +223,7 @@ public IEnumerator<ABRecord> GetEnumerator ()
 			if (cfArrayRef == IntPtr.Zero)
 				e = new ABRecord [0];
 			else
-				e = NSArray.ArrayFromHandle (cfArrayRef, h => ABRecord.FromHandle (h, AddressBook));
+				e = NSArray.ArrayFromHandle (cfArrayRef, h => ABRecord.FromHandle (h, AddressBook), releaseHandle: true);
 			return e.GetEnumerator ();
 		}
 
@@ -250,7 +250,7 @@ public ABRecord [] GetMembers (ABPersonSortBy sortOrdering)
 			var cfArrayRef = ABGroupCopyArrayOfAllMembersWithSortOrdering (Handle, sortOrdering);
 			if (cfArrayRef == IntPtr.Zero)
 				return new ABRecord [0];
-			return NSArray.ArrayFromHandle (cfArrayRef, h => ABRecord.FromHandle (h, AddressBook));
+			return NSArray.ArrayFromHandle (cfArrayRef, h => ABRecord.FromHandle (h, AddressBook), releaseHandle: true);
 		}
 
 		[DllImport (Constants.AddressBookLibrary)]

src/CoreServices/LaunchServices.cs

@@ -190,7 +190,8 @@ public static NSUrl [] GetApplicationUrlsForUrl (NSUrl url, LSRoles roles = LSRo
 				ObjCRuntime.ThrowHelper.ThrowArgumentNullException (nameof (url));
 
 			var result = NSArray.ArrayFromHandle<NSUrl> (
-				LSCopyApplicationURLsForURL (url.Handle, roles)
+				LSCopyApplicationURLsForURL (url.Handle, roles),
+				releaseHandle: true
 			);
 			GC.KeepAlive (url);
 			return result;
@@ -260,7 +261,8 @@ public static NSUrl [] GetApplicationUrlsForBundleIdentifier (string bundleIdent
 			var bundleIdentifierHandle = CFString.CreateNative (bundleIdentifier);
 			try {
 				return NSArray.ArrayFromHandle<NSUrl> (
-					LSCopyApplicationURLsForBundleIdentifier (bundleIdentifierHandle, IntPtr.Zero)
+					LSCopyApplicationURLsForBundleIdentifier (bundleIdentifierHandle, IntPtr.Zero),
+					releaseHandle: true
 				);
 			} finally {
 				CFString.ReleaseNative (bundleIdentifierHandle);

src/CoreText/CTFontManager.cs

@@ -161,7 +161,7 @@ static NSArray EnsureNonNullArray (object [] items, string name)
 				return NSArray.ArrayFromHandle<T> (handle);
 			} finally {
 				if (releaseAfterUse)
-					CFObject.CFRetain (handle);
+					CFObject.CFRelease (handle);
 			}
 		}
 

src/CoreVideo/CVPixelFormatDescription.cs

@@ -281,7 +281,7 @@ static CVPixelFormatDescription ()
 		/// <summary>Get all the known pixel format types.</summary>
 		public static NSNumber [] AllTypes {
 			get {
-				return NSArray.ArrayFromHandle<NSNumber> (CVPixelFormatDescriptionArrayCreateWithAllPixelFormatTypes (IntPtr.Zero));
+				return NSArray.ArrayFromHandle<NSNumber> (CVPixelFormatDescriptionArrayCreateWithAllPixelFormatTypes (IntPtr.Zero), releaseHandle: true);
 			}
 		}
 

src/Foundation/NSArray.cs

@@ -469,6 +469,28 @@ static public T [] ArrayFromHandle<T> (NativeHandle handle) where T : class, INa
 			return ret;
 		}
 
+		/// <summary>Returns a strongly-typed C# array of the parametrized type from a handle to an NSArray.</summary>
+		/// <typeparam name="T">Parameter type, determines the kind of array returned.</typeparam>
+		/// <param name="handle">Pointer (handle) to the unmanaged object.</param>
+		/// <param name="releaseHandle">Whether the native NSArray instance should be released before returning or not.</param>
+		/// <returns>A C# array with the values.</returns>
+		/// <remarks>
+		///   <para>Use this method to get a set of NSObject arrays from a handle to an NSArray</para>
+		///   <example>
+		///     <code lang="c#"><![CDATA[
+		/// var someHandle = GetCopyOfNativeArray (...);
+		/// var values = NSArray.ArrayFromHandle<NSString> (someHandle, releaseHandle: true);
+		/// ]]></code>
+		///   </example>
+		/// </remarks>
+		public static T [] ArrayFromHandle<T> (NativeHandle handle, bool releaseHandle) where T : class, INativeObject
+		{
+			var rv = ArrayFromHandle<T> (handle);
+			if (releaseHandle && handle != NativeHandle.Zero)
+				NSObject.DangerousRelease (handle);
+			return rv;
+		}
+
 		static Array ArrayFromHandle (NativeHandle handle, Type elementType)
 		{
 			if (handle == NativeHandle.Zero)

src/Security/SecTrust.cs

@@ -61,7 +61,7 @@ public SecPolicy [] GetPolicies ()
 			}
 			if (result != SecStatusCode.Success)
 				throw new InvalidOperationException (result.ToString ());
-			return NSArray.ArrayFromHandle<SecPolicy> (p);
+			return NSArray.ArrayFromHandle<SecPolicy> (p, releaseHandle: true);
 		}
 
 		[DllImport (Constants.SecurityLibrary)]
@@ -173,7 +173,7 @@ public SecCertificate [] GetCustomAnchorCertificates ()
 			}
 			if (result != SecStatusCode.Success)
 				throw new InvalidOperationException (result.ToString ());
-			return NSArray.ArrayFromHandle<SecCertificate> (p);
+			return NSArray.ArrayFromHandle<SecCertificate> (p, releaseHandle: true);
 		}
 
 		[SupportedOSPlatform ("ios")]

src/Security/Trust.cs

@@ -239,7 +239,7 @@ public SecCertificate this [nint index] {
 		[SupportedOSPlatform ("ios15.0")]
 		[SupportedOSPlatform ("maccatalyst")]
 		public SecCertificate [] GetCertificateChain ()
-			=> NSArray.ArrayFromHandle<SecCertificate> (SecTrustCopyCertificateChain (Handle));
+			=> NSArray.ArrayFromHandle<SecCertificate> (SecTrustCopyCertificateChain (Handle), releaseHandle: true);
 
 		[SupportedOSPlatform ("ios")]
 		[SupportedOSPlatform ("maccatalyst")]