[RGen] Add the emitter code that generates the get/set invocations for a strong dict. (#23395)

Add the code generation for the getter and setter for all the supported
types by the strong dictionary. Added tests to ensure that all code is
correctly generated.

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: GitHub Actions Autoformatter <[email protected]>

Author: 3 people

src/rgen/Microsoft.Macios.Generator/AttributesNames.cs

@@ -89,6 +89,9 @@ static class AttributesNames {
 		if (type == typeof (ObjCBindings.Constructor)) {
 			return ExportConstructorAttribute;
 		}
+		if (type == typeof (ObjCBindings.StrongDictionaryProperty)) {
+			return ExportStrongDictionaryPropertyAttribute;
+		}
 		return null;
 	}
 

src/rgen/Microsoft.Macios.Generator/DataModel/Property.Generator.cs

@@ -45,6 +45,31 @@ public bool IsNotification
 	[MemberNotNullWhen (true, nameof (ExportPropertyData))]
 	public bool IsProperty => ExportPropertyData is not null;
 
+	/// <summary>
+	/// The data of the export attribute used to mark the value as a strong dictionary property binding.
+	/// </summary>
+	public ExportData<ObjCBindings.StrongDictionaryProperty>? ExportStrongPropertyData { get; init; }
+
+	/// <summary>
+	/// True if the property represents a strong dictionary property.
+	/// </summary>
+	[MemberNotNullWhen (true, nameof (ExportStrongPropertyData))]
+	public bool IsStrongDictionaryProperty => ExportStrongPropertyData is not null;
+
+	/// <summary>
+	/// Gets the strong dictionary key for the property, combining the class key and field name when applicable.
+	/// </summary>
+	public string? StrongDictionaryKey {
+		get {
+			if (!IsStrongDictionaryProperty)
+				return null;
+			// return the combination of the class key and the field name
+			return ExportStrongPropertyData.Value.StrongDictionaryKeyClass is null
+				? ExportStrongPropertyData.Value.Selector
+				: $"{ExportStrongPropertyData.Value.StrongDictionaryKeyClass.Value.FullyQualifiedName}.{ExportStrongPropertyData.Value.Selector}";
+		}
+	}
+
 	/// <summary>
 	/// Returns if the property was marked as thread safe.
 	/// </summary>
@@ -238,7 +263,6 @@ public static bool TryCreate (PropertyDeclarationSyntax declaration, RootContext
 				modifiers: [])
 			];
 		}
-
 		change = new (
 			name: memberName,
 			returnType: new (propertySymbol.Type, context.Compilation),
@@ -250,6 +274,7 @@ public static bool TryCreate (PropertyDeclarationSyntax declaration, RootContext
 			ForcedType = propertySymbol.GetForceTypeData (),
 			ExportFieldData = GetFieldInfo (context, propertySymbol),
 			ExportPropertyData = propertySymbol.GetExportData<ObjCBindings.Property> (),
+			ExportStrongPropertyData = propertySymbol.GetExportData<ObjCBindings.StrongDictionaryProperty> (),
 		};
 		return true;
 	}

src/rgen/Microsoft.Macios.Generator/DataModel/TypeInfo.cs

@@ -134,6 +134,11 @@ namespace Microsoft.Macios.Generator.DataModel;
 	/// </summary>
 	public bool IsTask { get; init; }
 
+	/// <summary>
+	/// True if the type represents a strong dictionary.
+	/// </summary>
+	public bool IsStrongDictionary { get; init; }
+
 	/// <summary>
 	/// Returns, if the type is an array, if its elements are a wrapped object from the objc world.
 	/// </summary>
@@ -144,6 +149,16 @@ namespace Microsoft.Macios.Generator.DataModel;
 	/// </summary>
 	public bool ArrayElementIsINativeObject { get; init; }
 
+	/// <summary>
+	/// If the type is an array of enums, it returns the special type of the underlying enum type.
+	/// </summary>
+	public SpecialType? ArrayElementEnumUnderlyingType { get; init; }
+
+	/// <summary>
+	/// Returns true if the type is an array of enums.
+	/// </summary>
+	public bool ArrayElementTypeIsEnum => ArrayElementEnumUnderlyingType is not null;
+
 	readonly bool isNSObject = false;
 
 	/// <summary>
@@ -345,6 +360,7 @@ internal TypeInfo (ITypeSymbol symbol)
 		IsNativeIntegerType = symbol.IsNativeIntegerType;
 		IsNativeEnum = symbol.HasAttribute (AttributesNames.NativeAttribute);
 		IsProtocol = symbol.HasAttribute (AttributesNames.ProtocolAttribute);
+		IsStrongDictionary = symbol.HasAttribute (AttributesNames.StrongDictionaryAttribute);
 
 		// data that we can get from the symbol without being INamedType
 		symbol.GetInheritance (
@@ -361,6 +377,7 @@ internal TypeInfo (ITypeSymbol symbol)
 			FullyQualifiedName = arraySymbol.ElementType.ToDisplayString ();
 			IsArray = true;
 			ArrayElementType = arraySymbol.ElementType.SpecialType;
+			ArrayElementEnumUnderlyingType = arraySymbol.ElementType is INamedTypeSymbol enumType ? enumType.EnumUnderlyingType?.SpecialType : null;
 			ArrayElementTypeIsWrapped = arraySymbol.ElementType.IsWrapped ();
 			ArrayElementIsINativeObject = arraySymbol.ElementType.IsINativeObject ();
 		}
@@ -459,6 +476,8 @@ public bool Equals (TypeInfo other)
 			return false;
 		if (IsProtocol != other.IsProtocol)
 			return false;
+		if (IsStrongDictionary != other.IsStrongDictionary)
+			return false;
 
 		// compare base classes and interfaces, order does not matter at all
 		var listComparer = new CollectionComparer<string> ();
@@ -496,6 +515,7 @@ public override int GetHashCode ()
 		hashCode.Add (IsNativeEnum);
 		hashCode.Add (Delegate);
 		hashCode.Add (IsProtocol);
+		hashCode.Add (IsStrongDictionary);
 		foreach (var parent in parents) {
 			hashCode.Add (parent);
 		}
@@ -764,6 +784,7 @@ public override string ToString ()
 		sb.Append ($"IsNativeIntegerType: {IsNativeIntegerType}, ");
 		sb.Append ($"IsNativeEnum: {IsNativeEnum}, ");
 		sb.Append ($"IsProtocol: {IsProtocol}, ");
+		sb.Append ($"IsStrongDictionary: {IsStrongDictionary}, ");
 		sb.Append ($"Delegate: {Delegate?.ToString () ?? "null"}, ");
 		sb.Append ($"EnumUnderlyingType: '{EnumUnderlyingType?.ToString () ?? "null"}', ");
 		sb.Append ("Parents: [");

src/rgen/Microsoft.Macios.Generator/Emitters/BindingSyntaxFactory.KnownTypes.cs

@@ -197,6 +197,15 @@ static partial class BindingSyntaxFactory {
 		@namespace: ["CoreMedia"],
 		@class: "CMSampleBuffer");
 
+	// CoreText types
+
+	/// <summary>
+	/// TypeSyntax for CoreText.CTFontDescriptor.
+	/// </summary>
+	public static readonly TypeSyntax CTFontDescriptor = StringExtensions.GetIdentifierName (
+		@namespace: ["CoreText"],
+		@class: "CTFontDescriptor");
+
 	// System types
 
 	/// <summary>
@@ -234,5 +243,4 @@ static partial class BindingSyntaxFactory {
 		@namespace: ["System", "Runtime", "CompilerServices"],
 		@class: "Unsafe");
 
-
 }

src/rgen/Microsoft.Macios.Generator/Emitters/BindingSyntaxFactory.ObjCRuntime.cs

@@ -1016,24 +1016,29 @@ internal static string GetNSNumberValue (in TypeInfo type)
 			{ Name: "nint" } => "NIntValue",
 			{ Name: "nuint" } => "NUIntValue",
 			{ Name: "nfloat" or "NFloat" } => "NFloatValue",
-			{ SpecialType: SpecialType.System_Boolean } => "BooleanValue",
-			{ SpecialType: SpecialType.System_Byte } => "ByteValue",
-			{ SpecialType: SpecialType.System_Double } => "DoubleValue",
-			{ SpecialType: SpecialType.System_Single } => "FloatValue",
-			{ SpecialType: SpecialType.System_Int16 } => "Int16Value",
-			{ SpecialType: SpecialType.System_Int32 } => "Int32Value",
-			{ SpecialType: SpecialType.System_Int64 } => "Int64Value",
-			{ SpecialType: SpecialType.System_SByte } => "SByteValue",
-			{ SpecialType: SpecialType.System_UInt16 } => "UInt16Value",
-			{ SpecialType: SpecialType.System_UInt32 } => "UInt32Value",
-			{ SpecialType: SpecialType.System_UInt64 } => "UInt64Value",
-			{ SpecialType: SpecialType.System_IntPtr } => "NIntValue",
-			{ SpecialType: SpecialType.System_UIntPtr } => "NUIntValue",
-			_ => string.Empty,
+			_ => GetNSNumberValue (type.SpecialType),
 		};
 #pragma warning restore format
 	}
 
+	internal static string GetNSNumberValue (SpecialType type)
+		=> type switch {
+			SpecialType.System_Boolean => "BooleanValue",
+			SpecialType.System_Byte => "ByteValue",
+			SpecialType.System_Double => "DoubleValue",
+			SpecialType.System_Single => "FloatValue",
+			SpecialType.System_Int16 => "Int16Value",
+			SpecialType.System_Int32 => "Int32Value",
+			SpecialType.System_Int64 => "Int64Value",
+			SpecialType.System_SByte => "SByteValue",
+			SpecialType.System_UInt16 => "UInt16Value",
+			SpecialType.System_UInt32 => "UInt32Value",
+			SpecialType.System_UInt64 => "UInt64Value",
+			SpecialType.System_IntPtr => "NIntValue",
+			SpecialType.System_UIntPtr => "NUIntValue",
+			_ => string.Empty,
+		};
+
 	/// <summary>
 	/// Generates an if-statement that throws an <see cref="ArgumentNullException"/> if the specified variable is null.
 	/// </summary>