-
Notifications
You must be signed in to change notification settings - Fork 546
Open
Labels
app-extensionsmsbuildIssues affecting our msbuild tasks/targetsIssues affecting our msbuild tasks/targets
Milestone
Description
When building an app with app extensions, as part of the app build process we build the app extensions:
macios/msbuild/Xamarin.Shared/Xamarin.Shared.targets
Lines 2656 to 2663 in 451618e
<!-- Build the referenced project if required --> | |
<MSBuild | |
Projects="@(_AppExtensionReferenceWithConfigurationExistent)" | |
Properties="%(_AppExtensionReferenceWithConfigurationExistent.SetConfiguration); %(_AppExtensionReferenceWithConfigurationExistent.SetPlatform)" | |
Condition="'@(_AppExtensionReferenceWithConfigurationExistent)' != '' and '$(_BuildReferencedExtensionProjects)' == 'true' "> | |
<Output TaskParameter="TargetOutputs" ItemName="_ResolvedAppExtensionReferences" Condition="'%(_AppExtensionReferenceWithConfigurationExistent.ReferenceOutputAssembly)' != 'false'"/> | |
</MSBuild> |
where we get the path to the resulting app extension (appex) from the "Build" target output, because we've overridden "Build" to return that for app extensions:
<Target Name="Build" Condition="'$(_InvalidConfigurationWarning)' != 'true'" DependsOnTargets="_GenerateBundleName;$(BuildDependsOn)" Outputs="@(_AppExtensionBundlePath)" /> |
However, when building from Windows, the "Build" target is overridden again:
macios/msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.Common.After.targets
Lines 112 to 113 in 451618e
<!-- Override Build --> | |
<Target Name="Build" Condition=" '$(_InvalidConfigurationWarning)' != 'true' " DependsOnTargets="$(BuildDependsOn)" Returns="@(TargetPath)"> |
so the logic specific to app extensions to return the path to the appex doesn't work.
Metadata
Metadata
Assignees
Labels
app-extensionsmsbuildIssues affecting our msbuild tasks/targetsIssues affecting our msbuild tasks/targets